@devries-cameron20 / t3code Mirror · read-only / commits / 86dbf2abd1
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 21, 11:00 UTC

fix(mobile): first visit to an iOS tab no longer flashes black (#37083)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Julius Marminge committed Nov 15, 2026 at 16:51 UTC 86dbf2abd18e631da1061f3a2489da603b2cc242
6 files changed +67 -20
apps/mobile/deps/react-native-screens-5.0.0-t3.50.tgz
Binary files a/apps/mobile/deps/react-native-screens-5.0.0-t3.50.tgz and /dev/null differ
apps/mobile/deps/react-native-screens-5.0.0-t3.55.tgz
Binary files /dev/null and b/apps/mobile/deps/react-native-screens-5.0.0-t3.55.tgz differ
apps/mobile/package.json
+1 -1
@@ -134,7 +134,7 @@
134 "react-native-pdf-jsi": "6.1.0",
135 "react-native-reanimated": "4.7.1",
136 "react-native-safe-area-context": "~5.11.1",
137 - "react-native-screens": "file:deps/react-native-screens-5.0.0-t3.50.tgz",
137 + "react-native-screens": "file:deps/react-native-screens-5.0.0-t3.55.tgz",
138 "react-native-svg": "15.16.1",
139 "react-native-webview": "14.0.1",
140 "react-native-worklets": "0.13.1",
apps/mobile/src/features/layout/workspace/WorkspaceNativeTabs.ios.tsx
+56 -9
@@ -3,16 +3,28 @@ import {
3 NAVIGATION_TAB_ICONS,
4 useEnabledNavigationTabs,
5 } from "./navigation-tabs";
6 -import { useLayoutEffect, useRef, useState, type ReactNode } from "react";
6 +import {
7 + useEffect,
8 + useLayoutEffect,
9 + useRef,
10 + useState,
11 + type Dispatch,
12 + type ReactNode,
13 + type SetStateAction,
14 +} from "react";
15 import { View, useWindowDimensions, type NativeSyntheticEvent } from "react-native";
8 -import { Tabs, type TabSelectedEvent, type TabSelectionRejectedEvent } from "react-native-screens";
16 +import {
17 + Tabs,
18 + type TabSelectedEvent,
19 + type TabSelectionPreventedEvent,
20 + type TabSelectionRejectedEvent,
21 +} from "react-native-screens";
22
23 import { WorkspaceTabsContext, useWorkspaceTabs } from "./WorkspaceTabsContext";
24 import {
25 NATIVE_WORKSPACE_TAB_SLOTS,
26 workspaceTabForNativeSlot,
27 workspaceUsesColumns,
15 - type WorkspaceTab,
28 } from "./workspace-tabs-state";
29 import {
30 NativeWorkspaceTabActivityContext,
@@ -33,8 +45,9 @@ const PULL_REQUEST_ICON = require("../../../../assets/icons/pull-request.png");
45
46 /** Retain each native controller tree; removing its root can leave RNS's stack empty. */
47 function RetainedWorkspaceTab(props: {
36 - readonly tab: WorkspaceTab;
48 + readonly slot: string;
49 readonly active: boolean;
50 + readonly setMountedSlots: Dispatch<SetStateAction<ReadonlySet<string>>>;
51 readonly children: ReactNode;
52 }) {
53 const workspace = useWorkspaceTabs()!;
@@ -61,6 +74,26 @@ function RetainedWorkspaceTab(props: {
74 );
75 if (props.active && (content?.workspace !== workspace || content?.children !== props.children))
76 setContent({ workspace, children: props.children });
77 + const mounted = content !== null;
78 + const { slot, setMountedSlots } = props;
79 + // oxlint-disable-next-line t3code/no-unreasoned-state-sync -- reports the slot's first native mount to the host, which holds the switch until then
80 + useEffect(() => {
81 + if (!mounted) return;
82 + // The header options this mount wrote reach UIKit in the commit after it.
83 + const frame = requestAnimationFrame(() =>
84 + setMountedSlots((current) => (current.has(slot) ? current : new Set(current).add(slot))),
85 + );
86 + return () => {
87 + cancelAnimationFrame(frame);
88 + // A replacement slot (e.g. a re-enabled fourth tab) must report its own mount.
89 + setMountedSlots((current) => {
90 + if (!current.has(slot)) return current;
91 + const next = new Set(current);
92 + next.delete(slot);
93 + return next;
94 + });
95 + };
96 + }, [mounted, slot, setMountedSlots]);
97 return content ? (
98 <NativeWorkspaceTabActivityContext value={activity}>
99 <WorkspaceSlotOptionsContext value={slotOptions}>
@@ -98,10 +131,15 @@ export function WorkspaceNativeTabs(props: {
131 const { colors } = useControlTheme();
132 const selectedTab = workspace.state.selectedTab;
133 const selectedSlot = workspace.settingsOpen ? -1 : primaryTabs.indexOf(selectedTab);
101 - const request = {
102 - selectedScreenKey: selectedSlot === -1 ? "settings" : NATIVE_WORKSPACE_TAB_SLOTS[selectedSlot]!,
103 - baseProvenance: provenance,
104 - };
134 + const selectedScreenKey =
135 + selectedSlot === -1 ? "settings" : NATIVE_WORKSPACE_TAB_SLOTS[selectedSlot]!;
136 + // A slot mounts its content the first time it's selected. Showing it in that same commit
137 + // shows a blank controller, then its header animates in, so the switch waits for the mount.
138 + const [mountedSlots, setMountedSlots] = useState<ReadonlySet<string>>(() => new Set());
139 + const [shownScreenKey, setShownScreenKey] = useState(selectedScreenKey);
140 + if (shownScreenKey !== selectedScreenKey && mountedSlots.has(selectedScreenKey))
141 + setShownScreenKey(selectedScreenKey);
142 + const request = { selectedScreenKey: shownScreenKey, baseProvenance: provenance };
143 return (
144 <View style={{ flex: 1 }}>
145 <Tabs.Host
@@ -117,6 +155,12 @@ export function WorkspaceNativeTabs(props: {
155 }: NativeSyntheticEvent<TabSelectionRejectedEvent>) =>
156 setProvenance(nativeEvent.provenance)
157 }
158 + onTabSelectionPrevented={({
159 + nativeEvent,
160 + }: NativeSyntheticEvent<TabSelectionPreventedEvent>) => {
161 + const tab = workspaceTabForNativeSlot(primaryTabs, nativeEvent.preventedScreenKey);
162 + if (tab) selectTab(tab);
163 + }}
164 onTabSelected={({ nativeEvent }: NativeSyntheticEvent<TabSelectedEvent>) => {
165 setProvenance(nativeEvent.provenance);
166 if (nativeEvent.actionOrigin === "programmatic-js") return;
@@ -133,6 +177,8 @@ export function WorkspaceNativeTabs(props: {
177 // Stable slot controllers keep UIKit's stacks attached when a section moves into Settings.
178 key={slot}
179 screenKey={slot}
180 + // Taps on an unmounted slot select it from JS, which shows it once it has mounted.
181 + preventNativeSelection={!mountedSlots.has(slot) && slot !== shownScreenKey}
182 title=""
183 tabBarItemAccessibilityLabel={settings ? "Settings" : WORKSPACE_TAB_LABELS[tab]}
184 ios={{
@@ -149,7 +195,8 @@ export function WorkspaceNativeTabs(props: {
195 }}
196 >
197 <RetainedWorkspaceTab
152 - tab={tab}
198 + slot={slot}
199 + setMountedSlots={setMountedSlots}
200 active={settings ? selectedSlot === -1 : selectedSlot === index}
201 >
202 {props.children}
docs/operations/mobile-screens-fork.md
+1 -1
@@ -1,7 +1,7 @@
1 # Building the mobile Screens dependency
2
3 The mobile v5 stack uses a committed tarball from the
4 -[T3 Screens fork](https://github.com/pingdotgg/react-native-screens/tree/t3-v5.0.0-t3.50).
4 +[T3 Screens fork](https://github.com/pingdotgg/react-native-screens/tree/t3-v5.0.0-t3.55).
5 The fork owns the integration changes; the app does not patch this package.
6 Each archive includes compiled JavaScript, declarations, native source and
7 `t3-fork.json` recording its version, source commit and upstream base.
pnpm-lock.yaml
+9 -9
@@ -591,7 +591,7 @@ importers:
591 version: 7.5.1(react-native@0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(react@19.3.0)
592 '@react-navigation/native-stack':
593 specifier: 7.21.0
594 - version: 7.21.0(patch_hash=990d575444c4af2ce8218b3b7a8280fe244c03abbdb32b822a2e862f791dbf42)(8cabb04b1defcb22245317e78e4e5f29)
594 + version: 7.21.0(patch_hash=990d575444c4af2ce8218b3b7a8280fe244c03abbdb32b822a2e862f791dbf42)(ce02f236e17a3519f78477aaafd5d0d9)
595 '@t3tools/client-runtime':
596 specifier: workspace:*
597 version: link:../../packages/client-runtime
@@ -779,8 +779,8 @@ importers:
779 specifier: ~5.11.1
780 version: 5.11.1(react-native@0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(react@19.3.0)
781 react-native-screens:
782 - specifier: file:deps/react-native-screens-5.0.0-t3.50.tgz
783 - version: file:apps/mobile/deps/react-native-screens-5.0.0-t3.50.tgz(react-native@0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(react@19.3.0)
782 + specifier: file:deps/react-native-screens-5.0.0-t3.55.tgz
783 + version: file:apps/mobile/deps/react-native-screens-5.0.0-t3.55.tgz(react-native@0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(react@19.3.0)
784 react-native-svg:
785 specifier: 15.16.1
786 version: 15.16.1(patch_hash=110f9243ffad03654ce40dd1cdb09f01af16b8fa2ccb2b2cd3d62e682c180399)(react-native@0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(react@19.3.0)
@@ -11617,9 +11617,9 @@ packages:
11617 react: '*'
11618 react-native: '*'
11619
11620 - react-native-screens@file:apps/mobile/deps/react-native-screens-5.0.0-t3.50.tgz:
11621 - resolution: {integrity: sha512-APO5MIX4Bf842vXuChMsL/5GTC+Xl5GQEl48QBOgUJkEGibpmU54HZ+jWWDvnIqqQyzYntKF/iK7OCSR+S4xSg==, tarball: file:apps/mobile/deps/react-native-screens-5.0.0-t3.50.tgz}
11622 - version: 5.0.0-t3.50
11620 + react-native-screens@file:apps/mobile/deps/react-native-screens-5.0.0-t3.55.tgz:
11621 + resolution: {integrity: sha512-z/bhywEopVql2Zo/u5WkCAoaWQ0a12RMzi13pzh6ktO/c6Z3F2LgjlSfDHzTJsoh6DwDlkN/WK1Ig0a4nSV5mA==, tarball: file:apps/mobile/deps/react-native-screens-5.0.0-t3.55.tgz}
11622 + version: 5.0.0-t3.55
11623 peerDependencies:
11624 react: '*'
11625 react-native: '*'
@@ -16683,7 +16683,7 @@ snapshots:
16683 optionalDependencies:
16684 '@react-native-masked-view/masked-view': 0.3.2(react-native@0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(react@19.3.0)
16685
16686 - '@react-navigation/native-stack@7.21.0(patch_hash=990d575444c4af2ce8218b3b7a8280fe244c03abbdb32b822a2e862f791dbf42)(8cabb04b1defcb22245317e78e4e5f29)':
16686 + '@react-navigation/native-stack@7.21.0(patch_hash=990d575444c4af2ce8218b3b7a8280fe244c03abbdb32b822a2e862f791dbf42)(ce02f236e17a3519f78477aaafd5d0d9)':
16687 dependencies:
16688 '@react-navigation/elements': 2.9.45(83450c2b8dad8f97d4bec4849f35b99e)
16689 '@react-navigation/native': 7.5.1(react-native@0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(react@19.3.0)
@@ -16691,7 +16691,7 @@ snapshots:
16691 react: 19.3.0
16692 react-native: 0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6)
16693 react-native-safe-area-context: 5.11.1(react-native@0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(react@19.3.0)
16694 - react-native-screens: file:apps/mobile/deps/react-native-screens-5.0.0-t3.50.tgz(react-native@0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(react@19.3.0)
16694 + react-native-screens: file:apps/mobile/deps/react-native-screens-5.0.0-t3.55.tgz(react-native@0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(react@19.3.0)
16695 sf-symbols-typescript: 2.2.0
16696 warn-once: 0.1.1
16697 transitivePeerDependencies:
@@ -22540,7 +22540,7 @@ snapshots:
22540 react: 19.3.0
22541 react-native: 0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6)
22542
22543 - react-native-screens@file:apps/mobile/deps/react-native-screens-5.0.0-t3.50.tgz(react-native@0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(react@19.3.0):
22543 + react-native-screens@file:apps/mobile/deps/react-native-screens-5.0.0-t3.55.tgz(react-native@0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(@react-native/metro-config@0.88.1(@babel/core@7.29.7(supports-color@8.1.1))(bufferutil@4.1.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(@types/react@19.3.0)(bufferutil@4.1.0)(react@19.3.0)(supports-color@8.1.1)(utf-8-validate@6.0.6))(react@19.3.0):
22544 dependencies:
22545 react: 19.3.0
22546 react-freeze: 1.0.4(react@19.3.0)