@devries-cameron20 / t3code Mirror · read-only / commits / 8b570d282b
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 22, 04:30 UTC

fix(mobile): delivered messages no longer reappear at the bottom of reopened long threads (#31182)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Alex Southwell committed Nov 5, 2026 at 17:38 UTC 8b570d282b5f50709185fbd26f8e36872ddafdeb
3 files changed +60 -3
apps/mobile/src/state/acknowledged-thread-messages.ts
+16
@@ -1,5 +1,6 @@
1 import * as Option from "effect/Option";
2 import { Atom } from "effect/reactivity";
3 +import { scopedThreadKey } from "../lib/scopedEntities";
4 import { appAtomRegistry } from "./atom-registry";
5 import { threadHasCaughtUpTo } from "@t3tools/client-runtime/state/threads";
6 import type { AcknowledgedThreadMessage, QueuedThreadMessage } from "./thread-outbox-model";
@@ -51,6 +52,21 @@ export function retainAcknowledgedThreadMessage(message: AcknowledgedThreadMessa
52 );
53 }
54
55 +// A bounded window later pages the message out and a remount restarts at sequence 0, so
56 +// rows must leave as soon as their thread has caught up, not at the next write.
57 +export function pruneCaughtUpAcknowledgedThreadMessages(
58 + threadKey: string,
59 + thread: Parameters<typeof threadHasCaughtUpTo>[1],
60 +) {
61 + writeAcknowledgedThreadMessages((current) =>
62 + current.filter(
63 + (entry) =>
64 + scopedThreadKey(entry.environmentId, entry.threadId) !== threadKey ||
65 + !threadHasCaughtUpTo(entry, thread),
66 + ),
67 + );
68 +}
69 +
70 export function forgetAcknowledgedThreadMessage(message: QueuedThreadMessage) {
71 writeAcknowledgedThreadMessages((current) =>
72 current.filter((entry) => entry.messageId !== message.messageId),
apps/mobile/src/state/threadOutboxDelivery.test.ts
+31 -1
@@ -1,4 +1,7 @@
1 -import { acknowledgedThreadMessagesAtom } from "./acknowledged-thread-messages";
1 +import {
2 + acknowledgedThreadMessagesAtom,
3 + pruneCaughtUpAcknowledgedThreadMessages,
4 +} from "./acknowledged-thread-messages";
5 import {
6 CommandId,
7 EnvironmentId,
@@ -144,6 +147,7 @@ vi.mock("./thread-outbox", async () => {
147 });
148
149 import * as Option from "effect/Option";
150 +import { scopedThreadKey } from "../lib/scopedEntities";
151 import { appAtomRegistry } from "./atom-registry";
152 import { pendingThreadCreationOutcomesAtom } from "./pending-thread-creation";
153 import { clearThreadComposerError, threadComposerErrorsAtom } from "./thread-composer-error";
@@ -364,6 +368,32 @@ describe("thread outbox drain delivery cleanup", () => {
368 ]);
369 });
370
371 + it("drops an acknowledged row once the open thread catches up, so a reload cannot resurrect it", async () => {
372 + const message = queuedMessage({ messageId: "paged-out-later", text: "Delivered" });
373 + await harness.manager.enqueue(message);
374 + await completeQueuedMessageDelivery(message, harness.manager.revisionOf(message.messageId), 7);
375 +
376 + pruneCaughtUpAcknowledgedThreadMessages(
377 + scopedThreadKey(message.environmentId, message.threadId),
378 + {
379 + sequence: 6,
380 + messages: [],
381 + },
382 + );
383 + expect(appAtomRegistry.get(acknowledgedThreadMessagesAtom)).toEqual([
384 + { ...message, sequence: 7 },
385 + ]);
386 +
387 + pruneCaughtUpAcknowledgedThreadMessages(
388 + scopedThreadKey(message.environmentId, message.threadId),
389 + {
390 + sequence: 7,
391 + messages: [],
392 + },
393 + );
394 + expect(appAtomRegistry.get(acknowledgedThreadMessagesAtom)).toEqual([]);
395 + });
396 +
397 it("removes an acknowledged outbox item even when the sign-out archive write fails", async () => {
398 const message = queuedMessage({ messageId: "archive-write-failure", text: "Delivered" });
399 await harness.manager.enqueue(message);
apps/mobile/src/state/use-thread-composer-state.ts
+13 -2
@@ -15,7 +15,7 @@ import {
15 deriveThreadRuntime,
16 threadRuntimeHasInterruptibleRun,
17 } from "@t3tools/client-runtime/state/thread-execution";
18 -import { useRef, useState } from "react";
18 +import { useEffect, useRef, useState } from "react";
19
20 import {
21 CommandId,
@@ -50,7 +50,10 @@ import { resolveProviderInteractionMode } from "./legacy-plan-mode";
50 import type { DraftComposerImageAttachment } from "../lib/composerImages";
51 import { scopedThreadKey } from "../lib/scopedEntities";
52 import { buildThreadFeed, createThreadFeedCache } from "../lib/threadActivity";
53 -import { acknowledgedThreadMessagesAtom } from "./acknowledged-thread-messages";
53 +import {
54 + acknowledgedThreadMessagesAtom,
55 + pruneCaughtUpAcknowledgedThreadMessages,
56 +} from "./acknowledged-thread-messages";
57 import {
58 appendPendingThreadMessages,
59 selectPendingAcknowledgedMessages,
@@ -237,6 +240,14 @@ export function useThreadComposerState() {
240 ? EMPTY_THREAD_SEQUENCE_ATOM
241 : environmentThreadDetails.sequenceAtom(selectedThreadDetailRef),
242 );
243 + // oxlint-disable-next-line t3code/no-unreasoned-state-sync -- prunes the app-wide acknowledged atom when the mounted thread catches up
244 + useEffect(() => {
245 + if (selectedThreadKey === null || acknowledgedMessages.length === 0) return;
246 + pruneCaughtUpAcknowledgedThreadMessages(selectedThreadKey, {
247 + sequence: selectedThreadSequence,
248 + messages: selectedThreadMessages,
249 + });
250 + }, [acknowledgedMessages, selectedThreadKey, selectedThreadSequence, selectedThreadMessages]);
251 const checkpointSummaries = useAtomValue(
252 selectedThreadDetailRef === null
253 ? EMPTY_CHECKPOINT_SUMMARIES_ATOM