@devries-cameron20 / t3code Mirror · read-only / commits / 94edd64e74
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 21, 11:00 UTC

perf(server): skip compression for the desktop's local connection (#30832)

Co-authored-by: maria-rcks <maria@kuuro.net>

Lakshmi Tanmay committed Nov 15, 2026 at 14:45 UTC 94edd64e74cbee05735d30f8e917ea38203ae7ec
2 files changed +114 -1
apps/server/src/ws.test.ts
+107 -1
@@ -1,4 +1,8 @@
1 import * as SecretResolver from "@t3tools/secret-provider-core/server/SecretResolver";
2 +import * as NodeHttpServer from "@effect/platform-node/NodeHttpServer";
3 +import { WebSocket } from "@effect/platform-node/NodeWS";
4 +// @effect-diagnostics-next-line nodeBuiltinImport:off -- Bind an isolated WebSocket negotiation fixture.
5 +import * as NodeHttp from "node:http";
6 import * as NodeCrypto from "@effect/platform-node/NodeCrypto";
7 import * as NodeServices from "@effect/platform-node/NodeServices";
8 import { assert, it } from "@effect/vitest";
@@ -8,9 +12,12 @@ import {
12 AuthOrchestrationReadScope,
13 AuthSessionId,
14 AuthSourceControlWriteScope,
15 + ORCHESTRATION_PROTOCOL_VERSION,
16 + ORCHESTRATION_PROTOCOL_QUERY_PARAM,
17 EnvironmentId,
18 EventId,
19 GitManagerError,
20 + VcsProcessSpawnError,
21 MessageId,
22 ProjectId,
23 ThreadId,
@@ -33,6 +40,7 @@ import {
40 type ServerConfigStreamEvent,
41 type ServerProvider,
42 } from "@t3tools/contracts";
43 +import { SOCKET_FRAME_PARTS_QUERY_PARAM } from "@t3tools/shared/socketFrameParts";
44 import * as Deferred from "effect/Deferred";
45 import type { ProviderInstance } from "@t3tools/provider-core/server/driver";
46 import * as DateTime from "effect/DateTime";
@@ -47,7 +55,12 @@ import * as PubSub from "effect/PubSub";
55 import * as Queue from "effect/Queue";
56 import * as Stream from "effect/Stream";
57 import * as TestClock from "effect/testing/TestClock";
50 -import { Headers } from "effect/http";
58 +import { Headers, HttpRouter, HttpServer } from "effect/http";
59 +import * as Context from "effect/Context";
60 +import * as FetchHttpClient from "effect/http/FetchHttpClient";
61 +import * as VcsProcess from "./vcs/VcsProcess.ts";
62 +import * as ProviderInstallationGate from "./provider/ProviderInstallationGate.ts";
63 +import * as Ws from "./ws.ts";
64 import { RpcGroup, RpcMessage, RpcServer } from "effect/rpc";
65 import * as RpcTest from "effect/rpc/RpcTest";
66 import * as SqlClient from "effect/sql/SqlClient";
@@ -891,6 +904,99 @@ const layerConfigSources = Layer.mergeAll(
904 Layer.provideMerge(Layer.mergeAll(NodeServices.layer, NodeCrypto.layer)),
905 );
906
907 +it.live.each([
908 + { subject: "desktop-bootstrap", extensions: "", framed: false },
909 + { subject: "desktop-bootstrap", extensions: "", framed: true },
910 + { subject: "one-time-token", extensions: "permessage-deflate", framed: false },
911 + { subject: "cloud-connect", extensions: "permessage-deflate", framed: false },
912 +])(
913 + "negotiates compression for $subject sessions (framed=$framed)",
914 + ({ subject, extensions, framed }) =>
915 + Effect.gen(function* () {
916 + const services = Layer.mergeAll(
917 + layerUnusedConfigRpcServices,
918 + Layer.mock(ServerBrowser.ServerBrowser)({
919 + profileReporter: Effect.succeed(() => Effect.void),
920 + }),
921 + Layer.mock(EnvironmentAuth.EnvironmentAuth)({
922 + authenticateWebSocketUpgrade: () =>
923 + Effect.succeed({
924 + sessionId: AuthSessionId.make("compression-test"),
925 + subject,
926 + method: "bearer-access-token",
927 + scopes: [],
928 + }),
929 + }),
930 + Layer.mock(SessionStore.SessionStore)({
931 + cookieName: "compression-test",
932 + legacyCookieName: undefined,
933 + markConnected: () => Effect.void,
934 + markDisconnected: () => Effect.void,
935 + awaitInvalidation: () => Effect.never,
936 + }),
937 + Layer.mock(AnalyticsService.AnalyticsService)({ recordOwners: () => Effect.void }),
938 + Layer.mock(ManagedProjectFolders.ManagedProjectFolders)({
939 + namedProjectsRoot: process.cwd(),
940 + }),
941 + Layer.mock(ScratchThreadPromotion.ScratchThreadPromotion)({}),
942 + Layer.mock(ProviderRegistry.ProviderRegistry)({}),
943 + Layer.mock(UsageLimitSources.UsageLimitSources)({}),
944 + Layer.mock(ExternalLauncher.ExternalLauncher)({}),
945 + Layer.mock(RemoteOpenTargets.RemoteOpenTargets)({}),
946 + Layer.mock(DirectEndpoints.DirectEndpoints)({}),
947 + Layer.mock(ServerEnvironment.ServerEnvironment)({}),
948 + Layer.mock(VcsProcess.VcsProcess)({
949 + run: (input) =>
950 + Effect.fail(
951 + new VcsProcessSpawnError({
952 + operation: input.operation,
953 + command: input.command,
954 + cwd: input.cwd,
955 + cause: "No VCS commands in the compression fixture",
956 + }),
957 + ),
958 + }),
959 + ProviderInstallationGate.layer,
960 + FetchHttpClient.layer,
961 + );
962 + const context = yield* Layer.build(
963 + HttpRouter.serve(Ws.layer, { disableListenLog: true }).pipe(
964 + Layer.provideMerge(
965 + NodeHttpServer.layer(NodeHttp.createServer, {
966 + host: "127.0.0.1",
967 + port: 0,
968 + websocket: { perMessageDeflate: true },
969 + }),
970 + ),
971 + Layer.provide(services),
972 + Layer.provide(layerConfigSources),
973 + ),
974 + );
975 + const server = Context.get(context, HttpServer.HttpServer);
976 + const origin = HttpServer.formatAddress(server.address).replace(/^http/, "ws");
977 + const socket = yield* Effect.acquireRelease(
978 + Effect.sync(
979 + () =>
980 + new WebSocket(
981 + `${origin}/ws?${ORCHESTRATION_PROTOCOL_QUERY_PARAM}=${ORCHESTRATION_PROTOCOL_VERSION}${framed ? `&${SOCKET_FRAME_PARTS_QUERY_PARAM}=1` : ""}`,
982 + {
983 + origin: "t3code://app",
984 + },
985 + ),
986 + ),
987 + (socket) => Effect.sync(() => socket.terminate()),
988 + );
989 + yield* Effect.promise(
990 + () =>
991 + new Promise<void>((resolve, reject) => {
992 + socket.once("open", resolve);
993 + socket.once("error", reject);
994 + }),
995 + );
996 + assert.equal(socket.extensions, extensions);
997 + }).pipe(Effect.scoped),
998 +);
999 +
1000 it.effect.each([
1001 "pending",
1002 "cached",
apps/server/src/ws.ts
+7
@@ -2,6 +2,7 @@ import { OrchestrationDispatchCommandError } from "@t3tools/contracts";
2 // @effect-diagnostics-next-line nodeBuiltinImport:off -- A synchronous digest inside the pure provider mapping.
3 import * as NodeCrypto from "node:crypto";
4 import * as Context from "effect/Context";
5 +import * as NodeHttpServerRequest from "@effect/platform-node/NodeHttpServerRequest";
6 import * as SecureRandom from "effect/crypto/SecureRandom";
7 import * as Orchestrator from "./orchestration-v2/Orchestrator.ts";
8 import * as PeerLinkRequests from "./peer/PeerLinkRequests.ts";
@@ -3590,6 +3591,12 @@ export const layer = Layer.unwrap(
3591 failEnvironmentInternal("internal_error", error),
3592 ),
3593 );
3594 + // Desktop bootstrap sessions connect to their own backend, including same-machine WSL.
3595 + if (session.subject === "desktop-bootstrap") {
3596 + delete NodeHttpServerRequest.toIncomingMessage(request).headers[
3597 + "sec-websocket-extensions"
3598 + ];
3599 + }
3600 const clientAnalyticsProps = readClientAnalyticsProps(request);
3601 yield* analytics.recordOwners(readClientOwners(request), "client");
3602 const reportProfiles = yield* serverBrowser.profileReporter;