@devries-cameron20 / t3code Mirror · read-only / commits / a4f4741cff
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 22, 07:00 UTC

fix(gitlab): merge request links keep an HTTP remote's port and scheme (#29170)

Alex Southwell committed Nov 3, 2026 at 01:34 UTC a4f4741cffebd79b3a38fe1151512a6d66ae9690
2 files changed +19 -2
packages/source-control-gitlab/src/shared/definition.test.ts
+16
@@ -61,6 +61,22 @@ describe("GitLab change request URLs", () => {
61 number: 4,
62 }),
63 ).toBe("https://gitlab.com/group/sub/project/-/merge_requests/4");
64 + expect(
65 + definition.changeRequestUrl({
66 + host: "gitlab.internal",
67 + repository: "team/app",
68 + number: 5,
69 + remoteUrl: "http://gitlab.internal:8080/team/app.git",
70 + }),
71 + ).toBe("http://gitlab.internal:8080/team/app/-/merge_requests/5");
72 + expect(
73 + definition.changeRequestUrl({
74 + host: "gitlab.internal",
75 + repository: "team/app",
76 + number: 5,
77 + remoteUrl: "git@gitlab.internal:team/app.git",
78 + }),
79 + ).toBe("https://gitlab.internal/team/app/-/merge_requests/5");
80 expect(
81 definition.changeRequestUrl({
82 host: "gitlab.com",
packages/source-control-gitlab/src/shared/definition.ts
+3 -2
@@ -8,6 +8,7 @@ import {
8 parseChangeRequestPath,
9 parseCommitPath,
10 projectChangeRequestHost,
11 + remoteWebOrigin,
12 } from "@t3tools/source-control-core/shared/definition";
13 import { icon } from "./icon.ts";
14
@@ -38,10 +39,10 @@ export const definition = defineSourceControl({
39 publishHost: () => "gitlab.com",
40 newRepositoryOwner: (account) => ({ owner: account }),
41 defaultCloneTransport: "ssh",
41 - changeRequestUrl: ({ host, repository, number, webUrl }) =>
42 + changeRequestUrl: ({ host, repository, number, remoteUrl, webUrl }) =>
43 webUrl
44 ? changeRequestUrlBelow(webUrl, `-/merge_requests/${number}`)
44 - : `https://${host}/${repository}/-/merge_requests/${number}`,
45 + : `${remoteWebOrigin(host, remoteUrl)}/${repository}/-/merge_requests/${number}`,
46 parseChangeRequestUrl: (url) => parseChangeRequestPath(url, CHANGE_REQUEST_PATH),
47 commitUrl: (input) => buildCommitUrl(input, "-/commit"),
48 parseCommitUrl: (url) => parseCommitPath(url, COMMIT_PATH),