@devries-cameron20 / t3code Mirror · read-only / commits / a88a0adfa1
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 22, 00:45 UTC

fix(web): keep HTML previews anchored when accordions expand (#34003)

Yash Singh committed Nov 10, 2026 at 12:49 UTC a88a0adfa10fefa2fc2eaf8c8a1a469f4d1ef23f
4 files changed +116 -2
apps/web/src/components/chat/MessagesTimeline.browser.test.tsx
+62
@@ -1,3 +1,5 @@
1 +import { injectHtmlRenderBootstrap } from "@t3tools/shared/htmlRender";
2 +import { HtmlRenderDocument } from "../files/BrowserDocumentFrame";
3 import { flushSync } from "react-dom";
4 import { AudioPreview } from "../files/AudioPreview";
5 import { cdp, page } from "vite-plus/test/browser";
@@ -217,6 +219,66 @@ const TASK_ID = ScheduledTaskId.make("task-1");
219 const AUTOMATION_PROMPT = "Triage the inbox\n\nLabel every new issue and close duplicates.";
220
221 describe("MessagesTimeline work rows", () => {
222 + it("keeps a tall HTML preview in place when its last accordion opens at the bottom", async () => {
223 + const props = baseProps();
224 + const html = injectHtmlRenderBootstrap(`<div style="height:1400px">Earlier preview content</div>
225 + <details><summary>More rows</summary><div style="height:900px">More rows</div></details>
226 + <script>addEventListener('message', e => { if(e.data === 'toggle') document.querySelector('details').open = !document.querySelector('details').open; });</script>`);
227 + const src = URL.createObjectURL(new Blob([html], { type: "text/html" }));
228 + using _url = { [Symbol.dispose]: () => URL.revokeObjectURL(src) };
229 + function Preview() {
230 + const [height, setHeight] = useState(1437);
231 + return (
232 + <div style={{ height }}>
233 + <HtmlRenderDocument
234 + src={src}
235 + title="Tall preview"
236 + className="size-full"
237 + onContentHeight={setHeight}
238 + />
239 + </div>
240 + );
241 + }
242 + const container = document.createElement("div");
243 + container.style.cssText = "height:600px;width:900px;display:flex;flex-direction:column";
244 + await using screen = await render(
245 + <MessagesTimeline
246 + {...props}
247 + renderHtmlRender={() => <Preview />}
248 + timelineEntries={[
249 + {
250 + id: "preview",
251 + kind: "html-render",
252 + createdAt: CREATED_AT,
253 + runId: RunId.make("preview-run"),
254 + htmlRender: { attachmentId: "preview", title: "Tall preview", height: 1450 },
255 + },
256 + message("Done", { role: "assistant" }, "preview-done"),
257 + ]}
258 + />,
259 + { container },
260 + );
261 + const viewport = props.listRef.current!.getScrollableNode()!;
262 + const frame = screen.getByTitle("Tall preview").element() as HTMLIFrameElement;
263 + await vi.waitFor(() => {
264 + expect(frame.clientHeight).toBe(1437);
265 + expect(viewport.scrollTop).toBeGreaterThan(0);
266 + expect(viewport.scrollHeight - viewport.clientHeight - viewport.scrollTop).toBeLessThan(2);
267 + });
268 + const top = frame.getBoundingClientRect().top;
269 + frame.focus();
270 + frame.contentWindow!.postMessage("toggle", "*");
271 + await vi.waitFor(() => {
272 + expect(frame.clientHeight).toBe(2337);
273 + expect(frame.getBoundingClientRect().top).toBeCloseTo(top, 0);
274 + });
275 + frame.contentWindow!.postMessage("toggle", "*");
276 + await vi.waitFor(() => {
277 + expect(frame.clientHeight).toBe(1437);
278 + expect(frame.getBoundingClientRect().top).toBeCloseTo(top, 0);
279 + });
280 + });
281 +
282 it("keeps the worked-for heading in place when expanded at the bottom", async () => {
283 const props = baseProps();
284 const runId = RunId.make("completed-run");
apps/web/src/components/chat/MessagesTimeline.tsx
+9 -1
@@ -1119,7 +1119,15 @@ const ConversationTimeline = memo(function ConversationTimeline({
1119 listRef.current = list;
1120 const scrollNode: HTMLElement | null = list?.getScrollableNode() ?? null;
1121 registerTimeline?.(scrollNode);
1122 - const viewport = scrollNode ? attachTimelineViewport(scrollNode) : null;
1122 + const viewport = scrollNode
1123 + ? attachTimelineViewport(scrollNode, (frame) => {
1124 + const rowId = frame.closest<HTMLElement>("[data-timeline-row-id]")?.dataset.timelineRowId;
1125 + if (rowId && list) {
1126 + list.cancelScroll();
1127 + list.anchorVisibleContent({ key: rowId });
1128 + }
1129 + })
1130 + : null;
1131 viewportRef.current = viewport;
1132 const detachViewport = viewport ? onViewportAttach?.(viewport) : undefined;
1133 const stopRememberingRelease = viewport?.onFollowReleased(rememberReleasedPosition);
apps/web/src/components/chat/timelineViewport.browser.test.tsx
+21
@@ -56,6 +56,27 @@ describe("attachTimelineViewport", () => {
56 timeline.scrollTop -= 100;
57 await scroll;
58 expect(sources).toEqual(["scroll"]);
59 + const frame = screen.getByTitle("render").element() as HTMLIFrameElement;
60 + const resize = (height: number, source: Window | null = frame.contentWindow) =>
61 + window.dispatchEvent(
62 + new MessageEvent("message", {
63 + source,
64 + data: { jsonrpc: "2.0", method: "ui/notifications/size-changed", params: { height } },
65 + }),
66 + );
67 + sources.length = 0;
68 + resize(200);
69 + resize(400);
70 + expect(sources).toEqual([]);
71 + frame.focus();
72 + resize(400, window);
73 + resize(400);
74 + expect(sources).toEqual([]);
75 + resize(600);
76 + resize(200);
77 + expect(sources).toEqual(["command", "command"]);
78 viewport.dispose();
79 + resize(800);
80 + expect(sources).toEqual(["command", "command"]);
81 });
82 });
apps/web/src/components/chat/timelineViewport.ts
+24 -1
@@ -1,3 +1,5 @@
1 +import { readHtmlRenderContentHeight } from "@t3tools/shared/htmlRender";
2 +
3 import { isInSideChatPane } from "../../lib/sideChatPane";
4 import { registerCommands } from "../../shortcuts/dispatcher";
5 import {
@@ -67,7 +69,10 @@ const DOWN_KEYS = new Set(["PageDown", "End", "ArrowDown", " "]);
69 * Owns the timeline scroll node's input listeners for as long as the node is
70 * mounted, and turns them into one navigation signal.
71 */
70 -export function attachTimelineViewport(scrollNode: HTMLElement): TimelineViewport & {
72 +export function attachTimelineViewport(
73 + scrollNode: HTMLElement,
74 + onFrameResize?: (frame: HTMLIFrameElement) => void,
75 +): TimelineViewport & {
76 readonly dispose: () => void;
77 } {
78 const listeners = new Set<(navigation: TimelineNavigation) => void>();
@@ -141,6 +146,23 @@ export function attachTimelineViewport(scrollNode: HTMLElement): TimelineViewpor
146 emit({ source: "scroll" });
147 }
148 };
149 + const frameHeights = new WeakMap<HTMLIFrameElement, number>();
150 + const handleFrameResize = (event: MessageEvent) => {
151 + const height = readHtmlRenderContentHeight(event.data);
152 + if (height === undefined) return;
153 + const frame = [...scrollNode.querySelectorAll("iframe")].find(
154 + (frame) => frame.contentWindow === event.source,
155 + );
156 + if (!frame) return;
157 + const previous = frameHeights.get(frame);
158 + frameHeights.set(frame, height);
159 + if (previous !== undefined && previous !== height && document.activeElement === frame) {
160 + emit({ source: "command", releasesFollow: true });
161 + onFrameResize?.(frame);
162 + }
163 + };
164 + // Run before frame listeners resize rows, so an accordion cannot drag the reader to the end.
165 + window.addEventListener("message", handleFrameResize, true);
166 scrollNode.addEventListener("scroll", handleScroll, { passive: true });
167 scrollNode.addEventListener("wheel", handleWheel, { passive: true });
168 scrollNode.addEventListener("touchmove", handleTouchMove, { passive: true });
@@ -170,6 +192,7 @@ export function attachTimelineViewport(scrollNode: HTMLElement): TimelineViewpor
192 return () => followReleasedListeners.delete(listener);
193 },
194 dispose: () => {
195 + window.removeEventListener("message", handleFrameResize, true);
196 listeners.clear();
197 followReleasedListeners.clear();
198 scrollNode.removeEventListener("scroll", handleScroll);