The best way to control Claude Code, Codex and more from any computer or phone
Mirrored from https://github.com/Camo67/t3code.git
Synced Nov 21, 11:00 UTC
fix(mobile): PR activity filter remembers bot and resolved visibility (#37096)
Julius Marminge committed
Nov 14, 2026 at 23:49 UTC
aaf5b9c68e4fc8f820aae6c829791af55bfd27cd
3 files changed
+73
-16
apps/mobile/src/features/pull-requests/PullRequestRouteScreen.tsx
+7
-16
@@ -12,12 +12,9 @@ import { pullRequestTabOffset } from "./pullRequestTabScroll";
12
import { guideFocusedRows, type GuideDiffFocus } from "./guide/guideDiffFocus";
13
import { PullRequestGuideContent } from "./guide/PullRequestGuideScreen";
14
import { useReviewGuidesEnabled } from "./guide/useReviewGuide";
15
-import {
16
- filterPullRequestActivity,
17
- DEFAULT_ACTIVITY_FILTER,
18
- type ActivityFilter,
19
-} from "./pullRequestActivityFilter";
15
+import { filterPullRequestActivity, type ActivityFilter } from "./pullRequestActivityFilter";
16
import { PullRequestActivityFilters } from "./PullRequestActivityFilters";
17
+import { usePullRequestActivityFilter } from "./usePullRequestActivityFilter";
18
import type { LegendListRef } from "@legendapp/list/react-native";
19
import { AnimatedLegendList } from "@legendapp/list/reanimated";
20
import Animated from "react-native-reanimated";
@@ -383,14 +380,8 @@ export function PullRequestRouteScreen({ route }: StaticScreenProps<PullRequestP
380
const shown = (tab: typeof chosenSection) =>
381
!guidesEnabled && tab === "guide" ? "overview" : tab;
382
const section = shown(chosenSection);
386
- const [activityFilter, setActivityFilter] = useState<ActivityFilter>(() => {
387
- const kind = parsePullRequestAnchor(params.navigationUrl)?.kind;
388
- return kind === "timeline"
389
- ? { ...DEFAULT_ACTIVITY_FILTER, bots: true, resolved: true }
390
- : kind === "commits"
391
- ? { ...DEFAULT_ACTIVITY_FILTER, kind: "commits" }
392
- : DEFAULT_ACTIVITY_FILTER;
393
- });
383
+ const activity = usePullRequestActivityFilter(parsePullRequestAnchor(params.navigationUrl)?.kind);
384
+ const activityFilter = activity.filter;
385
const activityContent = usePullRequestActivityRows(params, activityFilter);
386
const scrollOffsets = useRef<Record<string, number>>({});
387
// The offset of the tab last shown, and which tab that was: a tab standing in for a hidden guide
@@ -442,10 +433,10 @@ export function PullRequestRouteScreen({ route }: StaticScreenProps<PullRequestP
433
});
434
} else if (target?.kind === "timeline") {
435
selectSection("activity");
445
- setActivityFilter((filter) => ({ ...filter, kind: "all", bots: true, resolved: true }));
436
+ activity.showTimeline();
437
} else if (target?.kind === "commits") {
438
selectSection("activity");
448
- setActivityFilter((filter) => ({ ...filter, kind: "commits" }));
439
+ activity.showCommits();
440
} else if (target?.kind === "checks") {
441
selectSection("overview");
442
// Checks head Overview, which a reused screen may have scrolled past.
@@ -831,7 +822,7 @@ export function PullRequestRouteScreen({ route }: StaticScreenProps<PullRequestP
822
{tab === "activity" ? (
823
<PullRequestActivityFilters
824
value={activityFilter}
834
- onChange={setActivityFilter}
825
+ onChange={activity.setFilter}
826
hiddenCount={tabContent.hiddenCount}
827
/>
828
) : null}
apps/mobile/src/features/pull-requests/usePullRequestActivityFilter.ts
new
+52
@@ -0,0 +1,52 @@
1
+import { useAtomSet, useAtomValue } from "@effect/atom-react";
2
+import { AsyncResult } from "effect/reactivity";
3
+import { useState } from "react";
4
+import type { PullRequestActivityVisibility } from "../../persistence/mobile-preferences";
5
+import { mobilePreferencesAtom, updateMobilePreferencesAtom } from "../../state/preferences";
6
+import { DEFAULT_ACTIVITY_FILTER, type ActivityFilter } from "./pullRequestActivityFilter";
7
+
8
+const SHOW_EVERYTHING: PullRequestActivityVisibility = { bots: true, resolved: true };
9
+
10
+/**
11
+ * Bot and resolved visibility is a saved preference. A timeline link shows everything for this
12
+ * screen only, until the user picks visibility themselves.
13
+ */
14
+export function usePullRequestActivityFilter(link: string | undefined) {
15
+ const preferences = useAtomValue(mobilePreferencesAtom);
16
+ const savePreferences = useAtomSet(updateMobilePreferencesAtom);
17
+ const [view, setView] = useState(() => ({
18
+ kind: link === "commits" ? ("commits" as const) : DEFAULT_ACTIVITY_FILTER.kind,
19
+ newestFirst: DEFAULT_ACTIVITY_FILTER.newestFirst,
20
+ linkVisibility: link === "timeline" ? SHOW_EVERYTHING : null,
21
+ }));
22
+ const saved = AsyncResult.isSuccess(preferences)
23
+ ? preferences.value.pullRequestActivityVisibility
24
+ : undefined;
25
+ const visibility = view.linkVisibility ?? saved ?? DEFAULT_ACTIVITY_FILTER;
26
+ const filter: ActivityFilter = {
27
+ kind: view.kind,
28
+ newestFirst: view.newestFirst,
29
+ bots: visibility.bots,
30
+ resolved: visibility.resolved,
31
+ };
32
+ const visibilityChanged = (next: ActivityFilter) =>
33
+ next.bots !== filter.bots || next.resolved !== filter.resolved;
34
+ return {
35
+ filter,
36
+ setFilter: (next: ActivityFilter) => {
37
+ if (visibilityChanged(next)) {
38
+ savePreferences({
39
+ pullRequestActivityVisibility: { bots: next.bots, resolved: next.resolved },
40
+ });
41
+ }
42
+ setView((current) => ({
43
+ kind: next.kind,
44
+ newestFirst: next.newestFirst,
45
+ linkVisibility: visibilityChanged(next) ? null : current.linkVisibility,
46
+ }));
47
+ },
48
+ showTimeline: () =>
49
+ setView((current) => ({ ...current, kind: "all", linkVisibility: SHOW_EVERYTHING })),
50
+ showCommits: () => setView((current) => ({ ...current, kind: "commits" })),
51
+ };
52
+}
apps/mobile/src/persistence/mobile-preferences.ts
+14
@@ -79,7 +79,14 @@ const WorkspaceSelections = Schema.Struct({
79
});
80
export type WorkspaceSelections = typeof WorkspaceSelections.Type;
81
82
+const PullRequestActivityVisibility = Schema.Struct({
83
+ bots: Schema.Boolean,
84
+ resolved: Schema.Boolean,
85
+});
86
+export type PullRequestActivityVisibility = typeof PullRequestActivityVisibility.Type;
87
+
88
const isThreadListFilters = Schema.is(ThreadListFilters);
89
+const isPullRequestActivityVisibility = Schema.is(PullRequestActivityVisibility);
90
const isWorkspaceSelections = Schema.is(WorkspaceSelections);
91
const isPullRequestListPreferences = Schema.is(PullRequestListPreferences);
92
const ThreadProject = Schema.Struct({
@@ -92,6 +99,8 @@ export interface Preferences {
99
readonly navigationTabOrder?: readonly string[];
100
readonly hiddenNavigationTabs?: readonly string[];
101
readonly pullRequestHideTestFiles?: boolean;
102
+ /** Which hidden-by-default PR activity is shown: bot comments and resolved or dismissed ones. */
103
+ readonly pullRequestActivityVisibility?: PullRequestActivityVisibility;
104
readonly pullRequestMergeMethod?: PullRequestMergeMethod;
105
readonly liveActivitiesEnabled?: boolean;
106
readonly themeId?: MobileThemeId;
@@ -181,6 +190,7 @@ function sanitizePreferences(parsed: Preferences): Preferences {
190
navigationTabOrder?: readonly string[];
191
hiddenNavigationTabs?: readonly string[];
192
pullRequestHideTestFiles?: boolean;
193
+ pullRequestActivityVisibility?: PullRequestActivityVisibility;
194
pullRequestMergeMethod?: PullRequestMergeMethod;
195
liveActivitiesEnabled?: boolean;
196
themeId?: MobileThemeId;
@@ -233,6 +243,10 @@ function sanitizePreferences(parsed: Preferences): Preferences {
243
preferences.pullRequestHideTestFiles = parsed.pullRequestHideTestFiles;
244
}
245
246
+ if (isPullRequestActivityVisibility(parsed.pullRequestActivityVisibility)) {
247
+ preferences.pullRequestActivityVisibility = parsed.pullRequestActivityVisibility;
248
+ }
249
+
250
if (isPullRequestMergeMethod(parsed.pullRequestMergeMethod)) {
251
preferences.pullRequestMergeMethod = parsed.pullRequestMergeMethod;
252
}