@devries-cameron20 / t3code Mirror · read-only / commits / ab45ce7167
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 21, 11:00 UTC

fix(github): pull request activity says when its comments were cut (#32707)

Co-authored-by: Julius Marminge <julius0216@outlook.com>

Victor committed Nov 15, 2026 at 00:41 UTC ab45ce71673398678004b92552e0e5bc91c10201
5 files changed +39 -2
packages/source-control-github/src/server/GitHubPullRequestApi.test.ts
+29
@@ -930,10 +930,39 @@ layer("GitHubPullRequestApi.layer", (it) => {
930 const activity = yield* cli.getPullRequestActivity(pullRequestInput);
931
932 expect(activity.commits[0]).toMatchObject({ additions: 3, deletions: 1 });
933 + expect(activity.truncated).toBe(false);
934 expect(mockedExecute).toHaveBeenCalledTimes(3);
935 }),
936 );
937
938 + it.effect("reports activity as truncated when comment pages remain past the page cap", () =>
939 + Effect.gen(function* () {
940 + mockedExecute.mockImplementation((call) => {
941 + const head = call.kind === "graphql" && call.variables?.["head"] === true;
942 + return Effect.succeed(
943 + output(
944 + encodeJson({
945 + data: {
946 + repository: {
947 + pullRequest: {
948 + ...(head ? { author: null, commits: { nodes: [] } } : {}),
949 + comments: { nodes: [], pageInfo: { hasNextPage: true, endCursor: "c1" } },
950 + ...(head ? { reviews: { nodes: [], pageInfo: lastPage } } : {}),
951 + },
952 + },
953 + },
954 + }),
955 + ),
956 + );
957 + });
958 + const cli = yield* GitHubPullRequestApi.GitHubPullRequestApi;
959 +
960 + const activity = yield* cli.getPullRequestActivity(pullRequestInput);
961 +
962 + expect(activity.truncated).toBe(true);
963 + }),
964 + );
965 +
966 it.effect("loads the complete hover card with one GraphQL request", () =>
967 Effect.gen(function* () {
968 mockedExecute.mockReturnValueOnce(
packages/source-control-github/src/server/GitHubPullRequestApi.ts
+1
@@ -2236,6 +2236,7 @@ export const make = Effect.gen(function* () {
2236 left.createdAt.localeCompare(right.createdAt),
2237 ),
2238 commits: commits.map((commit) => ({ ...commit, ...commitStats.get(commit.oid) })),
2239 + truncated: commentsAfter !== null || reviewsAfter !== null,
2240 } satisfies GitHubPullRequestActivity;
2241 },
2242 ),
packages/source-control-github/src/server/GitHubPullRequestProvider.test.ts
+7 -1
@@ -737,6 +737,7 @@ describe("getChangeRequest commits", () => {
737 authors: [],
738 },
739 ],
740 + truncated: false,
741 }),
742 listReviewThreadComments: () => Effect.succeed({ ...baseThreadComments, commits }),
743 });
@@ -817,7 +818,12 @@ describe("getChangeRequestActivity", () => {
818 Layer.mock(GitHubPullRequestApi.GitHubPullRequestApi)({
819 revalidateChecks: (_input, read) => read,
820 getPullRequestActivity: () =>
820 - Effect.succeed({ author: null, comments: [dismissedReview(body)], commits: [] }),
821 + Effect.succeed({
822 + author: null,
823 + comments: [dismissedReview(body)],
824 + commits: [],
825 + truncated: false,
826 + }),
827 listReviewThreadComments: () => Effect.succeed(threadComments),
828 });
829 const readActivity = Effect.gen(function* () {
packages/source-control-github/src/server/GitHubPullRequestProvider.ts
+1 -1
@@ -622,7 +622,7 @@ export const make = Effect.gen(function* () {
622 }))
623 .toSorted((left, right) => left.createdAt.localeCompare(right.createdAt)),
624 commentCount: pullRequest.comments.length + reviewThreads.commentCount,
625 - commentsTruncated: reviewThreads.truncated,
625 + commentsTruncated: pullRequest.truncated || reviewThreads.truncated,
626 reviewThreadsTruncated: reviewThreads.reviewThreadsTruncated,
627 reviewThreads: reviewThreads.reviewThreads.map((thread) => ({
628 ...thread,
packages/source-control-github/src/server/gitHubPullRequestJson.ts
+1
@@ -389,6 +389,7 @@ export interface GitHubPullRequestActivity {
389 readonly author: PullRequestActor | null;
390 readonly comments: ReadonlyArray<PullRequestComment>;
391 readonly commits: ReadonlyArray<PullRequestCommit>;
392 + readonly truncated: boolean;
393 }
394
395 /** GitHub returns endCursor even on the last page; hasNextPage is authoritative. */