@devries-cameron20 / t3code Mirror · read-only / commits / afb4f91a7d
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 21, 23:30 UTC

fix(provider-core): a model reply of "title" no longer replaces the thread title (#25743)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Julius Marminge committed Nov 11, 2026 at 02:56 UTC afb4f91a7d3ec7707293a07d54e300b9639f2b5e
3 files changed +44 -3
packages/provider-core/src/server/textGenerationOperations.test.ts new
+28
@@ -0,0 +1,28 @@
1 +import { assert, it } from "@effect/vitest";
2 +import { ProviderInstanceId, TextGenerationError } from "@t3tools/contracts";
3 +import * as Effect from "effect/Effect";
4 +
5 +import { decodeJsonReply, fromRunner } from "./textGenerationOperations.ts";
6 +
7 +// regression: #23726 a reply that echoes the schema key replaced the seed title with "title"
8 +it.effect("fails a thread title reply that is only the schema key", () =>
9 + Effect.gen(function* () {
10 + const textGeneration = fromRunner("Stub", (request) =>
11 + decodeJsonReply(request, "Stub", '{"title":"title","needsRefinement":false}'),
12 + );
13 +
14 + const outcome = yield* textGeneration
15 + .generateThreadTitle({
16 + cwd: process.cwd(),
17 + message: "$implement Issue #140",
18 + modelSelection: {
19 + instanceId: ProviderInstanceId.make("pi"),
20 + model: "anthropic/claude-haiku-4-5",
21 + },
22 + })
23 + .pipe(Effect.match({ onFailure: (error) => error, onSuccess: (result) => result }));
24 +
25 + assert.instanceOf(outcome, TextGenerationError);
26 + assert.strictEqual(outcome.operation, "generateThreadTitle");
27 + }),
28 +);
packages/provider-core/src/server/textGenerationOperations.ts
+14 -1
@@ -71,6 +71,19 @@ export const decodeJsonReply = <S extends Schema.Top>(
71 );
72 };
73
74 +export const generatedThreadTitle = (raw: string) => {
75 + const title = sanitizeThreadTitle(raw);
76 + // Some models echo the output schema's key instead of a title.
77 + return title.toLowerCase() === "title"
78 + ? Effect.fail(
79 + new TextGenerationError({
80 + operation: "generateThreadTitle",
81 + detail: 'The model returned the placeholder title "title".',
82 + }),
83 + )
84 + : Effect.succeed(title);
85 +};
86 +
87 export function fromRunner(name: string, run: Runner): ProviderTextGeneration {
88 const generateCommitMessage: ProviderTextGeneration["generateCommitMessage"] = Effect.fn(
89 `${name}.generateCommitMessage`,
@@ -152,7 +165,7 @@ export function fromRunner(name: string, run: Runner): ProviderTextGeneration {
165 }),
166 });
167 return {
155 - title: sanitizeThreadTitle(generated.title),
168 + title: yield* generatedThreadTitle(generated.title),
169 ...(generated.needsRefinement ? { needsRefinement: true } : {}),
170 };
171 });
packages/provider-muse/src/server/textGeneration.ts
+2 -2
@@ -23,6 +23,7 @@ import {
23 import { museModelCapabilities, resolveMuseReasoningEffort } from "./modelCatalog.ts";
24 import type { ProviderTextGeneration } from "@t3tools/provider-core/server/textGeneration";
25 import {
26 + generatedThreadTitle,
27 investigationUnsupported,
28 TranscriptionPostProcessingOutput,
29 } from "@t3tools/provider-core/server/textGenerationOperations";
@@ -35,7 +36,6 @@ import {
36 import {
37 sanitizeCommitSubject,
38 sanitizePrTitle,
38 - sanitizeThreadTitle,
39 toJsonSchemaObject,
40 } from "@t3tools/provider-core/server/textGenerationUtils";
41
@@ -348,7 +348,7 @@ export const makeMuseTextGeneration = Effect.fn("makeMuseTextGeneration")(functi
348 ...buildThreadTitlePrompt(input),
349 modelSelection: input.modelSelection,
350 });
351 - return { title: sanitizeThreadTitle(generated.title) };
351 + return { title: yield* generatedThreadTitle(generated.title) };
352 });
353 const generateTranscriptionPostProcessing: ProviderTextGeneration["generateTranscriptionPostProcessing"] =
354 Effect.fn("MuseTextGeneration.generateTranscriptionPostProcessing")(function* (input) {