The best way to control Claude Code, Codex and more from any computer or phone
Mirrored from https://github.com/Camo67/t3code.git
Synced Nov 22, 17:00 UTC
perf(source-control): pull request previews read only the pull request (#22583)
maria committed
Oct 25, 2026 at 20:38 UTC
b3b2c55369ec4bb1842bd2fcdac0744a8c787b6b
11 files changed
+151
-31
apps/web/src/components/pullRequest/PullRequestLinkPreview.tsx
+17
-17
@@ -49,9 +49,9 @@ export function PullRequestLinkPreview({
49
const [open, setOpen] = useState(false);
50
const previewActionsRef = useRef<PreviewCardPrimitive.Root.Actions | null>(null);
51
const [resolvingClick, setResolvingClick] = useState(false);
52
- const detailQuery = useEnvironmentQuery(
52
+ const previewQuery = useEnvironmentQuery(
53
open
54
- ? pullRequestEnvironment.detail({
54
+ ? pullRequestEnvironment.previewCard({
55
environmentId: target.environmentId,
56
input: target.input,
57
})
@@ -84,19 +84,19 @@ export function PullRequestLinkPreview({
84
},
85
})
86
: link;
87
- const detail = detailQuery.data;
88
- const showCard = detail !== null || (detailQuery.error !== null && fallback !== undefined);
89
- const showUrlTooltip = open && detailQuery.error !== null && !showCard;
87
+ const preview = previewQuery.data;
88
+ const showCard = preview !== null || (previewQuery.error !== null && fallback !== undefined);
89
+ const showUrlTooltip = open && previewQuery.error !== null && !showCard;
90
const state =
91
- detail === null
91
+ preview === null
92
? null
93
- : resolvePullRequestState({ state: detail.state, isDraft: detail.isDraft });
93
+ : resolvePullRequestState({ state: preview.state, isDraft: preview.isDraft });
94
const authorLabel =
95
- detail?.author === null
95
+ preview?.author === null
96
? "ghost"
97
- : detail?.author.name && detail.author.name !== detail.author.login
98
- ? `${detail.author.name} (@${detail.author.login})`
99
- : (detail?.author.login ?? null);
97
+ : preview?.author.name && preview.author.name !== preview.author.login
98
+ ? `${preview.author.name} (@${preview.author.login})`
99
+ : (preview?.author.login ?? null);
100
101
return (
102
<PreviewCard open={open} onOpenChange={setOpen} actionsRef={previewActionsRef}>
@@ -116,13 +116,13 @@ export function PullRequestLinkPreview({
116
{showCard ? (
117
<PreviewCardPopup align="center" className="w-80 max-w-[calc(100vw-2rem)]">
118
<div className="p-3">
119
- {detail === null ? (
119
+ {preview === null ? (
120
fallback
121
) : (
122
<div className="min-w-0">
123
<div className="flex min-w-0 items-center gap-1.5 text-2xs text-muted-foreground">
124
- <span className="min-w-0 truncate">{detail.repository}</span>
125
- <span className="shrink-0">#{detail.number}</span>
124
+ <span className="min-w-0 truncate">{preview.repository}</span>
125
+ <span className="shrink-0">#{preview.number}</span>
126
<span aria-hidden>·</span>
127
{state === null ? null : (
128
<span className="inline-flex shrink-0 items-center gap-1">
@@ -132,14 +132,14 @@ export function PullRequestLinkPreview({
132
)}
133
</div>
134
<p className="mt-1 text-sm font-medium leading-snug text-foreground text-pretty">
135
- {detail.title}
135
+ {preview.title}
136
</p>
137
<div className="mt-2 flex min-w-0 items-center gap-1.5 text-xs text-muted-foreground">
138
- <PullRequestActorAvatar actor={detail.author} className="size-4" />
138
+ <PullRequestActorAvatar actor={preview.author} className="size-4" />
139
<span className="min-w-0 truncate">{authorLabel}</span>
140
<span aria-hidden>·</span>
141
<span className="shrink-0">
142
- opened <RelativeTime timestamp={detail.createdAt} />
142
+ opened <RelativeTime timestamp={preview.createdAt} />
143
</span>
144
</div>
145
</div>
packages/client-runtime/src/state/pullRequests.ts
+18
-1
@@ -210,6 +210,18 @@ export function createPullRequestEnvironmentAtoms<R, E>(
210
refreshTrigger: ({ environmentId }) => refreshes({ environmentId, input: {} }),
211
}),
212
);
213
+ // Hover cards read their own atoms, so a pending or failed hover read never decides where a
214
+ // click on the same link goes.
215
+ const previewCard = writableQueryFamily(
216
+ createEnvironmentRpcQueryAtomFamily(runtime, {
217
+ label: "environment-data:pull-requests:preview-card",
218
+ persistence: persistQuery(PullRequestPreview),
219
+ tag: WS_METHODS.pullRequestsPreview,
220
+ execute: (input) => routedRequest(WS_METHODS.pullRequestsPreview, input),
221
+ staleTimeMs: 60_000,
222
+ refreshTrigger: ({ environmentId }) => refreshes({ environmentId, input: {} }),
223
+ }),
224
+ );
225
const labelCandidates = writableQueryFamily(
226
createEnvironmentRpcQueryAtomFamily(runtime, {
227
label: "environment-data:pull-requests:label-candidates",
@@ -337,6 +349,7 @@ export function createPullRequestEnvironmentAtoms<R, E>(
349
}),
350
detail,
351
preview,
352
+ previewCard,
353
checks: normalizePullRequestQuery(
354
createEnvironmentRpcQueryAtomFamily(runtime, {
355
label: "environment-data:pull-requests:checks",
@@ -423,7 +436,10 @@ export function createPullRequestEnvironmentAtoms<R, E>(
436
// every preceding action, and preparing outside the lane could reorder the clicks.
437
execute: runAction,
438
onSuccess: ({ environmentId, input }, registry) =>
426
- Effect.sync(() => registry.refresh(preview({ environmentId, input }))),
439
+ Effect.sync(() => {
440
+ registry.refresh(preview({ environmentId, input }));
441
+ registry.refresh(previewCard({ environmentId, input }));
442
+ }),
443
scheduler: commandScheduler,
444
concurrency: serialPerEnvironment,
445
}),
@@ -621,6 +637,7 @@ export function createPullRequestEnvironmentAtoms<R, E>(
637
Effect.sync(() => {
638
if (input.reference !== undefined) {
639
registry.refresh(preview({ environmentId, input: input.reference }));
640
+ registry.refresh(previewCard({ environmentId, input: input.reference }));
641
}
642
}),
643
scheduler: commandScheduler,
packages/source-control-azure-devops/src/server/AzureDevOpsPullRequestProvider.ts
+14
@@ -274,6 +274,20 @@ export const make = Effect.gen(function* () {
274
})),
275
),
276
277
+ getChangeRequestPreview: (input) =>
278
+ cli.getPullRequest({ cwd: input.cwd, number: input.number }).pipe(
279
+ Effect.mapError(fail("getChangeRequestPreview")),
280
+ Effect.map((pullRequest) => ({
281
+ number: pullRequest.number,
282
+ title: pullRequest.title,
283
+ url: pullRequest.url,
284
+ author: pullRequest.author,
285
+ state: pullRequest.state,
286
+ isDraft: pullRequest.isDraft,
287
+ createdAt: pullRequest.createdAt,
288
+ })),
289
+ ),
290
+
291
getChangeRequestSummary: (input) =>
292
cli.getPullRequest({ cwd: input.cwd, number: input.number }).pipe(
293
Effect.mapError(fail("getChangeRequestSummary")),
packages/source-control-bitbucket/src/server/BitbucketPullRequestProvider.ts
+14
@@ -182,6 +182,20 @@ export const make = Effect.gen(function* () {
182
Effect.mapError(fail("getChangeRequestChecks")),
183
),
184
185
+ getChangeRequestPreview: (input) =>
186
+ api.getPullRequest({ repository: input.repository, number: input.number }).pipe(
187
+ Effect.mapError(fail("getChangeRequestPreview")),
188
+ Effect.map((pullRequest) => ({
189
+ number: pullRequest.number,
190
+ title: pullRequest.title,
191
+ url: pullRequest.url,
192
+ author: pullRequest.author,
193
+ state: pullRequest.state,
194
+ isDraft: pullRequest.isDraft,
195
+ createdAt: pullRequest.createdAt,
196
+ })),
197
+ ),
198
+
199
getChangeRequest: (input) => {
200
const target = { repository: input.repository, number: input.number };
201
return Effect.all(
packages/source-control-forgejo/src/server/ForgejoPullRequestProvider.ts
+1
@@ -324,6 +324,7 @@ export const make = Effect.gen(function* () {
324
return { items, truncated: more, continues: true, cursorAdvance: consumed };
325
},
326
),
327
+ getChangeRequestPreview: (input) => getPull(input).pipe(Effect.map(forgejoChangeRequest)),
328
getChangeRequestSummary: (input) => getPull(input).pipe(Effect.map(forgejoChangeRequest)),
329
getChangeRequestChecks: Effect.fn("ForgejoPullRequestProvider.getChangeRequestChecks")(
330
function* (input) {
packages/source-control-forgejo/src/server/ForgejoSourceControlProvider.test.ts
+13
@@ -434,11 +434,23 @@ it.effect.each([
434
merged_at: null,
435
labels: [],
436
};
437
+ const requests: string[] = [];
438
return Effect.gen(function* () {
439
const provider = yield* ForgejoPullRequestProvider.make;
440
const readSummary = provider.getChangeRequestSummary;
441
if (readSummary === undefined) return yield* Effect.die("summary read missing");
442
+ const readPreview = provider.getChangeRequestPreview;
443
+ if (readPreview === undefined) return yield* Effect.die("preview read missing");
444
const input = { cwd: "/repo", repository: "maria/project", host: "forgejo.test", number: 42 };
445
+ const preview = yield* readPreview(input);
446
+ assert.deepStrictEqual(requests, ["repos/maria/project/pulls/42"]);
447
+ assert.strictEqual(preview.isDraft, isDraft);
448
+ assert.strictEqual(preview.title, title);
449
+ assert.strictEqual(preview.state, "open");
450
+ assert.strictEqual(preview.number, 42);
451
+ assert.strictEqual(preview.url, pr.html_url);
452
+ assert.deepStrictEqual(preview.author, { login: "maria", name: null, avatarUrl: null });
453
+ assert.strictEqual(preview.createdAt, "2026-09-16T00:00:00.000Z");
454
const list = yield* provider.listChangeRequests({
455
...input,
456
state: "open",
@@ -458,6 +470,7 @@ it.effect.each([
470
Effect.provide(
471
Layer.mock(ForgejoCli.ForgejoCli)({
472
api: (input) => {
473
+ requests.push(input.path);
474
const [path, query] = input.path.split("?");
475
let response: unknown;
476
switch (path) {
packages/source-control-gitcafe/src/server/GitCafePullRequestProvider.test.ts
+20
-1
@@ -456,12 +456,31 @@ describe("GitCafePullRequestProvider", () => {
456
);
457
return Effect.gen(function* () {
458
const provider = yield* GitCafePullRequestProvider.make;
459
- const summary = yield* provider.getChangeRequestSummary!({
459
+ const input = {
460
...target,
461
host: "staging.git.cafe",
462
+ };
463
+ const preview = yield* provider.getChangeRequestPreview!(input);
464
+ assert.deepInclude(preview, {
465
+ number: 7,
466
+ title: "Change",
467
+ url: "https://staging.git.cafe/owner/repo/pulls/7",
468
+ author: { login: "alice", name: null, avatarUrl: "https://staging.git.cafe/avatars/one" },
469
+ state: "open",
470
+ isDraft: false,
471
+ createdAt: timestamp,
472
});
473
+ const summary = yield* provider.getChangeRequestSummary!(input);
474
assert.strictEqual(summary.url, "https://staging.git.cafe/owner/repo/pulls/7");
475
assert.isTrue(server.sent.every((request) => request.host === "staging.git.cafe"));
476
+ assert.deepStrictEqual(
477
+ server.sent.map((request) => `${request.method} ${request.path}`),
478
+ [
479
+ "GET /repos/owner/repo/pulls/7",
480
+ "GET /repos/owner/repo/pulls/7",
481
+ "GET /repos/owner/repo/pulls/7/changes",
482
+ ],
483
+ );
484
}).pipe(Effect.provide(server.layer));
485
});
486
packages/source-control-gitcafe/src/server/GitCafePullRequestProvider.ts
+4
@@ -860,6 +860,10 @@ export const make = Effect.gen(function* () {
860
};
861
},
862
),
863
+ getChangeRequestPreview: (input) =>
864
+ readPull("getChangeRequestPreview", input).pipe(
865
+ Effect.map((pull) => Json.toChangeRequest(pull, input)),
866
+ ),
867
getChangeRequestSummary: Effect.fn("GitCafePullRequestProvider.getChangeRequestSummary")(
868
function* (input) {
869
const pull = yield* readPull("getChangeRequestSummary", input);
packages/source-control-github/src/server/gitHubConditionalChecks.ts
+23
-11
@@ -23,6 +23,8 @@ const HeadSchema = Schema.Struct({
23
});
24
const decodeHead = Schema.decodeUnknownEffect(Schema.fromJsonString(HeadSchema));
25
26
+class ChecksUnavailable extends Schema.TaggedError<ChecksUnavailable>()("ChecksUnavailable", {}) {}
27
+
28
const WorkflowRunSchema = Schema.Struct({
29
id: Schema.Int,
30
name: Schema.optional(Schema.NullOr(Schema.String)),
@@ -106,7 +108,7 @@ export const makeChecksRevalidator = Effect.gen(function* () {
108
}),
109
GitHubApiResponseError: (error) =>
110
Effect.sync(() => {
109
- entry.supported = !UNSUPPORTED_STATUSES.has(error.status);
111
+ entry.supported &&= !UNSUPPORTED_STATUSES.has(error.status);
112
return null;
113
}),
114
}),
@@ -149,16 +151,26 @@ export const makeChecksRevalidator = Effect.gen(function* () {
151
...(runsEndpoint === null ? [] : [runsEndpoint]),
152
];
153
const runPages: Array<string> = [];
152
- for (const endpoint of endpoints) {
153
- for (let page = 1; ; page++) {
154
- if (page > 100) return yield* fail(200);
155
- const paged = `${endpoint}${endpoint.includes("?") ? "&" : "?"}per_page=100&page=${page}`;
156
- const next = yield* get(paged);
157
- if (next === null) return yield* read;
158
- if (endpoint === runsEndpoint) runPages.push(paged);
159
- if (!next) break;
160
- }
161
- }
154
+ // Each endpoint has its own cursor; only pages within one endpoint depend on each other.
155
+ // An unavailable endpoint interrupts the others so the fallback read starts at once.
156
+ const available = yield* Effect.forEach(
157
+ endpoints,
158
+ Effect.fn("gitHubConditionalChecks.revalidateEndpoint")(function* (endpoint) {
159
+ for (let page = 1; ; page++) {
160
+ if (page > 100) return yield* fail(200);
161
+ const paged = `${endpoint}${endpoint.includes("?") ? "&" : "?"}per_page=100&page=${page}`;
162
+ const next = yield* get(paged);
163
+ if (next === null) return yield* new ChecksUnavailable();
164
+ if (endpoint === runsEndpoint) runPages.push(paged);
165
+ if (!next) return;
166
+ }
167
+ }),
168
+ { concurrency: 3, discard: true },
169
+ ).pipe(
170
+ Effect.as(true),
171
+ Effect.catchTags({ ChecksUnavailable: () => Effect.succeed(false) }),
172
+ );
173
+ if (!available) return yield* read;
174
const now = yield* Clock.currentTimeMillis;
175
if (entry.value !== null && now - entry.readAt < 5 * 60_000) return entry.value;
176
const pages = runPages.map((endpoint) =>
packages/source-control-gitlab/src/server/GitLabPullRequestProvider.test.ts
+20
-1
@@ -1,4 +1,4 @@
1
-import { describe, expect, it } from "@effect/vitest";
1
+import { assert, describe, expect, it } from "@effect/vitest";
2
import * as Effect from "effect/Effect";
3
import * as Layer from "effect/Layer";
4
@@ -65,6 +65,25 @@ describe("getChangeRequest base freshness", () => {
65
reviewerIds: [],
66
};
67
68
+ it.effect.each(["getChangeRequestPreview", "getChangeRequestSummary"] as const)(
69
+ "%s preserves merge request fields without fetching project settings",
70
+ (operation) =>
71
+ Effect.gen(function* () {
72
+ const provider = yield* make.pipe(
73
+ Effect.provide(
74
+ Layer.mock(GitLabPullRequestCli.GitLabPullRequestCli)({
75
+ getMergeRequestDetail: () => Effect.succeed(detail),
76
+ }),
77
+ ),
78
+ );
79
+ const read = provider[operation];
80
+ assert.isDefined(read);
81
+ expect(
82
+ yield* read({ cwd: "/w", repository: "acme/web", host: "gitlab.com", number: 7 }),
83
+ ).toEqual(detail);
84
+ }),
85
+ );
86
+
87
const readWith = (divergence: { readonly divergedCommits?: number }) =>
88
Effect.gen(function* () {
89
const provider = yield* make;
packages/source-control-gitlab/src/server/GitLabPullRequestProvider.ts
+7
@@ -143,6 +143,13 @@ export const make = Effect.gen(function* () {
143
Effect.mapError(fail("getChangeRequestChecks")),
144
),
145
146
+ // Merge settings only affect the detail panel's actions.
147
+ getChangeRequestPreview: (input) =>
148
+ cli.getMergeRequestDetail(input).pipe(Effect.mapError(fail("getChangeRequestPreview"))),
149
+
150
+ getChangeRequestSummary: (input) =>
151
+ cli.getMergeRequestDetail(input).pipe(Effect.mapError(fail("getChangeRequestSummary"))),
152
+
153
getChangeRequest: (input) =>
154
Effect.all(
155
[