The best way to control Claude Code, Codex and more from any computer or phone
Mirrored from https://github.com/Camo67/t3code.git
Synced Nov 22, 12:00 UTC
fix(web): PDF previews keep their page when the agent responds (#23732)
Co-authored-by: maria-rcks <maria@kuuro.net>
Semyon Fox committed
Oct 30, 2026 at 20:57 UTC
be43da4c0dfc3661e1940d241a111ada078ae4eb
2 files changed
+84
-8
apps/web/src/components/files/AttachmentFilePreview.browser.test.tsx
+66
@@ -2345,6 +2345,72 @@ it("toggles a Mermaid attachment between diagram and source through the lazy pre
2345
expect(screen.container.querySelector('[role="alert"]')).toBeNull();
2346
});
2347
2348
+it("keeps a workspace PDF open across URL renewals and reloads it when the file changes", async () => {
2349
+ const { WorkspaceBrowserPreview } = await import("./FilePreviewPanel");
2350
+ using _native = vi.spyOn(navigator, "pdfViewerEnabled", "get").mockReturnValue(true);
2351
+ const original = URL.createObjectURL(new Blob(["%PDF-1.4"], { type: "application/pdf" }));
2352
+ const edited = URL.createObjectURL(new Blob(["%PDF-1.4 edited"], { type: "application/pdf" }));
2353
+ const preview = (mutation: string) => (
2354
+ <WorkspaceBrowserPreview
2355
+ environmentId={EnvironmentId.make("test")}
2356
+ threadRef={{ environmentId: EnvironmentId.make("test"), threadId: ThreadId.make("test") }}
2357
+ draft={false}
2358
+ workspaceRoot="/repo"
2359
+ absolutePath="/repo/planning.pdf"
2360
+ title="Planning PDF"
2361
+ workspaceMutationId={mutation}
2362
+ />
2363
+ );
2364
+ assetUrlState.mockReturnValue({
2365
+ _tag: "Success",
2366
+ url: `${original}#initial`,
2367
+ expiresAt: 0,
2368
+ fileRevision: "one",
2369
+ });
2370
+ try {
2371
+ await using screen = await render(preview("first"));
2372
+ const opened = screen.container.querySelector("iframe");
2373
+ expect(opened?.src.startsWith(original)).toBe(true);
2374
+
2375
+ // An agent command renews the signed URL but leaves the file alone.
2376
+ assetUrlState.mockReturnValue({
2377
+ _tag: "Success",
2378
+ url: `${original}#renewed`,
2379
+ expiresAt: 0,
2380
+ fileRevision: "one",
2381
+ });
2382
+ await screen.rerender(preview("second"));
2383
+ expect(assetUrlState).toHaveBeenLastCalledWith(expect.anything(), expect.anything(), "second");
2384
+ expect(screen.container.querySelector("iframe")).toBe(opened);
2385
+
2386
+ assetUrlState.mockReturnValue({
2387
+ _tag: "Success",
2388
+ url: edited,
2389
+ expiresAt: 0,
2390
+ fileRevision: "two",
2391
+ });
2392
+ await screen.rerender(preview("third"));
2393
+ const reloaded = screen.container.querySelector("iframe");
2394
+ expect(reloaded).not.toBe(opened);
2395
+ expect(reloaded?.src.startsWith(edited)).toBe(true);
2396
+
2397
+ // Servers without revisions hold the preview back until a fresh grant arrives.
2398
+ assetUrlState.mockReturnValue({
2399
+ _tag: "Success",
2400
+ url: `${edited}#stale`,
2401
+ expiresAt: 0,
2402
+ waiting: true,
2403
+ });
2404
+ await screen.rerender(preview("fourth"));
2405
+ expect(screen.container.querySelector("iframe")).toBeNull();
2406
+ assetUrlState.mockReturnValue({ _tag: "Success", url: original, expiresAt: 0 });
2407
+ await screen.rerender(preview("fourth"));
2408
+ expect(screen.container.querySelector("iframe")?.src.startsWith(original)).toBe(true);
2409
+ } finally {
2410
+ URL.revokeObjectURL(original);
2411
+ URL.revokeObjectURL(edited);
2412
+ }
2413
+});
2414
it("unwraps one text attachment without turning off the word wrap setting", async () => {
2415
const file = new Blob(["a long line"], { type: "text/plain" });
2416
await using screen = await render(
apps/web/src/components/files/FilePreviewPanel.tsx
+18
-8
@@ -222,7 +222,7 @@ function WorkspaceImagePreview(props: {
222
);
223
}
224
225
-function WorkspaceBrowserPreview(props: {
225
+export function WorkspaceBrowserPreview(props: {
226
readonly environmentId: EnvironmentId;
227
readonly threadRef: ScopedThreadRef;
228
readonly draft: boolean;
@@ -231,18 +231,25 @@ function WorkspaceBrowserPreview(props: {
231
readonly title: string;
232
readonly workspaceMutationId: string | null;
233
}) {
234
+ const pdf = isPdfPreviewFile(props.absolutePath);
235
const resource = workspaceAssetResource({
235
- kind: "workspace-file",
236
+ kind: pdf ? "media-file" : "workspace-file",
237
threadRef: props.threadRef,
238
draft: props.draft,
239
workspaceRoot: props.workspaceRoot,
240
absolutePath: props.absolutePath,
241
});
241
- const assetUrl = useAssetUrlState(props.environmentId, resource);
242
+ const assetUrl = useAssetUrlState(
243
+ props.environmentId,
244
+ resource,
245
+ pdf ? props.workspaceMutationId : undefined,
246
+ );
247
+ const fileRevision = pdf && assetUrl._tag === "Success" ? assetUrl.fileRevision : undefined;
248
+ const revision = fileRevision ?? props.workspaceMutationId;
249
const revisionSuffix =
243
- props.workspaceMutationId === null
250
+ revision === null
251
? ""
245
- : `${assetUrl._tag === "Success" && assetUrl.url.includes("?") ? "&" : "?"}workspace-revision=${encodeURIComponent(props.workspaceMutationId)}`;
252
+ : `${assetUrl._tag === "Success" && assetUrl.url.includes("?") ? "&" : "?"}${fileRevision !== undefined ? "file" : "workspace"}-revision=${encodeURIComponent(revision)}`;
253
254
if (assetUrl._tag === "Failure") {
255
return (
@@ -251,7 +258,10 @@ function WorkspaceBrowserPreview(props: {
258
</div>
259
);
260
}
254
- if (assetUrl._tag !== "Success") {
261
+ if (
262
+ assetUrl._tag !== "Success" ||
263
+ (pdf && assetUrl.fileRevision === undefined && assetUrl.waiting)
264
+ ) {
265
return (
266
<div className="flex min-h-0 flex-1 items-center justify-center text-muted-foreground">
267
<Spinner size="lg" />
@@ -261,9 +271,9 @@ function WorkspaceBrowserPreview(props: {
271
return (
272
<BrowserDocumentFrame
273
src={`${assetUrl.url}${revisionSuffix}`}
264
- documentKey={`${props.environmentId}:${resource._tag}:${props.threadRef.threadId}:${props.absolutePath}:${props.workspaceMutationId}`}
274
+ documentKey={`${props.environmentId}:${resource._tag}:${props.threadRef.threadId}:${props.absolutePath}:${revision}`}
275
title={props.title}
266
- pdf={isPdfPreviewFile(props.absolutePath)}
276
+ pdf={pdf}
277
/>
278
);
279
}