@devries-cameron20 / t3code Mirror · read-only / commits / be5f805964
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 21, 17:15 UTC

fix(web): new desktop browser tabs open at the default zoom and appearance (#34943)

Julius Marminge committed Nov 13, 2026 at 11:05 UTC be5f805964858307864b599f63b215e62d36b3d7
9 files changed +76 -5
apps/server/src/preview/Manager.test.ts
+12
@@ -79,6 +79,18 @@ it.layer(layer)("PreviewManager", (it) => {
79 }),
80 );
81
82 + it.effect("opens a server tab with the requested zoom and appearance", () =>
83 + Effect.gen(function* () {
84 + const threadId = freshThreadId();
85 + const manager = yield* PreviewManager.PreviewManager;
86 + const rendering = { zoomFactor: 0.8, colorScheme: "dark" } as const;
87 +
88 + const opened = yield* manager.open({ threadId, runtime: "server", ...rendering });
89 +
90 + expect(opened).toMatchObject(rendering);
91 + }),
92 + );
93 +
94 it.effect("reissues presentation requests without replaying them on navigation", () =>
95 Effect.gen(function* () {
96 const threadId = freshThreadId();
apps/server/src/preview/Manager.ts
+2
@@ -193,6 +193,8 @@ export const make = Effect.gen(function* PreviewManagerMake() {
193 viewport: input.viewport ?? FILL_PREVIEW_VIEWPORT,
194 ...(input.profileId === undefined ? {} : { profileId: input.profileId }),
195 ...(runtime === undefined ? {} : { runtime }),
196 + ...(input.colorScheme === undefined ? {} : { colorScheme: input.colorScheme }),
197 + ...(input.zoomFactor === undefined ? {} : { zoomFactor: input.zoomFactor }),
198 ...(runtime === "server" && input.automationOwner !== undefined
199 ? { automationOwner: input.automationOwner }
200 : {}),
apps/web/src/browser/browserDefaults.ts
+3 -2
@@ -5,6 +5,7 @@ import {
5 type DesktopPreviewTabDefaults,
6 type PreviewAppearancePreference,
7 type PreviewViewportSetting,
8 + type PreviewZoomFactor,
9 } from "@t3tools/contracts";
10
11 import {
@@ -17,7 +18,7 @@ import { resolveResponsiveBrowserViewportSize } from "./browserViewportLayout";
18
19 export interface BrowserDefaults {
20 readonly viewport: PreviewViewportSetting;
20 - readonly zoomFactor: number;
21 + readonly zoomFactor: PreviewZoomFactor;
22 readonly appearance: PreviewAppearancePreference;
23 readonly autoShowFloatingPreview: boolean;
24 readonly profiles: ReadonlyArray<BrowserProfile>;
@@ -26,7 +27,7 @@ export interface BrowserDefaults {
27
28 const toBrowserDefaults = (settings: {
29 readonly browserDefaultViewport: PreviewViewportSetting;
29 - readonly browserDefaultZoomFactor: number;
30 + readonly browserDefaultZoomFactor: PreviewZoomFactor;
31 readonly browserDefaultAppearance: PreviewAppearancePreference;
32 readonly browserAutoShowFloatingPreview: boolean;
33 readonly browserProfiles: ReadonlyArray<BrowserProfile>;
apps/web/src/browser/openFileInPreview.ts
+3 -1
@@ -85,7 +85,9 @@ export async function openUrlInPreview<E>(input: {
85 url: input.url,
86 viewport: defaults.viewport,
87 profileId: input.profileId ?? defaults.profileId,
88 - ...(runtime === undefined ? {} : { runtime }),
88 + ...(runtime === undefined
89 + ? {}
90 + : { runtime, zoomFactor: defaults.zoomFactor, colorScheme: defaults.appearance }),
91 },
92 });
93 return mapAtomCommandResult(result, (snapshot) => {
apps/web/src/components/preview/openPreviewSession.test.ts
+24
@@ -97,6 +97,30 @@ describe("openPreviewSession", () => {
97 });
98 },
99 );
100 +
101 + it.each(["new tab", "link"] as const)(
102 + "opens a server tab from a %s with the default zoom and appearance",
103 + async (entryPoint) => {
104 + __setClientSettingsForTests({
105 + ...DEFAULT_CLIENT_SETTINGS,
106 + browserDefaultZoomFactor: 0.8,
107 + browserDefaultAppearance: "dark",
108 + });
109 + const openPreview = vi.fn(async () => AsyncResult.success(snapshot));
110 +
111 + if (entryPoint === "link") {
112 + vi.spyOn(previewRuntime, "previewRuntimeFor").mockReturnValue("server");
113 + await openUrlInPreview({ openPreview, threadRef, url: "https://t3.chat/" });
114 + } else {
115 + await openPreviewSession({ openPreview, threadRef, runtime: "server" });
116 + }
117 +
118 + expect(openPreview).toHaveBeenCalledExactlyOnceWith({
119 + environmentId: threadRef.environmentId,
120 + input: expect.objectContaining({ runtime: "server", zoomFactor: 0.8, colorScheme: "dark" }),
121 + });
122 + },
123 + );
124 });
125
126 describe("openUrlInPreview from a link", () => {
apps/web/src/components/preview/openPreviewSession.ts
+3 -1
@@ -45,7 +45,9 @@ export async function openPreviewSession<E>(
45 ...(input.url === undefined ? {} : { url: input.url }),
46 viewport: input.viewport ?? defaults.viewport,
47 profileId: input.profileId ?? defaults.profileId,
48 - ...(runtime === undefined || runtime === "desktop" ? {} : { runtime }),
48 + ...(runtime === undefined || runtime === "desktop"
49 + ? {}
50 + : { runtime, zoomFactor: defaults.zoomFactor, colorScheme: defaults.appearance }),
51 },
52 });
53 if (result._tag === "Failure") {
apps/web/src/components/preview/openTerminalLinkInPreview.test.ts
+24
@@ -3,6 +3,8 @@ import * as Cause from "effect/Cause";
3 import { AsyncResult } from "effect/reactivity";
4 import { afterEach, beforeEach, describe, expect, it, vi } from "vite-plus/test";
5
6 +import type { OpenPreviewMutation } from "~/browser/openFileInPreview";
7 +import * as previewRuntime from "~/browser/previewRuntime";
8 import { openTerminalLinkInPreview } from "./openTerminalLinkInPreview";
9
10 vi.mock("~/previewStateStore", () => ({
@@ -36,6 +38,8 @@ vi.mock("~/browser/browserLinkTarget", () => ({
38 const hydratedDefaults = {
39 viewport: { _tag: "fixed", width: 1280, height: 720 } as const,
40 profileId: "work",
41 + zoomFactor: 0.8,
42 + appearance: "dark",
43 };
44
45 const threadRef = {
@@ -69,4 +73,24 @@ describe("openTerminalLinkInPreview", () => {
73 expect(reportError).not.toHaveBeenCalled();
74 expect(fallbackToBrowser).not.toHaveBeenCalled();
75 });
76 +
77 + it("opens a server tab with the default zoom and appearance", async () => {
78 + vi.spyOn(previewRuntime, "previewRuntimeFor").mockReturnValue("server");
79 + const openPreview = vi.fn<OpenPreviewMutation>(async () =>
80 + AsyncResult.failure(Cause.interrupt()),
81 + );
82 +
83 + await openTerminalLinkInPreview({
84 + url: "https://t3.chat/",
85 + threadRef,
86 + openPreview,
87 + fallbackToBrowser: vi.fn(),
88 + forceBrowser: false,
89 + });
90 +
91 + expect(openPreview).toHaveBeenCalledExactlyOnceWith({
92 + environmentId: threadRef.environmentId,
93 + input: expect.objectContaining({ runtime: "server", zoomFactor: 0.8, colorScheme: "dark" }),
94 + });
95 + });
96 });
apps/web/src/components/preview/openTerminalLinkInPreview.ts
+3 -1
@@ -64,7 +64,9 @@ export async function openTerminalLinkInPreview<E>(
64 url: input.url,
65 viewport: defaults.viewport,
66 profileId: defaults.profileId,
67 - ...(runtime === undefined ? {} : { runtime }),
67 + ...(runtime === undefined
68 + ? {}
69 + : { runtime, zoomFactor: defaults.zoomFactor, colorScheme: defaults.appearance }),
70 },
71 });
72 if (result._tag === "Failure") {
packages/contracts/src/preview.ts
+2
@@ -175,6 +175,8 @@ export const PreviewOpenInput = Schema.Struct({
175 viewport: Schema.optional(PreviewViewportSetting),
176 profileId: Schema.optional(BrowserProfileId),
177 runtime: Schema.optional(PreviewRuntime),
178 + colorScheme: Schema.optional(PreviewAppearancePreference),
179 + zoomFactor: Schema.optional(PreviewZoomFactor),
180 reveal: Schema.optional(Schema.Boolean),
181 });
182 export type PreviewOpenInput = typeof PreviewOpenInput.Type;