The best way to control Claude Code, Codex and more from any computer or phone
Mirrored from https://github.com/Camo67/t3code.git
Synced Nov 22, 18:15 UTC
fix(observability): desktop dev version and web environment match the other services (#23975)
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Yordis Prieto committed
Oct 23, 2026 at 20:56 UTC
bf5ffe84482ef295dd274914b9ed5cabd4cfc819
4 files changed
+37
-1
apps/desktop/src/app/DesktopObservability.test.ts
+30
@@ -1,4 +1,5 @@
1
import * as NodeHttpClient from "@effect/platform-node/NodeHttpClient";
2
+import desktopPackageJson from "../../package.json" with { type: "json" };
3
import * as NodeServices from "@effect/platform-node/NodeServices";
4
import { assert, describe, it } from "@effect/vitest";
5
import * as ConfigProvider from "effect/ConfigProvider";
@@ -312,4 +313,33 @@ describe("DesktopObservability", () => {
313
),
314
);
315
});
316
+
317
+ it.effect("reports the app's own version for an unpackaged desktop run", () => {
318
+ const requests: Array<ExportedRequest> = [];
319
+ return Effect.gen(function* () {
320
+ const fileSystem = yield* FileSystem.FileSystem;
321
+ const baseDir = yield* fileSystem.makeTempDirectoryScoped({
322
+ prefix: "t3-desktop-observability-test-",
323
+ });
324
+ const layerEnvironment = layerEnvironmentFor(baseDir);
325
+ yield* writeObservabilitySettings(layerEnvironment, {
326
+ otlpLogsUrl: "https://settings.example.com/v1/logs",
327
+ });
328
+
329
+ yield* Effect.scoped(
330
+ Effect.logInfo("desktop resource under test").pipe(
331
+ Effect.provide(DesktopObservability.layer.pipe(Layer.provideMerge(layerEnvironment))),
332
+ ),
333
+ );
334
+
335
+ const body = requests.map((request) => request.body).join("\n");
336
+ assert.include(
337
+ body,
338
+ `"key":"service.version","value":{"stringValue":"${desktopPackageJson.version}"}`,
339
+ );
340
+ }).pipe(
341
+ Effect.scoped,
342
+ Effect.provide(Layer.mergeAll(NodeServices.layer, layerCollector(requests), layerEmptyEnv)),
343
+ );
344
+ });
345
});
apps/desktop/src/app/DesktopObservability.ts
+4
-1
@@ -29,6 +29,8 @@ import * as SynchronizedRef from "effect/SynchronizedRef";
29
import * as Tracer from "effect/Tracer";
30
import { OtlpExporter, OtlpLogger, OtlpTracer } from "effect/observability";
31
32
+import desktopPackageJson from "../../package.json" with { type: "json" };
33
+
34
import * as DesktopEnvironment from "./DesktopEnvironment.ts";
35
36
const DESKTOP_LOG_FILE_MAX_BYTES = 10 * 1024 * 1024;
@@ -597,7 +599,8 @@ const layerTelemetry = Layer.unwrap(
599
const endpoints = yield* resolveOtlpEndpoints;
600
const resource = {
601
serviceName: "t3code-desktop",
600
- serviceVersion: environment.appVersion,
602
+ // Unpackaged runs launch a script, so Electron reports its own version.
603
+ serviceVersion: environment.isPackaged ? environment.appVersion : desktopPackageJson.version,
604
attributes: {
605
"service.namespace": "t3code",
606
"service.runtime": "desktop",
apps/web/src/observability/clientTracing.ts
+1
@@ -18,6 +18,7 @@ const CLIENT_TRACING_RESOURCE = {
18
serviceName: "t3code-web",
19
attributes: {
20
"service.namespace": "t3code",
21
+ "deployment.environment.name": import.meta.env.DEV ? "development" : "production",
22
"service.runtime": "t3-web",
23
"service.mode": isElectron ? "electron" : "browser",
24
"service.version": APP_VERSION,
docs/operations/observability.md
+2
@@ -626,6 +626,8 @@ Service names are fixed: `t3code-server` for the backend and `t3code-desktop` fo
626
process, both in `service.namespace` `t3code`. `OTEL_SERVICE_NAME` and a `service.name` or
627
`service.namespace` in `OTEL_RESOURCE_ATTRIBUTES` are ignored. Tell installations apart with other
628
resource attributes, such as `OTEL_RESOURCE_ATTRIBUTES=deployment.environment.name=development`.
629
+The UI reports `deployment.environment.name` from its build: `development` under the Vite dev server
630
+and `production` otherwise.
631
632
If the OTLP URLs are unset, local tracing still works, metrics stay in-process only, and logs stay
633
on stdout only.