@devries-cameron20 / t3code Mirror · read-only / commits / bfee44655c
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 22, 13:15 UTC

fix(web): keep a closed split terminal's tab in view (#22106)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: maria-rcks <maria@kuuro.net>

Victor Vogel committed Oct 29, 2026 at 12:42 UTC bfee44655ccbb4ec282f3cdd52e521b6258785db
2 files changed +29 -1
apps/web/src/terminalUiStateStore.test.ts
+22
@@ -7,6 +7,7 @@ import {
7 selectThreadTerminalUiState,
8 useTerminalUiStateStore,
9 } from "./terminalUiStateStore";
10 +import { DEFAULT_THREAD_TERMINAL_ID } from "./types";
11
12 const THREAD_ID = ThreadId.make("thread-1");
13 const THREAD_REF = scopeThreadRef("environment-a" as never, THREAD_ID);
@@ -138,6 +139,27 @@ describe("terminalUiStateStore actions", () => {
139 ]);
140 });
141
142 + it.each([
143 + ["terminal-3", "terminal-3", DEFAULT_THREAD_TERMINAL_ID],
144 + [DEFAULT_THREAD_TERMINAL_ID, DEFAULT_THREAD_TERMINAL_ID, "terminal-3"],
145 + ["terminal-3", DEFAULT_THREAD_TERMINAL_ID, "terminal-3"],
146 + ])("keeps the split's tab when %s is active and %s closes", (activeId, closedId, nextId) => {
147 + const store = useTerminalUiStateStore.getState();
148 + store.setTerminalOpen(THREAD_REF, true);
149 + store.newTerminal(THREAD_REF, "terminal-2");
150 + store.setActiveTerminal(THREAD_REF, DEFAULT_THREAD_TERMINAL_ID);
151 + store.splitTerminal(THREAD_REF, "terminal-3");
152 + store.setActiveTerminal(THREAD_REF, activeId);
153 + store.closeTerminal(THREAD_REF, closedId);
154 +
155 + const terminalUiState = selectThreadTerminalUiState(
156 + useTerminalUiStateStore.getState().terminalUiStateByThreadKey,
157 + THREAD_REF,
158 + );
159 + expect(terminalUiState.activeTerminalId).toBe(nextId);
160 + expect(terminalUiState.activeTerminalGroupId).toBe(`group-${DEFAULT_THREAD_TERMINAL_ID}`);
161 + });
162 +
163 it("does not import a closed panel terminal from stale metadata", () => {
164 const store = useTerminalUiStateStore.getState();
165 store.newTerminal(THREAD_REF, "term-2");
apps/web/src/terminalUiStateStore.ts
+7 -1
@@ -413,9 +413,15 @@ function closeThreadTerminal(
413 }
414
415 const closedTerminalIndex = normalized.terminalIds.indexOf(terminalId);
416 + const groupTerminalIds =
417 + normalized.terminalGroups.find((group) => group.terminalIds.includes(terminalId))
418 + ?.terminalIds ?? [];
419 + const groupIndex = groupTerminalIds.indexOf(terminalId);
420 const nextActiveTerminalId =
421 normalized.activeTerminalId === terminalId
418 - ? (remainingTerminalIds[Math.min(closedTerminalIndex, remainingTerminalIds.length - 1)] ??
422 + ? (groupTerminalIds[groupIndex + 1] ??
423 + groupTerminalIds[groupIndex - 1] ??
424 + remainingTerminalIds[Math.min(closedTerminalIndex, remainingTerminalIds.length - 1)] ??
425 remainingTerminalIds[0] ??
426 "")
427 : normalized.activeTerminalId;