@devries-cameron20 / t3code Mirror · read-only / commits / c0c7405b04
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 21, 21:00 UTC

fix(server): t3_thread_list says when its project does not exist (#29187)

Julius Marminge committed Nov 11, 2026 at 20:06 UTC c0c7405b04148f7fa3de5352d0e0aa149806c040
3 files changed +48 -2
apps/server/src/mcp/OrchestratorMcpService.test.ts
+30 -1
@@ -35,6 +35,7 @@ import * as Fiber from "effect/Fiber";
35 import * as Layer from "effect/Layer";
36 import * as Queue from "effect/Queue";
37 import * as Ref from "effect/Ref";
38 +import * as Result from "effect/Result";
39 import * as Schema from "effect/Schema";
40 import * as Stream from "effect/Stream";
41
@@ -3912,7 +3913,21 @@ describe("OrchestratorMcpService thread list", () => {
3913 Layer.mock(ProviderAdapterRegistry.ProviderAdapterRegistryV2)({
3914 list: () => Effect.succeed([]),
3915 }),
3915 - Layer.mock(ProjectService.ProjectService)({}),
3916 + Layer.mock(ProjectService.ProjectService)({
3917 + getById: (id) =>
3918 + shells.some((thread) => thread.projectId === id)
3919 + ? Effect.succeedSome({
3920 + id,
3921 + title: id,
3922 + workspaceRoot: `/projects/${id}`,
3923 + defaultModelSelection: null,
3924 + scripts: [],
3925 + createdAt: "2026-10-18T00:00:00.000Z",
3926 + updatedAt: "2026-10-18T00:00:00.000Z",
3927 + deletedAt: null,
3928 + })
3929 + : Effect.succeedNone,
3930 + }),
3931 Layer.mock(SecretRequests.SecretRequests)({}),
3932 Layer.mock(RemoteDelegation.RemoteDelegation)({}),
3933 Layer.mock(ScheduledTaskService.ScheduledTaskService)({}),
@@ -3939,6 +3954,20 @@ describe("OrchestratorMcpService thread list", () => {
3954 }).pipe(Effect.provide(service)),
3955 );
3956
3957 + it.effect("refuses a projectId that names no project", () =>
3958 + Effect.gen(function* () {
3959 + const mcp = yield* OrchestratorMcpService.OrchestratorMcpService;
3960 + const listed = yield* mcp
3961 + .listThreads(client, { projectId: ProjectId.make("project:missing") })
3962 + .pipe(Effect.result);
3963 + if (Result.isSuccess(listed)) {
3964 + assert.fail(`listed threads for a missing project: ${JSON.stringify(listed.success)}`);
3965 + }
3966 + assert.equal(listed.failure.code, "invalid_request");
3967 + assert.include(listed.failure.message, "not found");
3968 + }).pipe(Effect.provide(service)),
3969 + );
3970 +
3971 it.effect("counts a thread holding awaited background work as live in the status filter", () =>
3972 Effect.gen(function* () {
3973 const mcp = yield* OrchestratorMcpService.OrchestratorMcpService;
apps/server/src/mcp/OrchestratorMcpService.ts
+3
@@ -2969,6 +2969,9 @@ const make = Effect.gen(function* () {
2969 input.projectId,
2970 "Pass projectId, or allProjects: true for every project. This MCP client is not running inside a T3 thread.",
2971 );
2972 + if (!input.allProjects && input.projectId !== undefined) {
2973 + yield* requireProject(input.projectId);
2974 + }
2975 const projectThreads = yield* threadManagement
2976 .listProjectThreads({
2977 projectId: projectId ?? undefined,
apps/server/src/mcp/toolkits/core.test.ts
+15 -1
@@ -1100,7 +1100,21 @@ it.effect(
1100 Layer.provide(Layer.mock(ProviderRegistry.ProviderRegistry)({})),
1101 Layer.provide(Layer.mock(ProviderAdapterRegistry.ProviderAdapterRegistryV2)({})),
1102 Layer.provide(Layer.mock(ScheduledTaskService.ScheduledTaskService)({})),
1103 - Layer.provide(Layer.mock(ProjectService.ProjectService)({})),
1103 + Layer.provide(
1104 + Layer.mock(ProjectService.ProjectService)({
1105 + getById: (projectId) =>
1106 + Effect.succeedSome({
1107 + id: projectId,
1108 + title: "MCP test",
1109 + workspaceRoot: "/repo",
1110 + defaultModelSelection: null,
1111 + scripts: [],
1112 + createdAt: "2026-10-18T00:00:00.000Z",
1113 + updatedAt: "2026-10-18T00:00:00.000Z",
1114 + deletedAt: null,
1115 + }),
1116 + }),
1117 + ),
1118 Layer.provide(Layer.mock(SecretRequests.SecretRequests)({})),
1119 Layer.provide(Layer.mock(PeerForwarding.PeerForwarding)({})),
1120 Layer.provide(Layer.mock(PeerLinkRequests.PeerLinkRequests)({})),