@devries-cameron20 / t3code Mirror · read-only / commits / cb79cfb007
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 22, 07:00 UTC

fix(server): report a created PR as created when its lookup fails (#23242)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: maria-rcks <maria@kuuro.net>

Victor Vogel committed Nov 1, 2026 at 15:58 UTC cb79cfb007bf43780bf65c494412eb09bd2a42f9
2 files changed +59 -1
apps/server/src/git/GitManager.test.ts
+50
@@ -3091,6 +3091,56 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
3091 }),
3092 );
3093
3094 + it.effect("create_pr reports a created PR when the lookup after creation fails", () =>
3095 + Effect.gen(function* () {
3096 + const repoDir = yield* makeTempDir("t3code-git-manager-");
3097 + yield* initRepo(repoDir);
3098 + yield* runGit(repoDir, ["checkout", "-b", "feature/lookup-after-create"]);
3099 + const remoteDir = yield* createBareRemote();
3100 + yield* runGit(repoDir, ["remote", "add", "origin", remoteDir]);
3101 + NodeFS.writeFileSync(NodePath.join(repoDir, "lookup.txt"), "lookup\n");
3102 + yield* runGit(repoDir, ["add", "lookup.txt"]);
3103 + yield* runGit(repoDir, ["commit", "-m", "Lookup after create"]);
3104 + yield* runGit(repoDir, ["push", "-u", "origin", "feature/lookup-after-create"]);
3105 +
3106 + const { service: github } = createFakeSourceControlProvider();
3107 + let created = false;
3108 + const { manager } = yield* makeManager({
3109 + sourceControlProvider: {
3110 + ...github,
3111 + createChangeRequest: (input) =>
3112 + github.createChangeRequest(input).pipe(
3113 + Effect.tap(() =>
3114 + Effect.sync(() => {
3115 + created = true;
3116 + }),
3117 + ),
3118 + ),
3119 + listChangeRequests: (input) =>
3120 + created
3121 + ? Effect.fail(
3122 + new SourceControlProviderFailure({
3123 + provider: github.kind,
3124 + operation: "listChangeRequests",
3125 + cwd: input.cwd,
3126 + detail: "GitHub API rate limit exceeded.",
3127 + }),
3128 + )
3129 + : github.listChangeRequests(input),
3130 + },
3131 + });
3132 +
3133 + const result = yield* runStackedAction(manager, { cwd: repoDir, action: "create_pr" });
3134 +
3135 + expect(created).toBe(true);
3136 + expect(result.pr).toMatchObject({
3137 + status: "created",
3138 + headBranch: "feature/lookup-after-create",
3139 + });
3140 + expect(result.pr.url).toBeUndefined();
3141 + }),
3142 + );
3143 +
3144 it.effect("returns existing PR metadata for commit/push/pr action", () =>
3145 Effect.gen(function* () {
3146 const repoDir = yield* makeTempDir("t3code-git-manager-");
apps/server/src/git/GitManager.ts
+9 -1
@@ -2339,7 +2339,15 @@ export const make = Effect.gen(function* () {
2339 })
2340 .pipe(Effect.ensuring(fileSystem.remove(bodyFile).pipe(Effect.ignore)));
2341
2342 - const created = yield* findOpenPr(cwd, headContext);
2342 + // The PR already exists at this point, so a failed lookup only loses its metadata.
2343 + const created = yield* findOpenPr(cwd, headContext).pipe(
2344 + Effect.catch((error) =>
2345 + Effect.logWarning("GitManager.runPrStep lookup after create failed", {
2346 + provider: provider.kind,
2347 + errorTag: error._tag,
2348 + }).pipe(Effect.as(null)),
2349 + ),
2350 + );
2351 if (!created) {
2352 return {
2353 status: "created" as const,