The best way to control Claude Code, Codex and more from any computer or phone
Mirrored from https://github.com/Camo67/t3code.git
Synced Nov 22, 14:30 UTC
refactor(mobile): stop writing the resolved project filter back from an effect (#26049)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Julius Marminge committed
Oct 27, 2026 at 11:50 UTC
d1c4b52b7c7c7e1b7637ec47e4c959ff0c2d8d99
2 files changed
+15
-19
apps/mobile/src/features/home/HomeRouteScreen.tsx
+11
-11
@@ -6,7 +6,7 @@ import { NativePrimaryColumnContext } from "../../native/v5-workspace-context";
6
import * as Arr from "effect/Array";
7
import * as Order from "effect/Order";
8
import { useNavigation } from "@react-navigation/native";
9
-import { useCallback, useEffect, useMemo, useState } from "react";
9
+import { useCallback, useMemo, useState } from "react";
10
import { Platform, useWindowDimensions } from "react-native";
11
12
import type { EnvironmentThreadShell } from "@t3tools/client-runtime/state/shell";
@@ -137,16 +137,16 @@ export function HomeRouteScreen() {
137
setSelectedProjectKey,
138
} = useHomeListOptions(availableEnvironmentIds);
139
const selectedEnvironmentId = listOptions.selectedEnvironmentId;
140
- const projectScopeKey = listOptions.selectedProjectKey;
141
- const resolvedProjectKey = resolveScratchProjectScopeKey(projectScopeKey, projects, {
142
- sidebarProjectGroupingMode: listOptions.projectGroupingMode,
143
- sidebarProjectGroupingOverrides: {},
144
- });
145
- useEffect(() => {
146
- if (resolvedProjectKey !== projectScopeKey) {
147
- setSelectedProjectKey(resolvedProjectKey);
148
- }
149
- }, [projectScopeKey, resolvedProjectKey, setSelectedProjectKey]);
140
+ // A legacy per-environment scratch key resolves here on every render; the stored
141
+ // value is only rewritten when the user picks a filter.
142
+ const resolvedProjectKey = resolveScratchProjectScopeKey(
143
+ listOptions.selectedProjectKey,
144
+ projects,
145
+ {
146
+ sidebarProjectGroupingMode: listOptions.projectGroupingMode,
147
+ sidebarProjectGroupingOverrides: {},
148
+ },
149
+ );
150
const projectFilterOptions = useMemo(
151
() =>
152
buildHomeProjectScopes({
apps/mobile/src/features/threads/ThreadNavigationSidebar.tsx
+4
-8
@@ -15,7 +15,7 @@ import { AnimatedLegendList } from "@legendapp/list/reanimated";
15
import { THREAD_SIDEBAR_ROW_LAYOUT } from "./threadListAnimations";
16
import type { MenuAction } from "@react-native-menu/menu";
17
import { useAtomValue } from "@effect/atom-react";
18
-import { useEffect, useMemo, useRef, useState } from "react";
18
+import { useMemo, useRef, useState } from "react";
19
import type { LayoutChangeEvent, TextInputInstance } from "react-native";
20
import { Platform, StyleSheet, TextInput, View } from "react-native";
21
import { GestureDetector, useNativeGesture } from "react-native-gesture-handler";
@@ -198,16 +198,12 @@ function ThreadNavigationSidebarPane(
198
)
199
? [options.selectedEnvironmentId]
200
: [];
201
- const projectScopeKey = options.selectedProjectKey;
202
- const resolvedProjectKey = resolveScratchProjectScopeKey(projectScopeKey, projects, {
201
+ // A legacy per-environment scratch key resolves here on every render; the stored
202
+ // value is only rewritten when the user picks a filter.
203
+ const resolvedProjectKey = resolveScratchProjectScopeKey(options.selectedProjectKey, projects, {
204
sidebarProjectGroupingMode: options.projectGroupingMode,
205
sidebarProjectGroupingOverrides: {},
206
});
206
- useEffect(() => {
207
- if (resolvedProjectKey !== projectScopeKey) {
208
- setSelectedProjectKey(resolvedProjectKey);
209
- }
210
- }, [projectScopeKey, resolvedProjectKey, setSelectedProjectKey]);
207
const projectScopes = useMemo(
208
() =>
209
buildHomeProjectScopes({