The best way to control Claude Code, Codex and more from any computer or phone
Mirrored from https://github.com/Camo67/t3code.git
Synced Nov 22, 15:45 UTC
chore(lint): enforce oxc/no-accumulating-spread (#25114)
Julius Marminge committed
Oct 25, 2026 at 23:01 UTC
d53b446284b33b4fb71bb0acb15bc3408bf9660a
5 files changed
+46
-26
apps/server/src/orchestration-v2/ThreadTitleRegenerationService.ts
+3
-3
@@ -90,15 +90,15 @@ const make = Effect.gen(function* () {
90
thread: OrchestrationV2AppThread,
91
) {
92
let title: string | undefined;
93
- let history: Array<OrchestrationV2ConversationMessage> = [];
93
+ const history: Array<ReadonlyArray<OrchestrationV2ConversationMessage>> = [];
94
let forkedFrom = thread.forkedFrom;
95
while (forkedFrom?.type === "run") {
96
const source = yield* messagesThroughRun(forkedFrom.threadId, forkedFrom.runId);
97
- history = [...source.messages, ...history];
97
+ history.push(source.messages);
98
title ??= source.thread.title;
99
forkedFrom = source.thread.forkedFrom;
100
}
101
- const context = formatThreadTitleContext(history);
101
+ const context = formatThreadTitleContext(history.reverse().flat());
102
return title === undefined || context.message.length === 0
103
? undefined
104
: { title, history: context.message };
packages/client-runtime/src/state/shell.ts
+2
@@ -211,6 +211,7 @@ export const makeEnvironmentShellState = Effect.fn("EnvironmentShellState.make")
211
) {
212
const initial = yield* SubscriptionRef.get(state);
213
let waiting = yield* Ref.get(awaitingCompletion);
214
+ /* oxlint-disable oxc/no-accumulating-spread -- This copies a fixed-shape state record, not a growing collection. */
215
let next = initial;
216
let receivedSnapshot = false;
217
for (const item of items) {
@@ -260,6 +261,7 @@ export const makeEnvironmentShellState = Effect.fn("EnvironmentShellState.make")
261
: new Map(next.removedAt).set(removal.threadId, removal.sequence),
262
};
263
}
264
+ /* oxlint-enable oxc/no-accumulating-spread */
265
yield* Ref.set(awaitingCompletion, waiting);
266
if (next === initial) return;
267
if (pendingLinkIds !== undefined && Option.isSome(next.snapshot)) {
packages/shared/src/serverSettings.test.ts
+11
@@ -770,6 +770,13 @@ describe("worktreesDirectory", () => {
770
});
771
772
describe("synchronized model preferences", () => {
773
+ it("supports provider identifiers that match inherited object keys", () => {
774
+ const provider = ProviderInstanceId.make("toString");
775
+ const next = applyServerSettingsPatch(DEFAULT_SERVER_SETTINGS, {
776
+ setModelsHidden: [{ provider, model: "example", hidden: true }],
777
+ });
778
+ expect(next.providerModelPreferences?.[provider]?.hiddenModels).toEqual(["example"]);
779
+ });
780
const provider = ProviderInstanceId.make("codex_work");
781
const legacy = {
782
favorites: [{ provider, model: "sol" }],
@@ -783,6 +790,7 @@ describe("synchronized model preferences", () => {
790
const remove = { setModelFavorites: [{ provider, model: "sol", favorite: false }] };
791
const removed = applyServerSettingsPatch(first, remove);
792
expect(applyServerSettingsPatch(removed, remove).favorites).toEqual([]);
793
+ expect(first.favorites).toEqual([{ provider, model: "sol" }]);
794
});
795
796
it("preserves unrelated models and providers during bulk visibility and order edits", () => {
@@ -803,6 +811,9 @@ describe("synchronized model preferences", () => {
811
],
812
setProviderModelOrder: { provider, modelOrder: ["sol", "luna", "astra"] },
813
});
814
+ expect(initial.providerModelPreferences?.[provider]).toEqual(
815
+ legacy.providerModelPreferences[provider],
816
+ );
817
expect(web.providerModelPreferences?.[provider]).toEqual({
818
hiddenModels: ["luna", "sol"],
819
modelOrder: ["sol", "luna", "astra"],
packages/shared/src/serverSettings.ts
+29
-23
@@ -432,35 +432,41 @@ export function applyServerSettingsPatch(
432
const initialFavorites =
433
patch.favorites ?? current.favorites ?? migrateModelPreferences?.favorites ?? null;
434
const favorites =
435
- setModelFavorites?.reduce((current, change) => {
436
- const exists = current.some(
437
- (favorite) => favorite.provider === change.provider && favorite.model === change.model,
438
- );
439
- return change.favorite
440
- ? exists
441
- ? current
442
- : [...current, { provider: change.provider, model: change.model }]
443
- : current.filter(
444
- (favorite) => favorite.provider !== change.provider || favorite.model !== change.model,
445
- );
446
- }, initialFavorites ?? []) ?? initialFavorites;
435
+ setModelFavorites?.reduce(
436
+ (current, change) => {
437
+ const exists = current.some(
438
+ (favorite) => favorite.provider === change.provider && favorite.model === change.model,
439
+ );
440
+ if (change.favorite) {
441
+ if (!exists) current.push({ provider: change.provider, model: change.model });
442
+ return current;
443
+ }
444
+ return current.filter(
445
+ (favorite) => favorite.provider !== change.provider || favorite.model !== change.model,
446
+ );
447
+ },
448
+ [...(initialFavorites ?? [])],
449
+ ) ?? initialFavorites;
450
const initialModelPreferences =
451
providerModelPreferences ??
452
current.providerModelPreferences ??
453
migrateModelPreferences?.providerModelPreferences ??
454
null;
455
let nextModelPreferences = initialModelPreferences;
453
- for (const change of setModelsHidden ?? []) {
454
- const preferences = nextModelPreferences?.[change.provider] ?? {
455
- hiddenModels: [],
456
- modelOrder: [],
457
- };
458
- const hiddenModels = preferences.hiddenModels.filter((model) => model !== change.model);
459
- if (change.hidden) hiddenModels.push(change.model);
460
- nextModelPreferences = {
461
- ...nextModelPreferences,
462
- [change.provider]: { ...preferences, hiddenModels },
463
- };
456
+ if (setModelsHidden?.length) {
457
+ const updated = { ...initialModelPreferences };
458
+ for (const change of setModelsHidden) {
459
+ const preferences = (Object.hasOwn(updated, change.provider)
460
+ ? updated[change.provider]
461
+ : undefined) ?? {
462
+ hiddenModels: [],
463
+ modelOrder: [],
464
+ };
465
+ const hiddenModels = preferences.hiddenModels.filter((model) => model !== change.model);
466
+ if (change.hidden) hiddenModels.push(change.model);
467
+ updated[change.provider] = { ...preferences, hiddenModels };
468
+ }
469
+ nextModelPreferences = updated;
470
}
471
if (setProviderModelOrder) {
472
const preferences = nextModelPreferences?.[setProviderModelOrder.provider] ?? {
vite.config.ts
+1
@@ -216,6 +216,7 @@ export default defineConfig({
216
perf: "warn",
217
},
218
rules: {
219
+ "oxc/no-accumulating-spread": "error",
220
"eslint/no-control-regex": "off",
221
"typescript/no-this-alias": "off",
222
"unicorn/prefer-add-event-listener": "off",