@devries-cameron20 / t3code Mirror · read-only / commits / d8597159d9
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 22, 15:45 UTC

chore(lint): enforce abortControllerInEffect (#25098)

Julius Marminge committed Oct 25, 2026 at 23:01 UTC d8597159d96219b0745e681041da71b618ea8713
5 files changed +10 -9
apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts
+4 -9
@@ -1008,12 +1008,9 @@ describe("ClaudeAdapterV2 approval cancellation", () => {
1008 decision: ProviderApprovalDecision;
1009 feedback?: string;
1010 }>();
1011 - const controller = new AbortController();
1012 - controller.abort();
1013 -
1011 const result = yield* ClaudeAdapterV2.awaitClaudeApprovalDecision(
1012 decision,
1016 - controller.signal,
1013 + AbortSignal.abort(),
1014 );
1015
1016 assert.deepEqual(result, { decision: "cancel" });
@@ -1364,14 +1361,14 @@ describe("ClaudeAdapterV2 resume compaction", () => {
1361 Stream.runHead,
1362 Effect.forkScoped,
1363 );
1367 - const controller = new AbortController();
1364 + const signal = yield* Effect.abortSignal;
1365 const dialog = yield* Effect.promise(() =>
1366 callback!(
1367 {
1368 dialogKind: "resume_return",
1369 payload: { sessionAgeMinutes: 90, estimatedTokens: 120000 },
1370 },
1374 - { signal: controller.signal, requestId: "dialog-resume-1" },
1371 + { signal, requestId: "dialog-resume-1" },
1372 ),
1373 ).pipe(Effect.forkScoped);
1374 const event = yield* Fiber.join(requestEvent);
@@ -1387,8 +1384,6 @@ describe("ClaudeAdapterV2 resume compaction", () => {
1384 });
1385 assert.deepEqual(yield* Fiber.join(dialog), { behavior: "completed", result: "compact" });
1386
1390 - const cancelledController = new AbortController();
1391 - cancelledController.abort();
1387 assert.deepEqual(
1388 yield* Effect.promise(() =>
1389 callback!(
@@ -1396,7 +1391,7 @@ describe("ClaudeAdapterV2 resume compaction", () => {
1391 dialogKind: "resume_return",
1392 payload: { sessionAgeMinutes: 90, estimatedTokens: 120000 },
1393 },
1399 - { signal: cancelledController.signal, requestId: "dialog-resume-2" },
1394 + { signal: AbortSignal.abort(), requestId: "dialog-resume-2" },
1395 ),
1396 ),
1397 { behavior: "cancelled" },
apps/server/src/orchestration-v2/Adapters/ClaudeAgentSdkQueryRunner.test.ts
+1
@@ -196,6 +196,7 @@ describe.skipIf(HostProcess.Platform.defaultValue() === "win32")("Claude CLI pro
196 args: [],
197 cwd: dir,
198 env: process.env,
199 + // @effect-diagnostics-next-line abortControllerInEffect:off - This crash fixture closes pipes itself; aborting on test teardown raises an unrelated process error.
200 signal: new AbortController().signal,
201 }) as NodeChildProcess.ChildProcess;
202 yield* Effect.addFinalizer(() =>
apps/server/src/orchestration-v2/ClaudeAutomaticDelivery.integration.test.ts
+1
@@ -139,6 +139,7 @@ it.effect.each(deliveries)(
139 const sdkMessages = yield* Queue.unbounded<SDKMessage>();
140 const offers: SDKUserMessage[] = [];
141 const nativeQueue: SDKUserMessage[] = [];
142 + // @effect-diagnostics-next-line abortControllerInEffect:off - The fake SDK interrupts its batch independently of the test fiber.
143 const batchAbort = new AbortController();
144 const adapter = yield* ClaudeAdapterV2.makeClaudeAdapterV2({
145 instanceId: modelSelection.instanceId,
packages/provider-opencode/src/server/adapter.ts
+3
@@ -983,6 +983,7 @@ export const makeOpenCodeAdapterV2 = Effect.fn("makeOpenCodeAdapterV2")(function
983 if (settledNativeRequestIds.size >= 2_048) settledNativeRequestIds.clear();
984 settledNativeRequestIds.add(nativeRequestId);
985 };
986 + // @effect-diagnostics-next-line abortControllerInEffect:off - Session closure aborts this stream independently of the creation fiber.
987 const abortController = new AbortController();
988 let closing = false;
989 let hasConnected = false;
@@ -3159,6 +3160,7 @@ export const makeOpenCodeAdapterV2 = Effect.fn("makeOpenCodeAdapterV2")(function
3160 admissionMessageObserved: false,
3161 idleDuringAdmission: false,
3162 admissionSettled: Deferred.makeUnsafe<void>(),
3163 + // @effect-diagnostics-next-line abortControllerInEffect:off - Turn interruption owns prompt admission cancellation.
3164 admissionAbortController: new AbortController(),
3165 };
3166 if (turn.admissionMessageId !== null)
@@ -3325,6 +3327,7 @@ export const makeOpenCodeAdapterV2 = Effect.fn("makeOpenCodeAdapterV2")(function
3327 turn.admissionMessageObserved = false;
3328 turn.idleDuringAdmission = false;
3329 turn.admissionSettled = Deferred.makeUnsafe<void>();
3330 + // @effect-diagnostics-next-line abortControllerInEffect:off - Steering replaces the admission request independently of this command fiber.
3331 turn.admissionAbortController = new AbortController();
3332 if (turn.admissionMessageId !== null)
3333 turn.usage.promptMessageIds.add(turn.admissionMessageId);
tsconfig.base.json
+1
@@ -24,6 +24,7 @@
24 "namespaceImportPackages": ["@effect/platform-node", "effect"],
25 "effectFn": ["span", "inferred-span", "suggested-span"],
26 "diagnosticSeverity": {
27 + "abortControllerInEffect": "error",
28 "runEffectInsideEffect": "error",
29 "flatMapConditionalToFilterOrFail": "error",
30 "catchConditionalRefailToCatchIf": "error",