@devries-cameron20 / t3code Mirror · read-only / commits / d8a829e5ec
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 22, 07:00 UTC

perf(web): PDF previews reload without starting a new pdf.js worker (#29626)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Alex Southwell committed Nov 3, 2026 at 00:48 UTC d8a829e5ecd6626f8fdee23ef20ca9758e056251
2 files changed +8 -1
apps/web/src/components/files/AttachmentFilePreview.browser.test.tsx
+2
@@ -2522,6 +2522,7 @@ it("keeps workspace PDF scroll and zoom after reloads", async () => {
2522 const { preview, urls } = fixture;
2523 await using screen = await render(preview(urls.original, "one"));
2524 await expect.element(screen.getByText("1 / 3 pages", { exact: true })).toBeVisible();
2525 + using workers = vi.spyOn(window, "Worker");
2526 await screen.getByRole("button", { name: "Next page", exact: true }).click();
2527 await vi.waitFor(() => expect(screen.container.textContent).toContain("2 / 3 pages"));
2528 await screen.getByRole("button", { name: "Next page", exact: true }).click();
@@ -2576,6 +2577,7 @@ it("keeps workspace PDF scroll and zoom after reloads", async () => {
2577 expect(region().scrollTop).toBe(0);
2578 expect(region().scrollLeft).toBe(0);
2579 });
2580 + expect(workers).not.toHaveBeenCalled();
2581 });
2582
2583 it("clamps workspace PDF scroll when pages shrink or disappear", async () => {
apps/web/src/components/files/pdfDocument.ts
+6 -1
@@ -1,4 +1,4 @@
1 -import { getDocument, GlobalWorkerOptions } from "pdfjs-dist";
1 +import { getDocument, GlobalWorkerOptions, PDFWorker } from "pdfjs-dist";
2 import workerUrl from "pdfjs-dist/build/pdf.worker.min.mjs?url";
3 import fallbackUrl from "pdfjs-dist/wasm/openjpeg_nowasm_fallback.js?url";
4
@@ -31,8 +31,13 @@ export class BinaryDataFactory {
31 }
32 }
33
34 +// Without a shared worker, pdf.js starts a worker and recompiles its 1.3 MB script for every document.
35 +let worker: PDFWorker | undefined;
36 +
37 export function openPdf(bytes: ArrayBuffer) {
38 + worker ??= new PDFWorker();
39 return getDocument({
40 + worker,
41 data: new Uint8Array(bytes),
42 useSystemFonts: true,
43 useWorkerFetch: false,