The best way to control Claude Code, Codex and more from any computer or phone
Mirrored from https://github.com/Camo67/t3code.git
Synced Nov 21, 19:45 UTC
fix(server): "Open in" stops offering the tailnet name after `tailscale down` (#35539)
Julius Marminge committed
Nov 12, 2026 at 11:13 UTC
dbbd1d253c1ccaa8e08002cac421870c5d4103f0
4 files changed
+36
-1
apps/server/src/environment/RemoteOpenTargets.test.ts
+26
@@ -162,6 +162,32 @@ describe("RemoteOpenTargets", () => {
162
}),
163
);
164
165
+ it.effect("drops the tailnet name after `tailscale down` while sshd listens", () =>
166
+ Effect.gen(function* () {
167
+ const targets = yield* resolveTargets({
168
+ sshd: { ipv4: true, ipv6: false },
169
+ tailscale: {
170
+ // After `tailscale down`, status still exits 0 and keeps Self from the last netmap.
171
+ status: {
172
+ exitCode: 0,
173
+ stdout: JSON.stringify({
174
+ BackendState: "Stopped",
175
+ Self: {
176
+ DNSName: "bb-1.tail1234.ts.net.",
177
+ TailscaleIPs: ["100.64.1.2"],
178
+ Online: false,
179
+ },
180
+ }),
181
+ },
182
+ prefs: prefsJson({ RunSSH: false, WantRunning: false }),
183
+ },
184
+ hostname: "bb-1",
185
+ username: "t3-user",
186
+ });
187
+ expect(targets).toEqual([{ kind: "mdns", host: "bb-1.local", username: "t3-user" }]);
188
+ }),
189
+ );
190
+
191
it.effect("accepts an sshd bound to IPv6 loopback only", () =>
192
Effect.gen(function* () {
193
const targets = yield* resolveTargets({
apps/server/src/environment/RemoteOpenTargets.ts
+2
-1
@@ -37,7 +37,8 @@ export const make = Effect.gen(function* () {
37
Effect.orElseSucceed(() => null),
38
Effect.provideService(ChildProcessSpawner.ChildProcessSpawner, spawner),
39
);
40
- const magicDnsName = tailscaleStatus?.magicDnsName ?? null;
40
+ const magicDnsName =
41
+ tailscaleStatus?.running === false ? null : (tailscaleStatus?.magicDnsName ?? null);
42
43
const targets: Array<RemoteOpenTarget> = [];
44
packages/tailscale/src/tailscale.test.ts
+1
@@ -255,6 +255,7 @@ describe("tailscale", () => {
255
Effect.gen(function* () {
256
const status = yield* parseTailscaleStatus(tailscaleStatusJson);
257
assert.deepEqual(status, {
258
+ running: null,
259
magicDnsName: "desktop.tail.ts.net",
260
tailnetIpv4Addresses: ["100.100.100.100"],
261
httpsServeEnabled: null,
packages/tailscale/src/tailscale.ts
+7
@@ -145,12 +145,18 @@ const TailscaleStatusSelf = Schema.Struct({
145
});
146
147
const TailscaleStatusJson = Schema.Struct({
148
+ BackendState: Schema.optional(Schema.Unknown),
149
Self: Schema.optional(TailscaleStatusSelf),
150
});
151
152
export type TailscaleStatusJson = typeof TailscaleStatusJson.Type;
153
154
export interface TailscaleStatus {
155
+ /**
156
+ * `tailscale down` keeps `Self` from the last netmap, so the DNS name alone
157
+ * does not mean the tailnet is reachable. `null` when the CLI omits BackendState.
158
+ */
159
+ readonly running: boolean | null;
160
readonly magicDnsName: string | null;
161
readonly tailnetIpv4Addresses: readonly string[];
162
/**
@@ -220,6 +226,7 @@ export const parseTailscaleStatus = (
226
227
const capMap = parsed.Self?.CapMap;
228
return {
229
+ running: parsed.BackendState === undefined ? null : parsed.BackendState === "Running",
230
magicDnsName: normalizeMagicDnsName(parsed),
231
tailnetIpv4Addresses,
232
httpsServeEnabled: