@devries-cameron20 / t3code Mirror · read-only / commits / de386ada9e
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 22, 13:15 UTC

fix(web): create tasks on a permitted connected environment (#23244)

Co-authored-by: GPT-6.1 Sol <noreply@openai.com> Co-authored-by: maria-rcks <maria@kuuro.net>

Victor Vogel committed Oct 29, 2026 at 13:00 UTC de386ada9ec392d52c2f5eed85c88f70475e6b57
2 files changed +87 -16
apps/web/src/components/settings/ScheduledTasksSettings.browser.test.tsx
+68 -11
@@ -1,3 +1,5 @@
1 +import { RegistryContext } from "@effect/atom-react";
2 +import { Atom, AtomRegistry } from "effect/reactivity";
3 import {
4 DEFAULT_UNIFIED_SETTINGS,
5 EnvironmentId,
@@ -10,7 +12,7 @@ import { describe, expect, it, vi } from "vite-plus/test";
12 import { page, userEvent } from "vite-plus/test/browser";
13
14 import "~/index.css";
13 -import { render } from "../../../test/render";
15 +import { act, render } from "../../../test/render";
16 import { ScheduledTasksSettings } from "./ScheduledTasksSettings";
17
18 const environmentId = EnvironmentId.make("laptop");
@@ -38,7 +40,23 @@ const task: ScheduledTask = {
40 runCount: 0,
41 };
42
41 -const state = vi.hoisted(() => ({ connected: true, tasksLoaded: true }));
43 +const state = vi.hoisted(() => ({ connected: true, tasksLoaded: true, secondary: false }));
44 +const secondaryId = EnvironmentId.make("secondary");
45 +const permissions = new Map<string, Atom.Writable<boolean>>();
46 +
47 +function setup() {
48 + state.connected = true;
49 + state.tasksLoaded = true;
50 + state.secondary = false;
51 + permissions.clear();
52 + permissions.set(environmentId, Atom.make(true));
53 + permissions.set(secondaryId, Atom.make(true));
54 + permissions.set("", Atom.make(false));
55 +}
56 +
57 +function secondaryEnvironment() {
58 + return { ...environment(), environmentId: secondaryId, label: "Secondary" };
59 +}
60
61 function environment() {
62 return {
@@ -54,8 +72,12 @@ vi.mock(import("./SettingsScopeContext"), async (original) => {
72 const entry = environment();
73 return {
74 scope: { kind: "all", label: "All", members: [], environmentIds: [environmentId] },
57 - environments: [entry],
58 - connectedEnvironments: state.connected ? [entry] : [],
75 + environments: state.secondary ? [entry, secondaryEnvironment()] : [entry],
76 + connectedEnvironments: state.connected
77 + ? state.secondary
78 + ? [entry, secondaryEnvironment()]
79 + : [entry]
80 + : [],
81 environment: entry,
82 target: null,
83 targets: [],
@@ -68,15 +90,14 @@ vi.mock(import("./SettingsScopeContext"), async (original) => {
90 });
91 vi.mock(import("../../state/server"), async (original) => {
92 const actual = await original();
71 - const { Atom } = await import("effect/reactivity");
72 - const allowed = Atom.make(true);
93 +
94 return {
95 ...actual,
96 serverEnvironment: {
97 ...actual.serverEnvironment,
98 upsertScheduledTask: {
99 ...actual.serverEnvironment.upsertScheduledTask,
79 - permissionAtom: () => allowed,
100 + permissionAtom: (id: string | null) => permissions.get(id ?? "")!,
101 },
102 },
103 };
@@ -93,7 +114,8 @@ vi.mock(import("../../state/query"), async (original) => ({
114 }));
115 vi.mock(import("../../state/environments"), async (original) => ({
116 ...(await original()),
96 - useEnvironment: (() => environment()) as never,
117 + useEnvironment: ((id: EnvironmentId) =>
118 + id === secondaryId ? secondaryEnvironment() : environment()) as never,
119 }));
120 vi.mock(import("../../state/entities"), async (original) => ({
121 ...(await original()),
@@ -105,9 +127,44 @@ vi.mock(import("../../hooks/useSettings"), async (original) => ({
127 }));
128
129 describe("ScheduledTasksSettings", () => {
130 + it("creates on a permitted secondary and reacts to permission changes", async () => {
131 + setup();
132 + state.secondary = true;
133 + const registry = AtomRegistry.make();
134 + using _registry = { [Symbol.dispose]: () => registry.dispose() };
135 + registry.set(permissions.get(environmentId)!, false);
136 + await using screen = await render(
137 + <RegistryContext.Provider value={registry}>
138 + <ScheduledTasksSettings />
139 + </RegistryContext.Provider>,
140 + );
141 + const create = screen.getByRole("button", { name: "New task" });
142 + await expect.element(create).toBeEnabled();
143 + await act(() => registry.set(permissions.get(secondaryId)!, false));
144 + await expect.element(create).toBeDisabled();
145 + await act(() => registry.set(permissions.get(secondaryId)!, true));
146 + await expect.element(create).toBeEnabled();
147 + await create.click();
148 + await expect.element(page.getByLabelText("Runs on")).toHaveTextContent("Secondary");
149 + });
150 +
151 + it("keeps the permitted representative as the creation target", async () => {
152 + setup();
153 + state.secondary = true;
154 + await using screen = await render(<ScheduledTasksSettings />);
155 + await screen.getByRole("button", { name: "New task" }).click();
156 + await expect.element(page.getByLabelText("Runs on")).toHaveTextContent("Laptop");
157 + });
158 +
159 + it("disables creation without a connected target", async () => {
160 + setup();
161 + state.connected = false;
162 + await using screen = await render(<ScheduledTasksSettings />);
163 + await expect.element(screen.getByRole("button", { name: "New task" })).toBeDisabled();
164 + });
165 +
166 it("keeps a linked task's unsaved edits across a disconnect and reconnect", async () => {
109 - state.connected = true;
110 - state.tasksLoaded = true;
167 + setup();
168 await using screen = await render(<ScheduledTasksSettings taskId={task.id} />);
169 const name = page.getByRole("dialog").getByRole("textbox", { name: "Name" });
170 await expect.element(name).toHaveValue("Review issues");
@@ -124,7 +181,7 @@ describe("ScheduledTasksSettings", () => {
181 });
182
183 it("keeps an editor the user opened when the linked task loads later", async () => {
127 - state.connected = true;
184 + setup();
185 state.tasksLoaded = false;
186 await using screen = await render(<ScheduledTasksSettings taskId={task.id} />);
187 await userEvent.click(page.getByRole("button", { name: "New task" }));
apps/web/src/components/settings/ScheduledTasksSettings.tsx
+19 -5
@@ -396,9 +396,18 @@ export function ScheduledTasksSettings(target: {
396 replace: true,
397 });
398 };
399 - const canCreate = useAtomValue(
400 - serverEnvironment.upsertScheduledTask.permissionAtom(defaultEnvironment?.environmentId ?? null),
399 + const createPermissions = useAtomValue(
400 + scheduledTaskCreatePermissionsAtom(
401 + environmentIdsKey(connectedEnvironments.map((entry) => entry.environmentId)),
402 + ),
403 );
404 + const permittedEnvironments = connectedEnvironments.filter(
405 + (_entry, index) => createPermissions[index],
406 + );
407 + const creationEnvironment =
408 + permittedEnvironments.find(
409 + (entry) => entry.environmentId === defaultEnvironment?.environmentId,
410 + ) ?? permittedEnvironments[0];
411 return (
412 <SettingsPageContainer>
413 <SettingsSection
@@ -408,10 +417,10 @@ export function ScheduledTasksSettings(target: {
417 <Button
418 size="xs"
419 variant="ghost-muted"
411 - disabled={!defaultEnvironment || !canCreate}
420 + disabled={!creationEnvironment}
421 onClick={() =>
413 - defaultEnvironment &&
414 - setEditor({ environmentId: defaultEnvironment.environmentId, task: null })
422 + creationEnvironment &&
423 + setEditor({ environmentId: creationEnvironment.environmentId, task: null })
424 }
425 >
426 <PlusIcon className="size-3" />
@@ -464,6 +473,11 @@ export function ScheduledTasksSettings(target: {
473 );
474 }
475
476 +const scheduledTaskCreatePermissionsAtom = environmentAtomList(
477 + "web-scheduled-task-create-permissions",
478 + serverEnvironment.upsertScheduledTask.permissionAtom,
479 +);
480 +
481 const scheduledTasksListAtom = environmentAtomList("web-scheduled-tasks-list", (environmentId) =>
482 serverEnvironment.scheduledTasksLive({ environmentId, input: {} }),
483 );