The best way to control Claude Code, Codex and more from any computer or phone
Mirrored from https://github.com/Camo67/t3code.git
Synced Nov 22, 14:30 UTC
perf(web): stop measuring table cells while replies stream (#26152)
Theo Browne committed
Oct 27, 2026 at 15:56 UTC
e66ffccf49d3fce14d93ce2f4eb068f11a73b2c7
1 file changed
+18
-68
apps/web/src/components/chat/MarkdownTable.tsx
+18
-68
@@ -3,7 +3,6 @@ import { useRef, useState, type ComponentProps } from "react";
3
4
import { useCopyToClipboard } from "../../hooks/useCopyToClipboard";
5
import { getClientSettings } from "../../hooks/useSettings";
6
-import { observeResize } from "../../lib/observeResize";
6
import {
7
serializeTableElementToCsv,
8
serializeTableElementToMarkdown,
@@ -15,35 +14,9 @@ import { ScrollArea } from "../ui/scroll-area";
14
import { Tooltip, TooltipPopup, TooltipTrigger } from "../ui/tooltip";
15
import { reportMarkdownActionFailure } from "./markdownActionFailure";
16
18
-/**
19
- * Whether any cell is clipped in the unwrapped layout. Only then does the wrap
20
- * toggle change anything, so short tables hide it. Measures with the container
21
- * briefly unwrapped and restores it before the browser paints.
22
- */
23
-function tableHasClippedCells(container: HTMLElement, table: HTMLTableElement): boolean {
24
- const viewport = table.closest<HTMLElement>('[data-slot="scroll-area-viewport"]');
25
- const scrollLeft = viewport?.scrollLeft ?? 0;
26
- const previous = container.dataset.expanded;
27
- container.dataset.expanded = "false";
28
- try {
29
- for (const row of table.rows) {
30
- for (const cell of row.cells) {
31
- if (cell.scrollWidth > cell.clientWidth) return true;
32
- }
33
- }
34
- return false;
35
- } finally {
36
- if (previous === undefined) delete container.dataset.expanded;
37
- else container.dataset.expanded = previous;
38
- // The unwrapped layout can be narrower and clamp a sideways scroll.
39
- if (viewport && scrollLeft > 0) viewport.scrollLeft = scrollLeft;
40
- }
41
-}
42
-
17
export function MarkdownTable({ children, ...props }: ComponentProps<"table">) {
18
const containerRef = useRef<HTMLDivElement | null>(null);
19
const [expanded, setExpanded] = useState(() => getClientSettings().wordWrap);
46
- const [hasClippedCells, setHasClippedCells] = useState(false);
20
const { copyToClipboard, isCopied: copied } = useCopyToClipboard<"markdown" | "csv">({
21
timeout: 1200,
22
onError: (cause, format) =>
@@ -52,25 +25,6 @@ export function MarkdownTable({ children, ...props }: ComponentProps<"table">) {
25
const expandLabel = expanded ? "Collapse table cells" : "Expand table cells";
26
const copyLabel = copied ? "Copied" : "Copy table";
27
55
- // React calls this with null when a previous attach returned no cleanup.
56
- const attachContainer = (container: HTMLDivElement | null) => {
57
- containerRef.current = container;
58
- const table = container?.querySelector("table");
59
- if (!container || !table) return;
60
- const measure = () => setHasClippedCells(tableHasClippedCells(container, table));
61
- measure();
62
- // A streamed cell can grow until it clips while the table keeps its size, and a
63
- // narrower column can clip a cell without this component rendering.
64
- const mutations = new MutationObserver(measure);
65
- mutations.observe(table, { childList: true, characterData: true, subtree: true });
66
- const stopResize = observeResize(table, measure);
67
- return () => {
68
- mutations.disconnect();
69
- stopResize();
70
- containerRef.current = null;
71
- };
72
- };
73
-
28
const handleCopy = (format: "markdown" | "csv") => {
29
const table = containerRef.current?.querySelector("table");
30
if (!table) return;
@@ -84,7 +38,7 @@ export function MarkdownTable({ children, ...props }: ComponentProps<"table">) {
38
39
return (
40
<div
87
- ref={attachContainer}
41
+ ref={containerRef}
42
className="chat-markdown-table-container"
43
data-expanded={expanded ? "true" : "false"}
44
>
@@ -93,27 +47,23 @@ export function MarkdownTable({ children, ...props }: ComponentProps<"table">) {
47
</ScrollArea>
48
{/* Stays within the row's px-1: the chat lane clips sideways overflow. */}
49
<div className="mt-0.5 -mx-1 flex items-center justify-between select-none">
96
- {hasClippedCells ? (
97
- <Tooltip>
98
- <TooltipTrigger
99
- render={
100
- <Button
101
- type="button"
102
- variant={expanded ? "secondary" : "ghost-muted"}
103
- size="icon-xs"
104
- aria-pressed={expanded}
105
- onClick={() => setExpanded((value) => !value)}
106
- aria-label={expandLabel}
107
- />
108
- }
109
- >
110
- <MorphIcon className="size-3" icon={expanded ? Minimize2 : Maximize2} />
111
- </TooltipTrigger>
112
- <TooltipPopup side="top">{expandLabel}</TooltipPopup>
113
- </Tooltip>
114
- ) : (
115
- <span />
116
- )}
50
+ <Tooltip>
51
+ <TooltipTrigger
52
+ render={
53
+ <Button
54
+ type="button"
55
+ variant={expanded ? "secondary" : "ghost-muted"}
56
+ size="icon-xs"
57
+ aria-pressed={expanded}
58
+ onClick={() => setExpanded((value) => !value)}
59
+ aria-label={expandLabel}
60
+ />
61
+ }
62
+ >
63
+ <MorphIcon className="size-3" icon={expanded ? Minimize2 : Maximize2} />
64
+ </TooltipTrigger>
65
+ <TooltipPopup side="top">{expandLabel}</TooltipPopup>
66
+ </Tooltip>
67
<Menu>
68
<Tooltip>
69
<TooltipTrigger