@devries-cameron20 / t3code Mirror · read-only / commits / e9df5914d4
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 21, 22:15 UTC

fix(cursor): a completed catalog refresh drops models it no longer lists (#28018)

Julius Marminge committed Nov 11, 2026 at 15:23 UTC e9df5914d4e882ef30af9ba95ac508781184d2e2
2 files changed +47 -3
apps/server/src/provider/ProviderRegistry.test.ts
+41
@@ -773,6 +773,7 @@ it.layer(
773 } as const satisfies ServerProvider;
774 const refreshedProvider = {
775 ...previousProvider,
776 + status: "warning",
777 checkedAt: "2026-04-14T00:01:00.000Z",
778 models: [],
779 slashCommands: [],
@@ -918,6 +919,45 @@ it.layer(
919 );
920 });
921
922 + it("drops Cursor models a completed catalog read no longer returns", () => {
923 + const previousProvider = {
924 + instanceId: ProviderInstanceId.make("cursor"),
925 + driver: ProviderDriverKind.make("cursor"),
926 + status: "ready",
927 + enabled: true,
928 + installed: true,
929 + auth: { status: "authenticated" },
930 + checkedAt: "2026-10-30T00:00:00.000Z",
931 + version: "1.0.0",
932 + models: [
933 + { slug: "composer-2", name: "Composer 2", isCustom: false, capabilities: null },
934 + { slug: "retired-model-x", name: "Retired", isCustom: false, capabilities: null },
935 + ],
936 + slashCommands: [],
937 + skills: [],
938 + } as const satisfies ServerProvider;
939 + const refreshedProvider = {
940 + ...previousProvider,
941 + checkedAt: "2026-10-30T00:01:00.000Z",
942 + models: [previousProvider.models[0]],
943 + } satisfies ServerProvider;
944 + const failedProvider = {
945 + ...refreshedProvider,
946 + status: "error",
947 + auth: { status: "unknown" },
948 + message: "Cursor SDK model discovery timed out.",
949 + } satisfies ServerProvider;
950 +
951 + assert.deepStrictEqual(
952 + ProviderRegistry.mergeProviderSnapshot(previousProvider, refreshedProvider).models,
953 + [previousProvider.models[0]],
954 + );
955 + assert.deepStrictEqual(
956 + ProviderRegistry.mergeProviderSnapshot(previousProvider, failedProvider).models,
957 + [...previousProvider.models],
958 + );
959 + });
960 +
961 it("retains stale OpenCode models when a refresh fails", () => {
962 const previousProvider = {
963 instanceId: ProviderInstanceId.make("opencode"),
@@ -2338,6 +2378,7 @@ it.layer(
2378 } as const satisfies ServerProvider;
2379 const refreshedProvider = {
2380 ...initialProvider,
2381 + status: "warning",
2382 checkedAt: "2026-04-14T00:01:00.000Z",
2383 models: [],
2384 } satisfies ServerProvider;
apps/server/src/provider/ProviderRegistry.ts
+6 -3
@@ -195,9 +195,12 @@ const shouldRetainMissingProviderModels = (provider: ServerProvider): boolean =>
195 );
196 }
197
198 - if (provider.driver === ProviderDriverKind.make("grok")) {
199 - // Grok reports ready only after it discovers a model list; the pending,
200 - // ACP-failed, empty-inventory, and logged-out probes are warning/error.
198 + if (
199 + provider.driver === ProviderDriverKind.make("grok") ||
200 + provider.driver === ProviderDriverKind.make("cursor")
201 + ) {
202 + // Grok and Cursor report ready only after they discover a model list; the pending,
203 + // failed, empty-inventory, and logged-out probes are warning/error.
204 return !(provider.installed && provider.status === "ready");
205 }
206