@devries-cameron20 / t3code Mirror · read-only / commits / ebd007e6ae
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 21, 09:45 UTC

fix(web): View instructions closes the skill details popover (#37900)

Jackson Miller committed Nov 16, 2026 at 23:43 UTC ebd007e6aeb3984412689346a80cb47ebeac1f19
2 files changed +8 -3
apps/web/src/components/ChatMarkdown.browser.test.tsx
+2 -1
@@ -529,7 +529,7 @@ describe("ChatMarkdown workspace file opens", () => {
529 });
530
531 describe("ChatMarkdown skill chips", () => {
532 - it("shows the skill's details and opens its instructions", async () => {
532 + it("shows the skill's details and opens its instructions, closing the details", async () => {
533 setup();
534 const threadRef = {
535 environmentId: EnvironmentId.make("workspace"),
@@ -556,6 +556,7 @@ describe("ChatMarkdown skill chips", () => {
556 await userEvent.click(page.getByRole("button", { name: "View instructions" }));
557
558 expect(openFile).toHaveBeenCalledExactlyOnceWith(threadRef, "/skills/review/SKILL.md");
559 + await expect.element(page.getByText("Reviews the current branch.")).not.toBeInTheDocument();
560 });
561
562 it("names a mentioned model as its provider does, without a thread", async () => {
apps/web/src/components/chat/SkillInlineText.tsx
+6 -2
@@ -8,6 +8,7 @@ import { useRightPanelStore } from "~/rightPanelStore";
8 import { SKILL_CHIP_ICON_SVG } from "../composerInlineChip";
9 import { ContextChipPopover } from "../contextChipParts";
10 import { Button } from "../ui/button";
11 +import { PopoverClose } from "../ui/popover";
12 import { ModelMentionChip } from "./ModelMentionChip";
13
14 function SkillInlineText(props: {
@@ -135,9 +136,12 @@ export function SkillChipPopover(props: {
136 <p className="font-medium">{props.label}</p>
137 <p>{props.description || "No description is available for this skill."}</p>
138 {props.onViewInstructions ? (
138 - <Button variant="outline" size="sm" onClick={props.onViewInstructions}>
139 + <PopoverClose
140 + render={<Button variant="outline" size="sm" />}
141 + onClick={props.onViewInstructions}
142 + >
143 View instructions
140 - </Button>
144 + </PopoverClose>
145 ) : null}
146 </div>
147 </ContextChipPopover>