@devries-cameron20 / t3code Mirror · read-only / commits / eee8ed4f23
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 22, 05:45 UTC

fix(server): server updates reclaim partial database backups left by killed updates (#29464)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

MarcoDotIO committed Nov 3, 2026 at 18:12 UTC eee8ed4f23b47379554da7d63f79542442bda537
2 files changed +43
apps/server/src/serviceLauncher.test.ts
+31
@@ -1,5 +1,7 @@
1 // @effect-diagnostics-next-line nodeBuiltinImport:off - observes the children the launcher spawns with Node built-ins.
2 import type * as NodeChildProcess from "node:child_process";
3 +// @effect-diagnostics-next-line nodeBuiltinImport:off - the free-space probe is a plain Promise callback.
4 +import * as NodeFS from "node:fs";
5
6 import * as NodeServices from "@effect/platform-node/NodeServices";
7 import { assert, it } from "@effect/vitest";
@@ -618,6 +620,35 @@ setInterval(() => {}, 1_000);
620 }),
621 );
622
623 + it.effect("reclaims partial backups left by killed updates before checking space", () =>
624 + Effect.gen(function* () {
625 + const fs = yield* FileSystem.FileSystem;
626 + const path = yield* Path.Path;
627 + const root = yield* fs.makeTempDirectoryScoped({ prefix: "t3-service-launcher-orphan-" });
628 + const databasePath = path.join(root, "state.sqlite");
629 + yield* writeSparseFile(databasePath, 10 * 1024 ** 3);
630 + const backupRoot = path.join(root, "runtime", "db-backup");
631 + const orphan = path.join(backupRoot, "earlier-update.staging");
632 + const completed = path.join(backupRoot, "completed-update");
633 + yield* fs.makeDirectory(orphan, { recursive: true });
634 + yield* fs.writeFileString(path.join(orphan, "database"), "partial copy");
635 + yield* fs.makeDirectory(completed);
636 + yield* fs.writeFileString(path.join(completed, "database"), "complete copy");
637 +
638 + // The orphan is what keeps this disk too full for a full copy.
639 + const blocker = yield* Effect.promise(() =>
640 + databaseBackupBlocker(root, databasePath, {
641 + readFreeBytes: () => Promise.resolve((NodeFS.existsSync(orphan) ? 8 : 11) * 1024 ** 3),
642 + canClone: () => Promise.resolve(false),
643 + }),
644 + );
645 +
646 + assert.isUndefined(blocker);
647 + assert.isFalse(yield* fs.exists(orphan));
648 + assert.isTrue(yield* fs.exists(path.join(completed, "database")));
649 + }),
650 + );
651 +
652 it.effect("checks database backup space against clone or full-copy needs", () =>
653 Effect.gen(function* () {
654 const fs = yield* FileSystem.FileSystem;
apps/server/src/serviceLauncher.ts
+12
@@ -219,6 +219,17 @@ const filesystemBackupSpaceProbe: BackupSpaceProbe = {
219 canClone: backupCanClone,
220 };
221
222 +// A killed launcher skips the backup's cleanup, and retries only clear their own update's copy.
223 +// Update requests are refused while one is pending, so no staging directory is still in use here.
224 +async function removeAbandonedBackupCopies(backupRoot: string): Promise<void> {
225 + for (const entry of await NodeFSP.readdir(backupRoot)) {
226 + if (!entry.endsWith(".staging")) continue;
227 + await NodeFSP.rm(NodePath.join(backupRoot, entry), { recursive: true, force: true }).catch(
228 + () => undefined,
229 + );
230 + }
231 +}
232 +
233 /** Check before stopping the server so full disks refuse updates without an outage. */
234 export async function databaseBackupBlocker(
235 baseDir: string,
@@ -228,6 +239,7 @@ export async function databaseBackupBlocker(
239 const { readFreeBytes, canClone } = { ...filesystemBackupSpaceProbe, ...probe };
240 const backupRoot = NodePath.join(baseDir, "runtime", "db-backup");
241 await NodeFSP.mkdir(backupRoot, { recursive: true, mode: 0o700 });
242 + await removeAbandonedBackupCopies(backupRoot);
243 const [files, free] = await Promise.all([statDatabaseFiles(dbPath), readFreeBytes(backupRoot)]);
244 const size = files.reduce((total, file) => total + file.size, 0);
245 const fullCopyBytes = size * 1.05;