The best way to control Claude Code, Codex and more from any computer or phone
Mirrored from https://github.com/Camo67/t3code.git
Synced Nov 21, 22:15 UTC
perf(server): trace database reclamation once per pass (#32923)
Co-authored-by: GPT-6.1 Sol <noreply@openai.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Etan Heyman committed
Nov 12, 2026 at 01:06 UTC
f1d402009a0ce7a236a163e341c84b7b2d25ef36
2 files changed
+39
-14
apps/server/src/persistence/DatabaseStorage.test.ts
+20
-2
@@ -7,6 +7,7 @@ import * as Layer from "effect/Layer";
7
import * as Path from "effect/Path";
8
import * as Option from "effect/Option";
9
import * as Stream from "effect/Stream";
10
+import * as Tracer from "effect/Tracer";
11
import * as TestClock from "effect/testing/TestClock";
12
import * as SqlClient from "effect/sql/SqlClient";
13
@@ -44,9 +45,26 @@ it.effect("a new database returns freed pages online without losing data", () =>
45
yield* sql`CREATE TABLE retained (value TEXT)`;
46
yield* sql`INSERT INTO retained VALUES ('keep')`;
47
yield* sql`CREATE TABLE discarded (value BLOB)`;
47
- yield* sql`INSERT INTO discarded VALUES (zeroblob(1048576))`;
48
+ yield* sql`INSERT INTO discarded VALUES (zeroblob(6291456))`;
49
yield* sql`DROP TABLE discarded`;
49
- assert.isAbove(yield* freePages, 0);
50
+ const before = yield* freePages;
51
+ assert.isAbove(before, 1024);
52
+ const spans: Array<Tracer.NativeSpan> = [];
53
+ const tracer = Tracer.make({
54
+ span(options) {
55
+ const span = new Tracer.NativeSpan(options);
56
+ spans.push(span);
57
+ return span;
58
+ },
59
+ });
60
+ yield* storage.reclaim.pipe(Effect.withTracer(tracer), Effect.withTracerEnabled(true));
61
+ assert.equal(before - (yield* freePages), 1024);
62
+ assert.lengthOf(spans, 1);
63
+ assert.deepEqual(
64
+ spans.map((span) => span.name),
65
+ ["DatabaseStorage.reclaim"],
66
+ );
67
+ assert.equal(spans[0]?.attributes.get("db.reclaimed_pages"), 1024);
68
yield* storage.reclaim;
69
assert.equal(yield* freePages, 0);
70
assert.deepEqual(yield* sql`SELECT value FROM retained`, [{ value: "keep" }]);
apps/server/src/persistence/DatabaseStorage.ts
+19
-12
@@ -117,18 +117,25 @@ const make = Effect.gen(function* () {
117
Effect.catch((cause) => Effect.logWarning("Database storage inspection failed", { cause })),
118
);
119
120
- const reclaim = Effect.gen(function* () {
121
- if (!(yield* readLayout).incrementalVacuum) return;
122
- // The driver steps once per statement; incremental_vacuum frees one page per step. Yield between pages.
123
- for (let page = 0; page < RECLAIM_PAGES_PER_PASS; page++) {
124
- const free = yield* sql<{ readonly freelist_count: number }>`PRAGMA freelist_count`;
125
- if ((free[0]?.freelist_count ?? 0) === 0) break;
126
- yield* sql`PRAGMA incremental_vacuum(1)`;
127
- yield* Effect.yieldNow;
128
- }
129
- }).pipe(
130
- Effect.catch((cause) => Effect.logWarning("Database space reclamation failed", { cause })),
131
- );
120
+ const reclaim = Effect.suspend(() => {
121
+ let page = 0;
122
+ return Effect.gen(function* () {
123
+ if (!(yield* readLayout).incrementalVacuum) return;
124
+ // The driver steps once per statement; incremental_vacuum frees one page per step. Yield between pages.
125
+ for (; page < RECLAIM_PAGES_PER_PASS; page++) {
126
+ const free = yield* sql<{ readonly freelist_count: number }>`PRAGMA freelist_count`;
127
+ if ((free[0]?.freelist_count ?? 0) === 0) break;
128
+ yield* sql`PRAGMA incremental_vacuum(1)`;
129
+ yield* Effect.yieldNow;
130
+ }
131
+ }).pipe(
132
+ Effect.ensuring(Effect.suspend(() => Effect.annotateCurrentSpan("db.reclaimed_pages", page))),
133
+ Effect.catch((cause) => Effect.logWarning("Database space reclamation failed", { cause })),
134
+ // The pass owns the span; tracing each page's two PRAGMAs floods the server trace.
135
+ Effect.withTracerEnabled(false),
136
+ Effect.withSpan("DatabaseStorage.reclaim"),
137
+ );
138
+ });
139
140
// Even a pass that deletes nothing scans the event store. Persist completion
141
// so restarting does not trigger another scan before the six-hour interval.