The best way to control Claude Code, Codex and more from any computer or phone
Mirrored from https://github.com/Camo67/t3code.git
Synced Nov 21, 14:45 UTC
fix(contracts): a null model selection options value is treated as omitted (#29149)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Jex committed
Nov 14, 2026 at 20:06 UTC
f4e65cd843b33fa2f4fd624d6ec976d37878856f
2 files changed
+15
-1
packages/contracts/src/modelSelection.test.ts
+14
@@ -32,6 +32,20 @@ it.effect("ModelSelection prefers explicit instanceId over legacy provider", ()
32
}),
33
);
34
35
+it.effect("ModelSelection treats null options as omitted", () =>
36
+ Effect.gen(function* () {
37
+ const parsed = yield* decodeModelSelection({
38
+ instanceId: "codex",
39
+ model: "gpt-5",
40
+ options: null,
41
+ });
42
+ assert.deepStrictEqual(parsed, {
43
+ instanceId: ProviderInstanceId.make("codex"),
44
+ model: "gpt-5",
45
+ });
46
+ }),
47
+);
48
+
49
it.effect(
50
"ModelSelection decodes unknown driver kinds via legacy provider (rollback / fork invariant)",
51
() =>
packages/contracts/src/modelSelection.ts
+1
-1
@@ -34,7 +34,7 @@ export const ModelSelection = ModelSelectionSource.pipe(
34
instanceId: instanceIdSource,
35
model: raw.model,
36
};
37
- if (raw.options !== undefined) base.options = raw.options;
37
+ if (raw.options !== undefined && raw.options !== null) base.options = raw.options;
38
return Effect.succeed(base as typeof ModelSelectionWire.Encoded);
39
},
40
encode: (value) => {