The best way to control Claude Code, Codex and more from any computer or phone
Mirrored from https://github.com/Camo67/t3code.git
Synced Nov 21, 23:30 UTC
fix(web): Office previews say "1 page", "1 sheet", "1 slide" and "1 row" (#31868)
spoukyii committed
Nov 11, 2026 at 11:18 UTC
f5fe0790e78127372eb746d6513e46f68302ddb7
5 files changed
+10
-7
apps/web/src/components/files/AttachmentFilePreview.browser.test.tsx
+1
-1
@@ -2762,7 +2762,7 @@ it.each(["rtf", "epub", "ods"] as const)(
2762
expect(screen.container.textContent).toContain("North");
2763
expect(screen.container.textContent).toContain("150");
2764
expect(screen.container.textContent).not.toContain("private note");
2765
- expect(screen.container.textContent).toContain("1 rows · 2 columns");
2765
+ expect(screen.container.textContent).toContain("1 row · 2 columns");
2766
expect(screen.container.textContent).not.toContain("Limited to 500");
2767
} else {
2768
const frame = screen.container.querySelector("iframe");
apps/web/src/components/files/OfficeViewer.tsx
+3
-2
@@ -250,8 +250,9 @@ function ExtendedOfficeViewer(props: {
250
className="flex min-h-10 shrink-0 flex-wrap items-center gap-x-1 border-b border-border/60 px-3 py-2 text-xs text-muted-foreground tabular-nums"
251
role="status"
252
>
253
- Sheet {page + 1} of {count} · {sheet.rowCount.toLocaleString()} rows ·{" "}
254
- {sheet.columns.toLocaleString()} columns
253
+ Sheet {page + 1} of {count} · {sheet.rowCount.toLocaleString()} row
254
+ {sheet.rowCount === 1 ? "" : "s"} · {sheet.columns.toLocaleString()} column
255
+ {sheet.columns === 1 ? "" : "s"}
256
{fileSize !== undefined
257
? ` · ${fileSize === 0 ? "0 bytes" : formatAttachmentSize(fileSize)}`
258
: ""}
apps/web/src/components/files/office/Presentation.tsx
+1
-1
@@ -83,7 +83,7 @@ export default function Presentation(props: {
83
if (slides.length === 0 || slides.length > 500)
84
throw new Error("Preview limited to presentations with 1 to 500 slides.");
85
setOpened({ slides, paint });
86
- onDetails(`${slides.length} slides`);
86
+ onDetails(`${slides.length} slide${slides.length === 1 ? "" : "s"}`);
87
})
88
.catch(fail);
89
return () => {
apps/web/src/components/files/office/Spreadsheet.tsx
+1
-1
@@ -70,7 +70,7 @@ export default function Spreadsheet(props: {
70
.then((value) => {
71
if (!value) throw new Error("This workbook has no visible sheets.");
72
setOpened({ ...value, engine });
73
- onDetails(`${value.tabs.length} sheets`);
73
+ onDetails(`${value.tabs.length} sheet${value.tabs.length === 1 ? "" : "s"}`);
74
})
75
.catch(fail);
76
return () => {
apps/web/src/components/files/office/WordDocument.tsx
+4
-2
@@ -63,7 +63,9 @@ export default function WordDocument(props: {
63
.then(async (first) => {
64
if (controller.signal.aborted) return;
65
setOpened({ pages: first.pages, paint, engine });
66
- onDetails(`${first.pages.length}${first.loading ? "+" : ""} pages`);
66
+ onDetails(
67
+ `${first.pages.length}${first.loading ? "+" : ""} page${first.pages.length === 1 && !first.loading ? "" : "s"}`,
68
+ );
69
if (!first.loading) return;
70
await new Promise((resolve) => requestAnimationFrame(() => requestAnimationFrame(resolve)));
71
while (!controller.signal.aborted) {
@@ -71,7 +73,7 @@ export default function WordDocument(props: {
73
if (!step.done) continue;
74
if (step.pages.length > 1000) throw new Error("Preview limited to 1,000 pages.");
75
setOpened({ pages: step.pages, paint, engine });
74
- onDetails(`${step.pages.length} pages`);
76
+ onDetails(`${step.pages.length} page${step.pages.length === 1 ? "" : "s"}`);
77
break;
78
}
79
})