@devries-cameron20 / t3code Mirror · read-only / commits / f7a1bacd27
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 21, 12:15 UTC

fix(web): subagent status dots no longer jump between corners (#30753)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: maria-rcks <maria@kuuro.net>

mark committed Nov 15, 2026 at 13:18 UTC f7a1bacd2769b3f05721702d2617327da1ce2f8f
4 files changed +35 -6
apps/web/src/components/chat/ThreadRelationshipIcon.tsx
+10 -3
@@ -1,7 +1,11 @@
1 import type { ProviderDriverKind, ServerProvider } from "@t3tools/contracts";
2 import { BotIcon, type LucideIcon } from "lucide-react";
3 import { cn } from "../../lib/utils";
4 -import { shouldShowInstanceBadge, type ProviderInstanceEntry } from "../../providerInstances";
4 +import {
5 + hasInstanceBadge,
6 + shouldShowInstanceBadge,
7 + type ProviderInstanceEntry,
8 +} from "../../providerInstances";
9 import { ProviderInstanceIcon } from "./ProviderInstanceIcon";
10
11 export function threadRelationshipStatusLabel(status: string | null): string {
@@ -47,12 +51,15 @@ export function ThreadRelationshipIcon({
51 driver,
52 provider,
53 providerEntries = [],
54 + anyInstanceBadge = hasInstanceBadge(providerEntries),
55 status,
56 fallbackIcon: FallbackIcon = BotIcon,
57 }: {
58 driver?: ProviderDriverKind | undefined;
59 provider?: ServerProvider | undefined;
60 providerEntries?: ReadonlyArray<ProviderInstanceEntry>;
61 + /** For rows that can't take `providerEntries` but sit in the same list as rows that do. */
62 + anyInstanceBadge?: boolean;
63 status: string | null;
64 fallbackIcon?: LucideIcon;
65 }) {
@@ -80,8 +87,8 @@ export function ThreadRelationshipIcon({
87 )}
88 <span
89 className={cn(
83 - "absolute size-2 rounded-full border-2 border-card",
84 - showInstanceBadge ? "-left-1 -top-1" : "-bottom-1 -right-1",
90 + "absolute -right-1 size-2 rounded-full border-2 border-card",
91 + anyInstanceBadge ? "-top-1" : "-bottom-1",
92 status === "running" ||
93 status === "in_progress" ||
94 status === "pending" ||
apps/web/src/components/chat/ThreadRelationshipsControl.tsx
+11 -1
@@ -73,6 +73,7 @@ import { serverEnvironment } from "../../state/server";
73 import {
74 applyProviderInstanceSettings,
75 deriveProviderInstanceEntries,
76 + hasInstanceBadge,
77 } from "../../providerInstances";
78 import { threadEnvironment } from "../../state/threads";
79 import { orchestrationEnvironment, threadTitlesRead } from "../../state/orchestration";
@@ -263,6 +264,7 @@ function currentSubagent<Agent extends RuntimeSubagent>(
264 function RemoteSubagentRow(props: {
265 readonly agent: RemoteSubagent;
266 readonly provider: ServerProvider | undefined;
267 + readonly anyInstanceBadge: boolean;
268 }) {
269 const navigate = useNavigate();
270 const environment = useEnvironment(props.agent.remoteChild.environmentId);
@@ -300,6 +302,7 @@ function RemoteSubagentRow(props: {
302 // The task's own driver here is only a "remote" label.
303 driver={props.provider?.driver}
304 provider={props.provider}
305 + anyInstanceBadge={props.anyInstanceBadge}
306 fallbackIcon={BotIcon}
307 status={status}
308 />
@@ -337,6 +340,7 @@ function RemoteSubagentRow(props: {
340 function DelegatedFromRow(props: {
341 readonly delegatedFrom: OrchestrationV2DelegatedFrom;
342 readonly fallbackLabel: string | undefined;
343 + readonly anyInstanceBadge: boolean;
344 }) {
345 const navigate = useNavigate();
346 const router = useRouter();
@@ -394,7 +398,11 @@ function DelegatedFromRow(props: {
398 />
399 }
400 >
397 - <ThreadRelationshipIcon fallbackIcon={CornerLeftUpIcon} status={null} />
401 + <ThreadRelationshipIcon
402 + anyInstanceBadge={props.anyInstanceBadge}
403 + fallbackIcon={CornerLeftUpIcon}
404 + status={null}
405 + />
406 <span className="min-w-0 flex-1">
407 <span className="block truncate text-left text-sm font-medium leading-4 text-foreground/85">
408 {title}
@@ -1014,6 +1022,7 @@ export function ThreadRelationshipsPanel(props: {
1022 <DelegatedFromRow
1023 delegatedFrom={delegatedFrom}
1024 fallbackLabel={currentThread?.linkOrigin?.label}
1025 + anyInstanceBadge={hasInstanceBadge(providerEntries)}
1026 />
1027 </ThreadLineageRowList>
1028 )}
@@ -1029,6 +1038,7 @@ export function ThreadRelationshipsPanel(props: {
1038 provider={providersByEnvironment
1039 .get(row.remote.remoteChild.environmentId)
1040 ?.find((entry) => entry.instanceId === row.remote.providerInstanceId)}
1041 + anyInstanceBadge={hasInstanceBadge(providerEntries)}
1042 />
1043 ) : (
1044 renderRelationshipRow(row)
apps/web/src/components/chat/V2LifecycleRow.tsx
+9 -2
@@ -56,6 +56,7 @@ import {
56 applyProviderInstanceSettings,
57 brandProviderInstanceEntries,
58 deriveProviderInstanceEntries,
59 + hasInstanceBadge,
60 shouldShowInstanceBadge,
61 type ProviderInstanceEntry,
62 } from "../../providerInstances";
@@ -210,6 +211,7 @@ function SubagentAvatar({
211 iconUrl,
212 accentColor,
213 showBadge,
214 + anyInstanceBadge,
215 status,
216 className,
217 }: {
@@ -218,6 +220,7 @@ function SubagentAvatar({
220 iconUrl?: string | undefined;
221 accentColor?: string | undefined;
222 showBadge: boolean;
223 + anyInstanceBadge: boolean;
224 status?: OrchestrationV2TurnItem["status"] | undefined;
225 className?: string;
226 }) {
@@ -246,8 +249,8 @@ function SubagentAvatar({
249 {status ? (
250 <span
251 className={cn(
249 - "absolute size-2 rounded-full ring-2 ring-background",
250 - showBadge ? "-left-px -top-px" : "-right-px -bottom-px",
252 + "absolute -right-px size-2 rounded-full ring-2 ring-background",
253 + anyInstanceBadge ? "-top-px" : "-bottom-px",
254 subagentStatusVisual(status).dotClass,
255 )}
256 />
@@ -298,6 +301,9 @@ export function EnvironmentSubagentAvatar({
301 const entry = all.find((candidate) => candidate.instanceId === providerInstanceId);
302 return entry !== undefined && shouldShowInstanceBadge(entry, all);
303 });
304 + const anyInstanceBadge = useAtomValue(providersAtom, (providers) =>
305 + hasInstanceBadge(entries(providers)),
306 + );
307 const iconUrl = useAtomValue(
308 providersAtom,
309 (providers) =>
@@ -311,6 +317,7 @@ export function EnvironmentSubagentAvatar({
317 iconUrl={iconUrl}
318 accentColor={accentColor}
319 showBadge={showBadge}
320 + anyInstanceBadge={anyInstanceBadge}
321 />
322 );
323 }
apps/web/src/providerInstances.ts
+5
@@ -43,6 +43,11 @@ export interface ProviderInstanceEntry {
43 readonly models: ReadonlyArray<ServerProviderModel>;
44 }
45
46 +/** Status dots share one corner per user, so a badge on one row can't move only that row's dot. */
47 +export function hasInstanceBadge(entries: ReadonlyArray<ProviderInstanceEntry>): boolean {
48 + return entries.some((entry) => shouldShowInstanceBadge(entry, entries));
49 +}
50 +
51 /** Disabled instances may retain ready status until reconciliation. */
52 export function isProviderInstancePickerReady(entry: ProviderInstanceEntry): boolean {
53 return entry.enabled && entry.isAvailable && entry.status === "ready";