@devries-cameron20 / t3code Mirror · read-only / commits / f86e21f7cc
Fork 0

The best way to control Claude Code, Codex and more from any computer or phone

Mirrored from https://github.com/Camo67/t3code.git

Synced Nov 22, 00:45 UTC

fix(web,mobile): replace sparkles icons and ban them with a lint rule (#25422)

oliver committed Nov 10, 2026 at 12:46 UTC f86e21f7cce7324119dadf61064965d83c539455
16 files changed +148 -32
apps/mobile/src/components/ui/AppSymbol.android.tsx
+19 -5
@@ -64,6 +64,7 @@ import IconFileText from "@tabler/icons-react-native/IconFileText";
64 import IconFileDiff from "@tabler/icons-react-native/IconFileDiff";
65 import IconFilter from "@tabler/icons-react-native/IconFilter";
66 import IconFilterFilled from "@tabler/icons-react-native/IconFilterFilled";
67 +import IconFlask from "@tabler/icons-react-native/IconFlask";
68 import IconFolder from "@tabler/icons-react-native/IconFolder";
69 import IconFolderOpen from "@tabler/icons-react-native/IconFolderOpen";
70 import IconHeadphones from "@tabler/icons-react-native/IconHeadphones";
@@ -90,6 +91,7 @@ import IconListNumbers from "@tabler/icons-react-native/IconListNumbers";
91 import IconMenu2 from "@tabler/icons-react-native/IconMenu2";
92 import IconMessageCircleQuestion from "@tabler/icons-react-native/IconMessageCircleQuestion";
93 import IconMessage from "@tabler/icons-react-native/IconMessage";
94 +import IconMessageDots from "@tabler/icons-react-native/IconMessageDots";
95 import IconMessagePlus from "@tabler/icons-react-native/IconMessagePlus";
96 import IconMinus from "@tabler/icons-react-native/IconMinus";
97 import IconMoon from "@tabler/icons-react-native/IconMoon";
@@ -106,11 +108,11 @@ import IconPlayerStopFilled from "@tabler/icons-react-native/IconPlayerStopFille
108 import IconPlus from "@tabler/icons-react-native/IconPlus";
109 import IconQrcode from "@tabler/icons-react-native/IconQrcode";
110 import IconRefresh from "@tabler/icons-react-native/IconRefresh";
111 +import IconRobot from "@tabler/icons-react-native/IconRobot";
112 import IconSearch from "@tabler/icons-react-native/IconSearch";
113 import IconShare from "@tabler/icons-react-native/IconShare";
114 import IconServer from "@tabler/icons-react-native/IconServer";
115 import IconSettings from "@tabler/icons-react-native/IconSettings";
113 -import IconSparkles from "@tabler/icons-react-native/IconSparkles";
116 import IconStack2 from "@tabler/icons-react-native/IconStack2";
117 import IconStar from "@tabler/icons-react-native/IconStar";
118 import IconStarFilled from "@tabler/icons-react-native/IconStarFilled";
@@ -209,6 +211,7 @@ const ANDROID_ICON_BY_SF_SYMBOL = {
211 "exclamationmark.circle": IconAlertCircle,
212 eye: IconEye,
213 "eye.slash": IconEyeOff,
214 + flask: IconFlask,
215 folder: IconFolder,
216 "folder.badge.plus": IconFolderPlus,
217 "folder.fill": IconFolder,
@@ -275,8 +278,9 @@ const ANDROID_ICON_BY_SF_SYMBOL = {
278 "exclamationmark.shield": IconShieldQuestion,
279 "bubble.left.and.bubble.right": IconMessage,
280 "bubble.left": IconMessage,
278 - sparkles: IconSparkles,
281 "plus.bubble": IconMessagePlus,
282 + "ellipsis.bubble": IconMessageDots,
283 + robot: IconRobot,
284 "text.word.spacing": IconLetterSpacing,
285 "textformat.size": IconTypography,
286 "textformat.size.larger": IconTextIncrease,
@@ -286,23 +290,33 @@ const ANDROID_ICON_BY_SF_SYMBOL = {
290 trash: IconTrash,
291 wifi: IconWifi,
292 "wifi.slash": IconWifiOff,
293 + "wrench.and.screwdriver": IconTool,
294 xmark: IconX,
295 "xmark.circle.fill": IconCircleXFilled,
296 } satisfies Partial<
297 Record<
293 - SFSymbol | "git.pull-request.closed" | "git.pull-request.draft" | "git.commit" | "file.diff",
298 + | SFSymbol
299 + | "git.pull-request.closed"
300 + | "git.pull-request.draft"
301 + | "git.commit"
302 + | "file.diff"
303 + | "robot",
304 Icon
305 >
306 >;
307 const SF_ICON_LOOKUP: Partial<
308 Record<
299 - SFSymbol | "git.pull-request.closed" | "git.pull-request.draft" | "git.commit" | "file.diff",
309 + | SFSymbol
310 + | "git.pull-request.closed"
311 + | "git.pull-request.draft"
312 + | "git.commit"
313 + | "file.diff"
314 + | "robot",
315 Icon
316 >
317 > = ANDROID_ICON_BY_SF_SYMBOL;
318
319 const ANDROID_ICON_BY_MATERIAL_NAME = {
305 - auto_awesome: IconSparkles,
320 bolt: IconBolt,
321 build: IconTool,
322 chat: IconMessage,
apps/mobile/src/components/ui/AppSymbol.tsx
+2
@@ -6,6 +6,7 @@ import IconGitPullRequestDraft from "@tabler/icons-react-native/IconGitPullReque
6 import type { SFSymbol } from "expo-symbols";
7 import IconGitPullRequest from "@tabler/icons-react-native/IconGitPullRequest";
8 import IconFileDiff from "@tabler/icons-react-native/IconFileDiff";
9 +import IconRobot from "@tabler/icons-react-native/IconRobot";
10 import { SymbolView as ExpoSymbolView } from "expo-symbols";
11 import { withUniwind } from "uniwind";
12 import type { AppSymbolViewProps } from "./AppSymbol.android";
@@ -22,6 +23,7 @@ const CUSTOM_ICONS = {
23 "git.pull-request.closed": IconGitPullRequestClosed,
24 "git.pull-request.draft": IconGitPullRequestDraft,
25 "git.commit": IconGitCommit,
26 + robot: IconRobot,
27 };
28
29 function AppSymbolView(props: AppSymbolViewProps) {
apps/mobile/src/features/pull-requests/PullRequestAgentRow.tsx
+1 -1
@@ -17,7 +17,7 @@ export function PullRequestAgentRow(props: {
17 const row = (
18 <PullRequestCardRow
19 title={props.title ?? action.title}
20 - icon="sparkles"
20 + icon="hammer"
21 accessibilityLabel={props.title ?? action.title}
22 menu={agent.chooseThread && !action.attributes.disabled}
23 onPress={
apps/mobile/src/features/pull-requests/PullRequestControls.tsx
+2 -2
@@ -166,7 +166,7 @@ export function PullRequestActionToolbar(props: {
166 >
167 <View pointerEvents="none">
168 <IconButton
169 - icon="sparkles"
169 + icon="ellipsis.bubble"
170 accessibilityLabel={`${shortLabel} agent actions`}
171 disabled={agent.disabled}
172 />
@@ -237,7 +237,7 @@ export function PullRequestActionToolbar(props: {
237 const agentControl = showAgentControls ? (
238 <Toolbar.Menu
239 identifier="pull-request-agent"
240 - icon="sparkles"
240 + icon="ellipsis.bubble"
241 title="AI helpers"
242 accessibilityLabel={`${shortLabel} agent actions`}
243 disabled={agent.disabled}
apps/mobile/src/features/settings/SettingsRouteScreen.tsx
+1 -1
@@ -274,7 +274,7 @@ function useSettingsIndexSections(): SettingsListSection[] {
274 {
275 rows: [
276 serverPage("SettingsEnvironmentMaintenance", "arrow.clockwise", "Maintenance"),
277 - page("SettingsLabs", "sparkles", "Labs"),
277 + page("SettingsLabs", "flask", "Labs"),
278 page("SettingsAbout", "info.circle", "About"),
279 page("SettingsArchive", "archivebox", "Archive"),
280 ],
apps/mobile/src/features/threads/ThreadFeed.tsx
+1 -9
@@ -1103,21 +1103,13 @@ function ArtifactTemplateCard(props: {
1103 }) {
1104 return (
1105 <View className="my-2 min-w-0 flex-row items-center gap-3 rounded-2xl border border-border bg-card px-3 py-3">
1106 - <View className="relative h-10 w-10 shrink-0 items-center justify-center rounded-xl border border-border bg-subtle">
1106 + <View className="h-10 w-10 shrink-0 items-center justify-center rounded-xl border border-border bg-subtle">
1107 <SymbolView
1108 name={ARTIFACT_TEMPLATE_SYMBOL_BY_KIND[props.template.artifactKind]}
1109 size={20}
1110 tintColorClassName="accent-foreground-muted"
1111 type="monochrome"
1112 />
1113 - <View className="absolute -right-1 -bottom-1 h-4 w-4 items-center justify-center rounded-full bg-fuchsia-500">
1114 - <SymbolView
1115 - name={{ ios: "sparkles", android: "auto_awesome" }}
1116 - size={9}
1117 - tintColor="white"
1118 - type="monochrome"
1119 - />
1120 - </View>
1113 </View>
1114 <View className="min-w-0 flex-1">
1115 <Text className="font-t3-bold text-sm text-foreground" numberOfLines={1}>
apps/mobile/src/features/threads/thread-subagent-group.tsx
+1 -1
@@ -90,7 +90,7 @@ function SubagentAvatar(props: {
90 showBadge
91 />
92 ) : driver === undefined ? (
93 - <SymbolView name="sparkles" size={13} tintColorClassName="accent-icon-muted" />
93 + <SymbolView name="robot" size={13} tintColorClassName="accent-icon-muted" />
94 ) : (
95 <ProviderIcon provider={driver} iconUrl={provider?.iconUrl} size={15} />
96 )}
apps/mobile/src/features/threads/thread-work-log.tsx
+2 -2
@@ -379,7 +379,7 @@ export function ShimmeringWorkContent(props: {
379 function workRowSymbolName(icon: ThreadFeedActivity["icon"]): WorkContentIcon {
380 switch (icon) {
381 case "agent":
382 - return { ios: "sparkles", android: "auto_awesome" };
382 + return "robot";
383 case "alert":
384 return { ios: "exclamationmark.triangle", android: "error" };
385 case "browser":
@@ -1573,7 +1573,7 @@ function toolGroupSummarySymbolName(kind: ToolGroupSummaryKind): AppSymbolName {
1573 case "reasoning":
1574 return { ios: "brain", android: "psychology" };
1575 case "agent-tool":
1576 - return { ios: "sparkles", android: "auto_awesome" };
1576 + return "robot";
1577 case "tone-tool":
1578 return { ios: "bolt", android: "bolt" };
1579 case "dynamic-tool":
apps/web/src/components/ChatMarkdown.tsx
+1 -5
@@ -37,7 +37,6 @@ import {
37 MessageSquareWarningIcon,
38 OctagonAlertIcon,
39 PresentationIcon,
40 - SparklesIcon,
40 TriangleAlertIcon,
41 type LucideIcon,
42 } from "lucide-react";
@@ -294,11 +293,8 @@ function CodexArtifactTemplateCard(props: {
293 data-skill-name={props.template.skillName}
294 >
295 <div className="flex min-w-0 flex-1 items-center gap-3">
297 - <span className="relative flex size-9 shrink-0 items-center justify-center rounded-lg border border-border/70 bg-background text-muted-foreground shadow-xs">
296 + <span className="flex size-9 shrink-0 items-center justify-center rounded-lg border border-border/70 bg-background text-muted-foreground shadow-xs">
297 <Icon aria-hidden className="size-5" />
299 - <span className="absolute -right-1 -bottom-1 flex size-4 items-center justify-center rounded-full border border-background bg-primary text-primary-foreground shadow-xs">
300 - <SparklesIcon aria-hidden className="size-2.5" />
301 - </span>
298 </span>
299 <div className="min-w-0">
300 <div className="truncate text-sm font-medium text-foreground">
apps/web/src/components/chat/runtimeModeConfig.ts
+8 -2
@@ -3,7 +3,13 @@ import {
3 type ManagedPolicySummary,
4 type RuntimeMode,
5 } from "@t3tools/contracts";
6 -import { type LucideIcon, LockIcon, PenLineIcon, ShieldOffIcon, SparklesIcon } from "lucide-react";
6 +import {
7 + type LucideIcon,
8 + LockIcon,
9 + PenLineIcon,
10 + ShieldCheckIcon,
11 + ShieldOffIcon,
12 +} from "lucide-react";
13
14 export const runtimeModeConfig: Record<
15 RuntimeMode,
@@ -22,7 +28,7 @@ export const runtimeModeConfig: Record<
28 auto: {
29 label: "Auto",
30 description: "Supported providers approve routine actions; others still ask.",
25 - icon: SparklesIcon,
31 + icon: ShieldCheckIcon,
32 },
33 "full-access": {
34 label: "Full access",
apps/web/src/components/pullRequest/PullRequestActionsMenu.tsx
+2 -2
@@ -23,7 +23,7 @@ import {
23 MessageCircleQuestionIcon,
24 MoreHorizontalIcon,
25 RotateCcwIcon,
26 - SparklesIcon,
26 + ScrollTextIcon,
27 Trash2Icon,
28 } from "lucide-react";
29 import { useId, useState } from "react";
@@ -272,7 +272,7 @@ export function PullRequestActionsMenu({
272 </MenuItem>
273 {canWriteGuide ? (
274 <MenuItem disabled={guideRunning} onClick={writeGuide}>
275 - <SparklesIcon className="size-3.5" />
275 + <ScrollTextIcon className="size-3.5" />
276 {guideRunning ? "Writing guide..." : !guideWritten ? "Write guide" : "Rewrite guide"}
277 </MenuItem>
278 ) : null}
apps/web/src/components/pullRequest/PullRequestGuideTab.tsx
+2 -2
@@ -1,5 +1,5 @@
1 import type { EnvironmentId, PullRequestRef, PullRequestReviewGuideStop } from "@t3tools/contracts";
2 -import { SparklesIcon, TriangleAlertIcon } from "lucide-react";
2 +import { ScrollTextIcon, TriangleAlertIcon } from "lucide-react";
3 import { useEffect, useEffectEvent } from "react";
4
5 import type { ReviewCommentContext } from "~/reviewCommentContext";
@@ -94,7 +94,7 @@ export function PullRequestGuideTab({
94 const writeButton = (label: string, size: "sm" | "xs") =>
95 canWrite ? (
96 <Button size={size} variant="outline" disabled={running} onClick={() => void write()}>
97 - {running ? <Spinner /> : <SparklesIcon aria-hidden className="size-3.5" />}
97 + {running ? <Spinner /> : <ScrollTextIcon aria-hidden className="size-3.5" />}
98 {running ? "Reading the change..." : label}
99 </Button>
100 ) : null;
oxlint-plugin-t3code/index.ts
+2
@@ -16,6 +16,7 @@ import noMobileUniwindThemeEscapeHatches from "./rules/no-mobile-uniwind-theme-e
16 import noAmbiguousDetailNavigation from "./rules/no-ambiguous-detail-navigation.ts";
17 import noMobilePullRequestGlyphLiterals from "./rules/no-mobile-pull-request-glyph-literals.ts";
18 import noNativeTitleTooltip from "./rules/no-native-title-tooltip.ts";
19 +import noSparklesIcon from "./rules/no-sparkles-icon.ts";
20 import noUnreasonedStateSync from "./rules/no-unreasoned-state-sync.ts";
21 import requireRegisteredListScroll from "./rules/require-registered-list-scroll.ts";
22 import noOutsetStateIndicators from "./rules/no-outset-state-indicators.ts";
@@ -55,6 +56,7 @@ export default definePlugin({
56 "no-ambiguous-detail-navigation": noAmbiguousDetailNavigation,
57 "no-mobile-pull-request-glyph-literals": noMobilePullRequestGlyphLiterals,
58 "no-native-title-tooltip": noNativeTitleTooltip,
59 + "no-sparkles-icon": noSparklesIcon,
60 "no-unreasoned-state-sync": noUnreasonedStateSync,
61 "require-registered-list-scroll": requireRegisteredListScroll,
62 "no-outset-state-indicators": noOutsetStateIndicators,
oxlint-plugin-t3code/rules/no-sparkles-icon.test.ts new
+48
@@ -0,0 +1,48 @@
1 +import { describe } from "@effect/vitest";
2 +
3 +import { createOxlintRuleHarness } from "../test/utils.ts";
4 +
5 +const rule = createOxlintRuleHarness("t3code/no-sparkles-icon", {
6 + filename: "apps/web/src/components/chat/Example.tsx",
7 +});
8 +
9 +describe("t3code/no-sparkles-icon", () => {
10 + rule.valid(
11 + "allows icons that name the action",
12 + `
13 + import { BotIcon, ShieldCheckIcon } from "lucide-react";
14 + import IconRobot from "@tabler/icons-react-native/IconRobot";
15 +
16 + const icon = <SymbolView name={{ ios: "puzzlepiece", android: "extension" }} />;
17 + `,
18 + );
19 +
20 + rule.valid(
21 + "allows copy and identifiers that mention sparkles",
22 + `
23 + const NIGHTLY_SPARKLES = [];
24 + const label = "Add some sparkles to the release notes";
25 + `,
26 + );
27 +
28 + rule.invalid("reports Lucide sparkles icons", `import { SparklesIcon } from "lucide-react";`);
29 +
30 + rule.invalid(
31 + "reports every Lucide sparkle variant",
32 + `import { Sparkle, WandSparklesIcon, LucideSparkles } from "lucide-react";`,
33 + );
34 +
35 + rule.invalid("reports Lucide icon nodes", `import { Sparkles } from "lucide";`);
36 +
37 + rule.invalid(
38 + "reports Tabler sparkles deep imports",
39 + `import IconSparkles from "@tabler/icons-react-native/IconSparkles";`,
40 + );
41 +
42 + rule.invalid("reports SF Symbol sparkles names", `const icon = <SymbolView name="sparkles" />;`);
43 +
44 + rule.invalid(
45 + "reports platform symbol objects",
46 + `const icon = { ios: "wand.and.sparkles", android: "auto_awesome" };`,
47 + );
48 +});
oxlint-plugin-t3code/rules/no-sparkles-icon.ts new
+50
@@ -0,0 +1,50 @@
1 +import { defineRule } from "@oxlint/plugins";
2 +
3 +const SPARKLE_NAME = /sparkle/iu;
4 +// SF Symbol (`sparkles`, `sparkles.square.filled.on.square`, `wand.and.sparkles`) and
5 +// Material (`auto_awesome`) names reach native icons as plain strings.
6 +const SPARKLE_SYMBOL_NAME = /^(?:(?:[\w]+\.)*sparkles?(?:\.[\w.]+)?|auto_awesome(?:_\w+)?)$/u;
7 +const TABLER_SOURCE = /^@tabler\/icons(?:-react|-react-native)?(?:\/|$)/u;
8 +
9 +const MESSAGE =
10 + "Sparkles says 'AI', not what the control does. Pick an icon for the action itself, such as Bot for agent work or ShieldCheck for Auto mode.";
11 +
12 +export default defineRule({
13 + meta: {
14 + type: "problem",
15 + docs: {
16 + description:
17 + "Disallow sparkles icons; they label a control as AI instead of saying what it does.",
18 + },
19 + },
20 + create(context) {
21 + return {
22 + ImportDeclaration(node) {
23 + const source = node.source.value;
24 + if (source === "lucide" || source === "lucide-react" || TABLER_SOURCE.test(source)) {
25 + if (TABLER_SOURCE.test(source) && SPARKLE_NAME.test(source.split("/").at(-1) ?? "")) {
26 + context.report({ node: node.source, message: MESSAGE });
27 + return;
28 + }
29 + for (const specifier of node.specifiers) {
30 + if (specifier.type !== "ImportSpecifier") continue;
31 + const imported =
32 + specifier.imported.type === "Identifier"
33 + ? specifier.imported.name
34 + : specifier.imported.value;
35 + if (SPARKLE_NAME.test(imported)) context.report({ node: specifier, message: MESSAGE });
36 + }
37 + }
38 + },
39 + Literal(node) {
40 + if (typeof node.value !== "string" || !SPARKLE_SYMBOL_NAME.test(node.value)) return;
41 + if (node.parent.type === "ImportDeclaration") return;
42 + context.report({ node, message: MESSAGE });
43 + },
44 + TemplateElement(node) {
45 + if (!SPARKLE_SYMBOL_NAME.test(node.value.cooked ?? "")) return;
46 + context.report({ node, message: MESSAGE });
47 + },
48 + };
49 + },
50 +});
vite.config.ts
+6
@@ -319,6 +319,12 @@ export default defineConfig({
319 ],
320 rules: { "t3code/prefer-effect-fn": "off" },
321 },
322 + {
323 + files: ["apps/web/src/**", "apps/mobile/src/**", "apps/desktop/src/**"],
324 + // Users still pick their own project icon from the full Lucide set.
325 + excludeFiles: ["apps/web/src/projectIconOptions.ts"],
326 + rules: { "t3code/no-sparkles-icon": "error" },
327 + },
328 {
329 files: ["apps/web/**/*.test.{ts,tsx}"],
330 rules: { "t3code/require-disposable-render": "error" },