The best way to control Claude Code, Codex and more from any computer or phone
Mirrored from https://github.com/Camo67/t3code.git
Synced Nov 22, 12:00 UTC
fix(mobile): stop refreshes in hidden PR Guide panes (#25486)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: maria-rcks <maria@kuuro.net>
Alex Southwell committed
Oct 29, 2026 at 18:07 UTC
fa4f3a2925822201e6fe4f11db45c8649383e420
4 files changed
+137
-14
apps/mobile/src/features/pull-requests/PullRequestRouteScreen.tsx
+6
-1
@@ -794,7 +794,12 @@ export function PullRequestRouteScreen({ route }: StaticScreenProps<PullRequestP
794
</View>
795
</View>
796
) : null}
797
- {tab === "guide" ? <PullRequestGuideContent params={params} /> : null}
797
+ {tab === "guide" ? (
798
+ <PullRequestGuideContent
799
+ params={params}
800
+ visible={section === "guide"}
801
+ />
802
+ ) : null}
803
{tab === "activity" ? (
804
<PullRequestActivityFilters
805
value={activityFilter}
apps/mobile/src/features/pull-requests/guide/PullRequestGuideScreen.tsx
+8
-2
@@ -48,9 +48,15 @@ const attentionLabels = {
48
accessibility: "An accessibility call",
49
};
50
51
-export function PullRequestGuideContent({ params }: { readonly params: PullRequestParams }) {
51
+export function PullRequestGuideContent({
52
+ params,
53
+ visible = true,
54
+}: {
55
+ readonly params: PullRequestParams;
56
+ readonly visible?: boolean;
57
+}) {
58
const navigation = useNavigation();
53
- const state = useReviewGuide(params);
59
+ const state = useReviewGuide(params, visible);
60
const { guide, stale } = reviewGuideState(state.data);
61
return (
62
<Animated.View layout={PR_ROW_LAYOUT} className="w-full max-w-[760px] self-center">
apps/mobile/src/features/pull-requests/guide/useReviewGuide.test.tsx
+121
-9
@@ -3,18 +3,21 @@ import {
3
type NavigationProp,
4
type ParamListBase,
5
} from "@react-navigation/native";
6
-import { act } from "react";
6
+import { AsyncResult } from "effect/reactivity";
7
+import { act, useLayoutEffect } from "react";
8
import { createRoot } from "react-dom/client";
9
import { expect, it, vi } from "vite-plus/test";
10
11
const mocks = vi.hoisted(() => ({
12
+ enabled: true,
13
+ generate: vi.fn(),
14
query: {
12
- data: null as { run: { _tag: "Running" | "Completed" } } | null,
15
+ data: null as { run: { _tag: "Running" | "Completed" | "Failed" } | null } | null,
16
isPending: false,
17
refresh: vi.fn<() => void>(),
18
},
19
otherQuery: {
17
- data: null as { run: { _tag: "Running" | "Completed" } } | null,
20
+ data: null as { run: { _tag: "Running" | "Completed" | "Failed" } | null } | null,
21
isPending: false,
22
refresh: vi.fn<() => void>(),
23
},
@@ -33,7 +36,8 @@ vi.mock("@react-navigation/native", async () => {
36
return { NavigationContext, useFocusEffect };
37
});
38
vi.mock("@effect/atom-react", () => ({
36
- useAtomValue: (atom: unknown) => (atom === "settings" ? { reviewGuidesEnabled: true } : true),
39
+ useAtomValue: (atom: unknown) =>
40
+ atom === "settings" ? { reviewGuidesEnabled: mocks.enabled } : true,
41
}));
42
vi.mock("../../../state/server", () => ({
43
serverEnvironment: { settingsValueAtom: () => "settings" },
@@ -48,7 +52,7 @@ vi.mock("../../../state/pull-requests", () => ({
52
vi.mock("../../../state/query", () => ({
53
useEnvironmentQuery: (number: number) => ({ ...(number === 1 ? mocks.query : mocks.otherQuery) }),
54
}));
51
-vi.mock("../../../state/use-atom-command", () => ({ useAtomCommand: () => vi.fn() }));
55
+vi.mock("../../../state/use-atom-command", () => ({ useAtomCommand: () => mocks.generate }));
56
vi.mock("../usePullRequestConnected", () => ({ usePullRequestConnected: () => true }));
57
vi.mock("../usePullRequestDiff", () => ({
58
pullRequestTarget: (params: unknown) => params,
@@ -78,6 +82,8 @@ function createNavigation() {
82
83
function setup() {
84
(globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }).IS_REACT_ACT_ENVIRONMENT = true;
85
+ mocks.enabled = true;
86
+ mocks.generate = vi.fn().mockResolvedValue(AsyncResult.success(undefined));
87
mocks.query = { data: null, isPending: false, refresh: vi.fn() };
88
mocks.otherQuery = { data: null, isPending: false, refresh: vi.fn() };
89
const root = createRoot(document.createElement("div"));
@@ -88,20 +94,35 @@ function setup() {
94
repository: "repo",
95
number: 1,
96
};
91
- function Probe({ number, environmentId }: { number: number; environmentId: string }) {
92
- useReviewGuide({ ...params, number, environmentId });
97
+ let current: ReturnType<typeof useReviewGuide>;
98
+ function Probe({
99
+ number,
100
+ environmentId,
101
+ visible,
102
+ }: {
103
+ number: number;
104
+ environmentId: string;
105
+ visible?: boolean;
106
+ }) {
107
+ const state = useReviewGuide({ ...params, number, environmentId }, visible);
108
+ useLayoutEffect(() => {
109
+ current = state;
110
+ });
111
return null;
112
}
113
return {
96
- render(number = 1, environmentId = params.environmentId) {
114
+ render(number = 1, environmentId = params.environmentId, visible?: boolean) {
115
act(() =>
116
root.render(
117
<NavigationContext.Provider value={navigation.value}>
100
- <Probe number={number} environmentId={environmentId} />
118
+ <Probe number={number} environmentId={environmentId} visible={visible} />
119
</NavigationContext.Provider>,
120
),
121
);
122
},
123
+ get current() {
124
+ return current;
125
+ },
126
focus: navigation.focus,
127
[Symbol.dispose]() {
128
act(() => root.unmount());
@@ -188,3 +209,94 @@ it("retires the old environment's polling on target change and clears polling on
209
expect(mocks.otherQuery.refresh).toHaveBeenCalledTimes(2);
210
expect(vi.getTimerCount()).toBe(0);
211
});
212
+
213
+it("suspends only manual refresh while hidden, including focus and target changes", () => {
214
+ vi.useFakeTimers();
215
+ using _timers = { [Symbol.dispose]: () => vi.useRealTimers() };
216
+ {
217
+ using screen = setup();
218
+ mocks.query.data = { run: { _tag: "Running" } };
219
+ mocks.otherQuery.data = { run: { _tag: "Running" } };
220
+ screen.render();
221
+ const cached = screen.current.data;
222
+ screen.render(1, "environment", false);
223
+ act(() => vi.advanceTimersByTime(60_000));
224
+ expect(mocks.query.refresh).toHaveBeenCalledTimes(1);
225
+ expect(screen.current.data).toBe(cached);
226
+ screen.render();
227
+ expect(mocks.query.refresh).toHaveBeenCalledTimes(2);
228
+ act(() => vi.advanceTimersByTime(5_000));
229
+ expect(mocks.query.refresh).toHaveBeenCalledTimes(3);
230
+ screen.render(1, "environment", false);
231
+ screen.focus(false);
232
+ screen.focus(true);
233
+ expect(mocks.query.refresh).toHaveBeenCalledTimes(3);
234
+
235
+ screen.render(2, "other-environment", false);
236
+ act(() => vi.advanceTimersByTime(5_000));
237
+ expect(mocks.otherQuery.refresh).not.toHaveBeenCalled();
238
+ screen.focus(false);
239
+ screen.render(2, "other-environment", true);
240
+ expect(mocks.otherQuery.refresh).not.toHaveBeenCalled();
241
+ screen.focus(true);
242
+ expect(mocks.otherQuery.refresh).toHaveBeenCalledTimes(1);
243
+ act(() => vi.advanceTimersByTime(5_000));
244
+ expect(mocks.otherQuery.refresh).toHaveBeenCalledTimes(2);
245
+ expect(mocks.query.refresh).toHaveBeenCalledTimes(3);
246
+ }
247
+ expect(vi.getTimerCount()).toBe(0);
248
+});
249
+
250
+it("keeps disabled, completed and failed guides idle and refreshes once on reveal", () => {
251
+ vi.useFakeTimers();
252
+ using _timers = { [Symbol.dispose]: () => vi.useRealTimers() };
253
+ using screen = setup();
254
+ mocks.enabled = false;
255
+ screen.render();
256
+ act(() => vi.advanceTimersByTime(5_000));
257
+ expect(mocks.query.refresh).not.toHaveBeenCalled();
258
+ mocks.enabled = true;
259
+ mocks.query.data = { run: null };
260
+ screen.render();
261
+ expect(mocks.query.refresh).toHaveBeenCalledTimes(1);
262
+ act(() => vi.advanceTimersByTime(10_000));
263
+ expect(mocks.query.refresh).toHaveBeenCalledTimes(1);
264
+ screen.render(1, "environment", false);
265
+ mocks.query.data = { run: { _tag: "Failed" } };
266
+ screen.render(1, "environment", false);
267
+ expect(mocks.query.refresh).toHaveBeenCalledTimes(1);
268
+ screen.render();
269
+ expect(mocks.query.refresh).toHaveBeenCalledTimes(2);
270
+ act(() => vi.advanceTimersByTime(10_000));
271
+ expect(mocks.query.refresh).toHaveBeenCalledTimes(2);
272
+ expect(vi.getTimerCount()).toBe(0);
273
+});
274
+
275
+it("leaves generation running when hidden and accepts its completion without a refresh", async () => {
276
+ vi.useFakeTimers();
277
+ using _timers = { [Symbol.dispose]: () => vi.useRealTimers() };
278
+ using screen = setup();
279
+ const generated = Promise.withResolvers<ReturnType<typeof AsyncResult.success<void>>>();
280
+ mocks.generate.mockReturnValue(generated.promise);
281
+ screen.render();
282
+ let writing: Promise<void>;
283
+ act(() => {
284
+ writing = screen.current.write();
285
+ });
286
+ expect(screen.current.running).toBe(true);
287
+ screen.render(1, "environment", false);
288
+ const beforeHidden = mocks.query.refresh.mock.calls.length;
289
+ act(() => vi.advanceTimersByTime(60_000));
290
+ expect(mocks.query.refresh).toHaveBeenCalledTimes(beforeHidden);
291
+ expect(mocks.generate).toHaveBeenCalledTimes(1);
292
+ expect(screen.current.running).toBe(true);
293
+ await act(async () => {
294
+ generated.resolve(AsyncResult.success(undefined));
295
+ await writing;
296
+ });
297
+ expect(screen.current.running).toBe(false);
298
+ expect(mocks.query.refresh).toHaveBeenCalledTimes(beforeHidden);
299
+ screen.render();
300
+ expect(mocks.query.refresh).toHaveBeenCalledTimes(beforeHidden + 1);
301
+ expect(vi.getTimerCount()).toBe(0);
302
+});
apps/mobile/src/features/pull-requests/guide/useReviewGuide.ts
+2
-2
@@ -17,7 +17,7 @@ export function useReviewGuidesEnabled(params: PullRequestParams) {
17
return settings?.reviewGuidesEnabled === true;
18
}
19
20
-export function useReviewGuide(params: PullRequestParams) {
20
+export function useReviewGuide(params: PullRequestParams, visible = true) {
21
const target = pullRequestTarget(params);
22
const enabled = useReviewGuidesEnabled(params);
23
const query = useEnvironmentQuery(enabled ? composerPullRequests.reviewGuide(target) : null);
@@ -35,7 +35,7 @@ export function useReviewGuide(params: PullRequestParams) {
35
const running = starting || query.data?.run?._tag === "Running";
36
const refresh = query.refresh;
37
useFocusEffect(() => {
38
- if (!enabled) return;
38
+ if (!enabled || !visible) return;
39
refresh();
40
if (!running) return;
41
const timer = setInterval(refresh, 5_000);