The best way to control Claude Code, Codex and more from any computer or phone
Mirrored from https://github.com/Camo67/t3code.git
Synced Nov 21, 12:15 UTC
fix(server): agents can no longer delete the built-in No project through MCP (#33773)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Julius Marminge committed
Nov 14, 2026 at 20:58 UTC
ffd11ffc95c0de8c8870372e44308878fa45c856
3 files changed
+72
-18
apps/server/src/mcp/toolkits/project/handlers.test.ts
+60
-17
@@ -170,7 +170,10 @@ const clientLaunchHarness = (input: {
170
),
171
}),
172
Layer.mock(PeerForwarding.PeerForwarding)({}),
173
- Layer.mock(ManagedProjectFolders.ManagedProjectFolders)({ namedProjectsRoot: "/projects" }),
173
+ Layer.mock(ManagedProjectFolders.ManagedProjectFolders)({
174
+ namedProjectsRoot: "/projects",
175
+ isScratchProject: () => Effect.succeed(false),
176
+ }),
177
DocumentText.layer.pipe(Layer.provideMerge(NodeServices.layer)),
178
).pipe(
179
Layer.provideMerge(GitVcsDriver.layer),
@@ -886,6 +889,22 @@ it.effect("an agent's clone is not cut off while git is still transferring", ()
889
}).pipe(Effect.provide(NodeServices.layer)),
890
);
891
892
+const deletedProject = (id: ProjectId) => ({
893
+ id,
894
+ title: "client-target",
895
+ workspaceRoot: "/projects/client-target",
896
+ repositoryIdentity: null,
897
+ faviconPath: null,
898
+ defaultModelSelection: null,
899
+ defaultThreadEnvMode: null,
900
+ autoPull: false,
901
+ projectIcon: null,
902
+ scripts: [],
903
+ createdAt: "2026-01-01T00:00:00.000Z",
904
+ updatedAt: "2026-01-01T00:00:00.000Z",
905
+ deletedAt: "2026-01-01T00:00:00.000Z",
906
+});
907
+
908
it.effect("deleting a project through MCP also discards its clone record", () =>
909
Effect.gen(function* () {
910
const discarded: Array<ProjectId> = [];
@@ -894,22 +913,7 @@ it.effect("deleting a project through MCP also discards its clone record", () =>
913
harness.dependencies,
914
Layer.mergeAll(
915
Layer.mock(Project.ProjectService)({
897
- delete: (input) =>
898
- Effect.succeed({
899
- id: input.projectId,
900
- title: "client-target",
901
- workspaceRoot: "/projects/client-target",
902
- repositoryIdentity: null,
903
- faviconPath: null,
904
- defaultModelSelection: null,
905
- defaultThreadEnvMode: null,
906
- autoPull: false,
907
- projectIcon: null,
908
- scripts: [],
909
- createdAt: "2026-01-01T00:00:00.000Z",
910
- updatedAt: "2026-01-01T00:00:00.000Z",
911
- deletedAt: "2026-01-01T00:00:00.000Z",
912
- }),
916
+ delete: (input) => Effect.succeed(deletedProject(input.projectId)),
917
}),
918
Layer.mock(ProjectCloneTracker.ProjectCloneTracker)({
919
discard: (projectId) => Effect.sync(() => void discarded.push(projectId)),
@@ -930,6 +934,45 @@ it.effect("deleting a project through MCP also discards its clone record", () =>
934
}),
935
);
936
937
+it.effect("an agent cannot delete the built-in scratch project, even with force", () =>
938
+ Effect.gen(function* () {
939
+ const deleted: Array<ProjectId> = [];
940
+ const harness = clientLaunchHarness({ runtimeModeCeiling: "full-access", launched: [] });
941
+ const dependencies = Layer.merge(
942
+ harness.dependencies,
943
+ Layer.mergeAll(
944
+ Layer.mock(ManagedProjectFolders.ManagedProjectFolders)({
945
+ namedProjectsRoot: "/projects",
946
+ isScratchProject: (projectId) => Effect.succeed(projectId === harness.projectId),
947
+ }),
948
+ Layer.mock(Project.ProjectService)({
949
+ delete: (input) =>
950
+ Effect.sync(() => {
951
+ deleted.push(input.projectId);
952
+ return deletedProject(input.projectId);
953
+ }),
954
+ }),
955
+ Layer.mock(ProjectCloneTracker.ProjectCloneTracker)({ discard: () => Effect.void }),
956
+ ),
957
+ );
958
+ const toolkit = yield* ProjectToolkit.pipe(
959
+ Effect.provide(
960
+ McpToolAccess.HandlersLayer.layer(ProjectHandlers.layer).pipe(Layer.provide(dependencies)),
961
+ ),
962
+ );
963
+
964
+ const refused = yield* toolkit
965
+ .handle("t3_project_delete", { projectId: harness.projectId, force: true })
966
+ .pipe(Stream.unwrap, Stream.runCollect, Effect.provide(dependencies));
967
+
968
+ expect(deleted).toEqual([]);
969
+ expect(refused.at(-1)?.result).toMatchObject({
970
+ code: "invalid_request",
971
+ message: expect.stringMatching(/scratch|no project/i),
972
+ });
973
+ }),
974
+);
975
+
976
it.effect("an update the project refuses tells the agent why", () =>
977
Effect.gen(function* () {
978
const harness = clientLaunchHarness({ runtimeModeCeiling: "full-access", launched: [] });
apps/server/src/mcp/toolkits/project/handlers.ts
+7
@@ -406,6 +406,13 @@ export const layer = McpToolAccess.toLayer(ProjectToolkit, {
406
),
407
t3_project_delete: McpToolAccess.writesEnvironment((input) =>
408
Effect.gen(function* () {
409
+ const folders = yield* ManagedProjectFolders.ManagedProjectFolders;
410
+ if (yield* folders.isScratchProject(input.projectId))
411
+ return yield* new OrchestratorMcpFailure({
412
+ code: "invalid_request",
413
+ message:
414
+ '"No project" is the built-in scratch project and cannot be deleted through MCP. The user can remove it in Settings.',
415
+ });
416
const projects = yield* Project.ProjectService;
417
const clones = yield* ProjectCloneTracker.ProjectCloneTracker;
418
return yield* mutateProjectWithClone(projects, clones, {
apps/server/src/mcp/toolkits/project/tools.ts
+5
-1
@@ -104,7 +104,11 @@ const ProjectDeleteTool = Tool.make("t3_project_delete", {
104
projectId: ProjectId,
105
force: Schema.optionalKey(Schema.Boolean),
106
}),
107
- dependencies: [...shared.dependencies, ProjectCloneTracker.ProjectCloneTracker],
107
+ dependencies: [
108
+ ...shared.dependencies,
109
+ ProjectCloneTracker.ProjectCloneTracker,
110
+ ManagedProjectFolders.ManagedProjectFolders,
111
+ ],
112
}).annotate(Tool.Destructive, true);
113
const ProjectCloneTool = Tool.make("t3_project_clone", {
114
...shared,