Add warning for MSI transactions.
Sean Hall committed
Dec 2, 2020 at 12:09 UTC
3523c9d809b86737a18a6c43845cbd894c5e1a97
2 files changed
+7
-1
src/WixToolset.Data/WarningMessages.cs
+6
@@ -397,6 +397,11 @@ namespace WixToolset.Data
397
return Message(sourceLineNumbers, Ids.MissingUpgradeCode, "The Product/@UpgradeCode attribute was not found; it is strongly recommended to ensure that this product can be upgraded.");
398
}
399
400
+ public static Message MsiTransactionLimitations(SourceLineNumber sourceLineNumbers)
401
+ {
402
+ return Message(sourceLineNumbers, Ids.MsiTransactionLimitations, "MSI transactions have limitations that make it hard to use them successfully in a bundle. Test the bundle thoroughly, especially in upgrade scenarios and the scenario that required them in the first place.");
403
+ }
404
+
405
public static Message NestedInstall(SourceLineNumber sourceLineNumbers, string tableName, string columnName, Object value)
406
{
407
return Message(sourceLineNumbers, Ids.NestedInstall, "The {0}.{1} column's value, '{2}', indicates a nested install. Nested installations are not supported by the WiX team. This action will be left out of the decompiled output.", tableName, columnName, value);
@@ -780,6 +785,7 @@ namespace WixToolset.Data
785
VersionTruncated = 1148,
786
ServiceConfigFamilyNotSupported = 1149,
787
SymbolNotTranslatedToOutput = 1150,
788
+ MsiTransactionLimitations = 1151,
789
}
790
}
791
}
src/WixToolset.Data/WixToolset.Data.csproj
+1
-1
@@ -18,7 +18,7 @@
18
19
<ItemGroup>
20
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />
21
- <PackageReference Include="Nerdbank.GitVersioning" Version="3.1.91" PrivateAssets="all" />
21
+ <PackageReference Include="Nerdbank.GitVersioning" Version="3.3.37" PrivateAssets="all" />
22
</ItemGroup>
23
24
<ItemGroup>