@joebigelow / wix-1 / commits / d84ed736

Don't warn about missing netfx4 switches.

Fixes wixtoolset/issues#5390.

Bob Arnson committed Aug 18, 2019 at 19:11 UTC d84ed7360adec89569eaab3793e9723f38d2a855
1 file changed +2 -2
src/WixToolset.Core/Compiler_Bundle.cs
+2 -2
@@ -1989,12 +1989,12 @@ namespace WixToolset.Core
1989 this.Core.Write(WarningMessages.AttributeShouldContain(sourceLineNumbers, node.Name.LocalName, "InstallCommand", installCommand, expectedArgument, "Protocol", "netfx4"));
1990 }
1991
1992 - if (null == repairCommand || -1 == repairCommand.IndexOf(expectedArgument, StringComparison.OrdinalIgnoreCase))
1992 + if (!String.IsNullOrEmpty(repairCommand) && -1 == repairCommand.IndexOf(expectedArgument, StringComparison.OrdinalIgnoreCase))
1993 {
1994 this.Core.Write(WarningMessages.AttributeShouldContain(sourceLineNumbers, node.Name.LocalName, "RepairCommand", repairCommand, expectedArgument, "Protocol", "netfx4"));
1995 }
1996
1997 - if (null == uninstallCommand || -1 == uninstallCommand.IndexOf(expectedArgument, StringComparison.OrdinalIgnoreCase))
1997 + if (!String.IsNullOrEmpty(uninstallCommand) && -1 == uninstallCommand.IndexOf(expectedArgument, StringComparison.OrdinalIgnoreCase))
1998 {
1999 this.Core.Write(WarningMessages.AttributeShouldContain(sourceLineNumbers, node.Name.LocalName, "UninstallCommand", uninstallCommand, expectedArgument, "Protocol", "netfx4"));
2000 }