@joebigelow / wix-1 / commits / dc13aa67

Fix WixDependencyProvider in SymbolDefinitions.ByType and improve error message for unknown type (which should be unreachable but...).

Sean Hall committed Mar 8, 2021 at 15:44 UTC dc13aa675da9307e36e8ff84b9914aceee15593d

1 file changed +7 -4

src/WixToolset.Data/Symbols/SymbolDefinitions.cs

+7 -4

@@ -461,12 +461,12 @@ namespace WixToolset.Data

461 case SymbolDefinitionType.Property:

462 return SymbolDefinitions.Property;

463

464 - case SymbolDefinitionType.PublishComponent:

465 - return SymbolDefinitions.PublishComponent;

466 -

464 case SymbolDefinitionType.ProvidesDependency:

465 return SymbolDefinitions.ProvidesDependency;

466

467 + case SymbolDefinitionType.PublishComponent:

468 + return SymbolDefinitions.PublishComponent;

469 +

470 case SymbolDefinitionType.RadioButton:

471 return SymbolDefinitions.RadioButton;

472

@@ -674,6 +674,9 @@ namespace WixToolset.Data

674 case SymbolDefinitionType.WixDependencyRef:

675 return SymbolDefinitions.WixDependencyRef;

676

677 + case SymbolDefinitionType.WixDependencyProvider:

678 + return SymbolDefinitions.WixDependencyProvider;

679 +

680 case SymbolDefinitionType.WixEnsureTable:

681 return SymbolDefinitions.WixEnsureTable;

682

@@ -765,7 +768,7 @@ namespace WixToolset.Data

768 return SymbolDefinitions.WixVariable;

769

770 default:

768 - throw new ArgumentOutOfRangeException(nameof(type));

771 + throw new ArgumentOutOfRangeException($"{nameof(type)} ({type})");

772 }

773 }

774 }