@joebigelow / wix-1 / commits / eacaa879

Slightly larger buffer when inscribing bundle plus minor code cleanup

Rob Mensching committed Dec 13, 2022 at 14:08 UTC eacaa8794ba90b3df4ac344e96ec8da155d90d19
3 files changed +5 -5
src/wix/WixToolset.Core.Burn/Bundles/BurnCommon.cs
+1 -1
@@ -451,7 +451,7 @@ namespace WixToolset.Core.Burn.Bundles
451
452 internal struct ContainerSlot
453 {
454 - public ContainerSlot(uint size) : this()
454 + public ContainerSlot(uint size)
455 {
456 this.Size = size;
457 }
src/wix/WixToolset.Core.Burn/Bundles/BurnWriter.cs
+3 -3
@@ -135,13 +135,13 @@ namespace WixToolset.Core.Burn.Bundles
135 var nextAddress = this.EngineSize;
136 for (var i = 1; i < reader.AttachedContainers.Count; i++)
137 {
138 - var cntnr = reader.AttachedContainers[i];
138 + var slot = reader.AttachedContainers[i];
139
140 reader.Stream.Seek(nextAddress, SeekOrigin.Begin);
141 // TODO: verify that the size in the section data is 0 or the same size.
142 - this.AppendContainer(reader.Stream, cntnr.Size, BurnCommon.Container.Attached);
142 + this.AppendContainer(reader.Stream, slot.Size, BurnCommon.Container.Attached);
143
144 - nextAddress += cntnr.Size;
144 + nextAddress += slot.Size;
145 }
146
147 return true;
src/wix/WixToolset.Core.Burn/Inscribe/InscribeBundleEngineCommand.cs
+1 -1
@@ -37,7 +37,7 @@ namespace WixToolset.Core.Burn.Inscribe
37 {
38 reader.Stream.Seek(0, SeekOrigin.Begin);
39
40 - var buffer = new byte[4 * 1024];
40 + var buffer = new byte[8 * 1024];
41 var total = 0;
42 var read = 0;
43 do