Avoid hang when a .cab is has no files.
Bob Arnson committed
Mar 21, 2019 at 20:05 UTC
0fd0f531db8250a121939dc9d453a236b477ae7a
1 file changed
+5
-2
src/wixnative/smartcab.cpp
+5
-2
@@ -64,8 +64,11 @@ HRESULT SmartCabCommand(
64
hr = CabCBegin(wzCabName, sczCabDir, uiFileCount, uiMaxSize, uiMaxThresh, ct, &hCab);
65
ConsoleExitOnFailure(hr, CONSOLE_COLOR_RED, "failed to initialize cabinet: %ls", wzCabPath);
66
67
- hr = CompressFiles(hCab);
68
- ExitOnFailure(hr, "failed to compress files into cabinet: %ls", wzCabPath);
67
+ if (uiFileCount > 0)
68
+ {
69
+ hr = CompressFiles(hCab);
70
+ ExitOnFailure(hr, "failed to compress files into cabinet: %ls", wzCabPath);
71
+ }
72
73
hr = CabCFinish(hCab, CabNamesCallback);
74
hCab = NULL; // once finish is called, the handle is invalid.