@joebigelow / wix / commits / 191027c6

Fix missing symbol for WixSuppressAction.

Exposes non-overridable standard actions so WixToolsetTest.CoreIntegration.LinkerFixture.CanBuildWithOverridableActions now fails.

Bob Arnson committed Mar 20, 2019 at 12:48 UTC 191027c6fb6bf50d2d4825a7b3b9cd7bcfaea0cd
2 files changed +5 -1
src/WixToolset.Core/Compiler.cs
+1 -1
@@ -13445,7 +13445,7 @@ namespace WixToolset.Core
13445 {
13446 if (suppress)
13447 {
13448 - var row = this.Core.CreateRow(childSourceLineNumbers, TupleDefinitionType.WixSuppressAction);
13448 + var row = this.Core.CreateRow(childSourceLineNumbers, TupleDefinitionType.WixSuppressAction, new Identifier(AccessModifier.Public, sequenceTable, actionName));
13449 row.Set(0, sequenceTable);
13450 row.Set(1, actionName);
13451 }
src/test/WixToolsetTest.CoreIntegration/TestData/OverridableActions/Package.wxs
+4
@@ -7,6 +7,10 @@
7 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" />
8 <MediaTemplate />
9
10 + <InstallExecuteSequence>
11 + <ValidateProductID Suppress="yes" />
12 + </InstallExecuteSequence>
13 +
14 <Feature Id="ProductFeature" Title="!(loc.FeatureTitle)">
15 <ComponentGroupRef Id="ProductComponents" />
16 <ComponentGroupRef Id="Foo1" />