Add unit tests written during discovery of errors elsewhere because why not keep 'em?
Bob Arnson committed
Dec 11, 2019 at 19:08 UTC
3add0e56ddc57ddcfeb92c3b4cbb7ad0eee7674f
4 files changed
+6
-3
src/test/WixToolsetTest.CoreIntegration/MsiFixture.cs
+3
-3
@@ -277,9 +277,9 @@ namespace WixToolsetTest.CoreIntegration
277
var intermediate = Intermediate.Load(Path.Combine(baseFolder, @"bin\test.wixpdb"));
278
var section = intermediate.Sections.Single();
279
280
- var error = section.Tuples.OfType<ErrorTuple>().Single();
281
- Assert.Equal(1234, error.Error);
282
- Assert.Equal("Category 55 Emergency Doomsday Crisis", error.Message.Trim());
280
+ var errors = section.Tuples.OfType<ErrorTuple>().ToDictionary(t => t.Error);
281
+ Assert.Equal("Category 55 Emergency Doomsday Crisis", errors[1234].Message.Trim());
282
+ Assert.Equal(" ", errors[5678].Message);
283
}
284
}
285
src/test/WixToolsetTest.CoreIntegration/MsiQueryFixture.cs
+1
@@ -454,6 +454,7 @@ namespace WixToolsetTest.CoreIntegration
454
var results = Query.QueryDatabase(msiPath, new[] { "Environment" });
455
Assert.Equal(new[]
456
{
457
+ "Environment:PATH\t=-*PATH\t[INSTALLFOLDER]; ;[~]\tWixEnvironmentTest",
458
"Environment:WixEnvironmentTest1\t=-WixEnvTest1\t\tWixEnvironmentTest",
459
"Environment:WixEnvironmentTest2\t+-WixEnvTest1\t\tWixEnvironmentTest",
460
"Environment:WixEnvironmentTest3\t!-WixEnvTest1\t\tWixEnvironmentTest",
src/test/WixToolsetTest.CoreIntegration/TestData/Environment/Environment.wxs
+1
@@ -7,6 +7,7 @@
7
<Environment Id="WixEnvironmentTest2" Action="create" Name="WixEnvTest1"/>
8
<Environment Id="WixEnvironmentTest3" Action="remove" Name="WixEnvTest1"/>
9
<Environment Id="WixEnvironmentTest4" Name="WIX" Action="set" System="yes" Value="[INSTALLFOLDER]" />
10
+ <Environment Id="PATH" Name="PATH" Action="set" Part="first" Value="[INSTALLFOLDER]; " System="yes" />
11
</Component>
12
</ComponentGroup>
13
</Fragment>
src/test/WixToolsetTest.CoreIntegration/TestData/ErrorsInUI/PackageComponents.wxs
+1
@@ -5,6 +5,7 @@
5
<Error Id="1234">
6
Category 55 Emergency Doomsday Crisis
7
</Error>
8
+ <Error Id="5678"><![CDATA[ ]]></Error>
9
</UI>
10
<ComponentGroup Id="ProductComponents" Directory="INSTALLFOLDER">
11
<Component>