@joebigelow / wix / commits / 4673f280

Require inline directory collection when processing directories

This collection is required to handle anonymous ids efficiently.

Rob Mensching committed May 8, 2019 at 15:44 UTC 4673f2806a7869317ad0a8fa5915374ffcc6ab42
1 file changed +6 -3
src/WixToolset.Extensibility/Services/IParseHelper.cs
+6 -3
@@ -65,20 +65,23 @@ namespace WixToolset.Extensibility.Services
65 /// <param name="id">Optional identifier for the new row.</param>
66 /// <param name="parentId">Optional identifier for the parent row.</param>
67 /// <param name="name">Long name of the directory.</param>
68 + /// <param name="sectionInlinedDirectoryIds">Inline directory ids for the section.</param>
69 /// <param name="shortName">Optional short name of the directory.</param>
70 /// <param name="sourceName">Optional source name for the directory.</param>
71 /// <param name="shortSourceName">Optional short source name for the directory.</param>
72 /// <returns>Identifier for the newly created row.</returns>
72 - Identifier CreateDirectoryRow(IntermediateSection section, SourceLineNumber sourceLineNumbers, Identifier id, string parentId, string name, string shortName = null, string sourceName = null, string shortSourceName = null, ISet<string> sectionInlinedDirectoryIds = null);
73 + Identifier CreateDirectoryRow(IntermediateSection section, SourceLineNumber sourceLineNumbers, Identifier id, string parentId, string name, ISet<string> sectionInlinedDirectoryIds, string shortName = null, string sourceName = null, string shortSourceName = null);
74
75 /// <summary>
76 /// Creates directories using the inline directory syntax.
77 /// </summary>
78 + /// <param name="section">Section to add the new tuple to.</param>
79 /// <param name="sourceLineNumbers">Source line information.</param>
78 - /// <param name="attribute">The attribute to parse.</param>
80 /// <param name="parentId">Optional identifier of parent directory.</param>
81 + /// <param name="attribute">The attribute to parse.</param>
82 + /// <param name="sectionInlinedDirectoryIds">Inline directory ids for the section.</param>
83 /// <returns>Identifier of the leaf directory created.</returns>
81 - string CreateDirectoryReferenceFromInlineSyntax(IntermediateSection section, SourceLineNumber sourceLineNumbers, XAttribute attribute, string parentId);
84 + string CreateDirectoryReferenceFromInlineSyntax(IntermediateSection section, SourceLineNumber sourceLineNumbers, string parentId, XAttribute attribute, ISet<string> sectionInlinedDirectoryIds);
85
86 /// <summary>
87 /// Creates a Registry row in the active section.