Decompile null Message column in Error table.
Bob Arnson committed
Feb 27, 2024 at 18:17 UTC
b62127f2f458d15ca22ff2a5398f5ed80c72a6a6
3 files changed
+2
-1
src/wix/WixToolset.Core.WindowsInstaller/Decompile/Decompiler.cs
+1
-1
@@ -4506,7 +4506,7 @@ namespace WixToolset.Core.WindowsInstaller.Decompile
4506
{
4507
var xError = new XElement(Names.ErrorElement,
4508
new XAttribute("Id", row.FieldAsString(0)),
4509
- new XAttribute("Message", row.FieldAsString(1)));
4509
+ row.IsColumnNull(1) ? null : new XAttribute("Message", row.FieldAsString(1)));
4510
4511
this.UIElement.Add(xError);
4512
}
src/wix/test/WixToolsetTest.CoreIntegration/TestData/Decompile/ExpectedUI.wxs
+1
@@ -542,6 +542,7 @@
542
</UI>
543
<CustomAction Id="WixUIValidatePath" Return="ignore" BinaryRef="WixUIWixca" DllEntry="ValidatePath" />
544
<CustomAction Id="WixUIPrintEula" Return="ignore" BinaryRef="WixUIWixca" DllEntry="PrintEula" />
545
+ <Error Id="123" />
546
<Feature Id="ProductFeature" Title="ui" Level="1">
547
<ComponentRef Id="ProductComponent" />
548
</Feature>
src/wix/test/WixToolsetTest.CoreIntegration/TestData/Decompile/ui.msi
Binary files a/src/wix/test/WixToolsetTest.CoreIntegration/TestData/Decompile/ui.msi and b/src/wix/test/WixToolsetTest.CoreIntegration/TestData/Decompile/ui.msi differ