@joebigelow / wix / commits / bc9343ad

Obsolete removed PackageState.Cached value

A package's cached status is no longer set via the PackageState. The value was removed in native code but the managed code was missed throwing off the enum mapping. Fixes 7399

Rob Mensching committed May 30, 2023 at 08:28 UTC bc9343ad5c6133ae5f2d5233837beeee7041a292
2 files changed +7 -6
src/api/burn/WixToolset.Mba.Core/IBootstrapperEngine.cs
+6 -5
@@ -407,11 +407,6 @@ namespace WixToolset.Mba.Core
407 /// </summary>
408 Absent,
409
410 - /// <summary>
411 - /// The package is not installed but is in the package cache.
412 - /// </summary>
413 - Cached,
414 -
410 /// <summary>
411 /// The package is installed.
412 /// </summary>
@@ -421,6 +416,12 @@ namespace WixToolset.Mba.Core
416 /// The package is on the machine but not active, so only uninstall operations are allowed.
417 /// </summary>
418 Superseded,
419 +
420 + /// <summary>
421 + /// This value is no longer used. See the DetectPackageCompleteEventArgs.Cached value instead.
422 + /// </summary>
423 + [Obsolete("Use DetectPackageCompleteEventArgs.Cached instead.")]
424 + Cached = Present,
425 }
426
427 /// <summary>
src/test/burn/TestBA/TestBA.cs
+1 -1
@@ -299,7 +299,7 @@ namespace WixToolset.Test.BA
299 args.CacheType = cacheType;
300 }
301
302 - this.Log("OnPlanPackageBegin() - id: {0}, defaultState: {1}, requestedState: {2}, defaultCache: {3}, requestedCache: {4}", args.PackageId, args.RecommendedState, args.State, args.RecommendedCacheType, args.CacheType);
302 + this.Log("OnPlanPackageBegin() - id: {0}, currentState: {1}, defaultState: {2}, requestedState: {3}, defaultCache: {4}, requestedCache: {5}", args.PackageId, args.CurrentState, args.RecommendedState, args.State, args.RecommendedCacheType, args.CacheType);
303 }
304
305 protected override void OnPlanPatchTarget(PlanPatchTargetEventArgs args)