Deprecate WixDifxAppExtension.
https://github.com/wixtoolset/issues/issues/6648
Bob Arnson committed
Dec 12, 2021 at 15:40 UTC
e223ab393bdf04a9c3d0d2144b48a10d7b2650a2
2 files changed
+6
-3
src/ext/DifxApp/test/WixToolsetTest.DifxApp/DifxAppExtensionFixture.cs
+3
-2
@@ -29,8 +29,9 @@ namespace WixToolsetTest.DifxApp
29
30
private static void Build(string[] args)
31
{
32
- var result = WixRunner.Execute(args)
33
- .AssertSuccess();
32
+ var result = WixRunner.Execute(warningsAsErrors: false, args).AssertSuccess();
33
+
34
+ Assert.Single(result.Messages.Where(m => m.Id == (int)WixToolset.Data.WarningMessages.Ids.DeprecatedElement));
35
}
36
}
37
}
src/ext/DifxApp/wixext/DifxAppCompiler.cs
+3
-1
@@ -38,7 +38,6 @@ namespace WixToolset.DifxApp
38
{
39
case "Component":
40
var componentId = context["ComponentId"];
41
- var directoryId = context["DirectoryId"];
41
var componentWin64 = Boolean.Parse(context["Win64"]);
42
43
switch (element.Name.LocalName)
@@ -68,6 +67,9 @@ namespace WixToolset.DifxApp
67
int attributes = 0;
68
var sequence = CompilerConstants.IntegerNotSet;
69
70
+ // See https://github.com/wixtoolset/issues/issues/6648. DifxApp is deprecated so warn the user.
71
+ this.Messaging.Write(WarningMessages.DeprecatedElement(sourceLineNumbers, node.Name.LocalName));
72
+
73
// check the number of times a Driver element has been nested under this Component element
74
if (null != componentId)
75
{