reverseproxy: fix nil pointer dereference in AUpstreams.GetUpstreams (#5811)

fix a nil pointer dereference in AUpstreams.GetUpstreams when AUpstreams.Versions is not set (fixes caddyserver#5809) Signed-off-by: Pascal Vorwerk <info@fossores.de>

Pascal Vorwerk committed Sep 11, 2023 at 01:08 UTC 1e0dea59efc606f0eaec09993649930d12961bb9

1 file changed +2 -2

modules/caddyhttp/reverseproxy/upstreams.go

+2 -2

@@ -297,8 +297,8 @@ func (au *AUpstreams) Provision(_ caddy.Context) error {

297 func (au AUpstreams) GetUpstreams(r *http.Request) ([]*Upstream, error) {

298 repl := r.Context().Value(caddy.ReplacerCtxKey).(*caddy.Replacer)

299

300 - resolveIpv4 := au.Versions.IPv4 == nil || *au.Versions.IPv4

301 - resolveIpv6 := au.Versions.IPv6 == nil || *au.Versions.IPv6

300 + resolveIpv4 := au.Versions == nil || au.Versions.IPv4 == nil || *au.Versions.IPv4

301 + resolveIpv6 := au.Versions == nil || au.Versions.IPv6 == nil || *au.Versions.IPv6

302

303 // Map ipVersion early, so we can use it as part of the cache-key.

304 // This should be fairly inexpensive and comes and the upside of