admin: stabilise log redaction test (#7942)

Zen Dodd committed Aug 29, 2026 at 05:36 UTC 502691f5182123ef30f463d7f132e7c2fe55e2bf

1 file changed +6 -4

admin_test.go

+6 -4

@@ -271,19 +271,21 @@ func TestAdminHandlerServeHTTPRedactsSensitiveHeadersInLogs(t *testing.T) {

271 handler := adminHandler{

272 mux: http.NewServeMux(),

273 }

274 - req := httptest.NewRequest(http.MethodGet, "/", nil)

274 + req := httptest.NewRequest(http.MethodGet, "/redaction-test", nil)

275 req.Header.Set("Authorization", "Bearer secret")

276 req.Header.Set("Cookie", "session=secret")

277 req.Header.Set("X-Test", "ok")

278 rr := httptest.NewRecorder()

279

280 + Log().Info("unrelated test log")

281 handler.ServeHTTP(rr, req)

282

282 - if logs.Len() == 0 {

283 - t.Fatal("expected request log entry")

283 + entries := logs.FilterMessage("received request").FilterField(zap.String("uri", req.RequestURI)).All()

284 + if len(entries) != 1 {

285 + t.Fatalf("request log entries = %d, want 1", len(entries))

286 }

287

286 - ctx := logs.All()[0].ContextMap()

288 + ctx := entries[0].ContextMap()

289 headers, ok := ctx["headers"].(map[string]any)

290 if !ok {

291 t.Fatalf("expected headers field in log context, got %T", ctx["headers"])