Minor comments

Matthew Holt committed Dec 2, 2020 at 13:27 UTC 792fca40f18b7c528b00a7dea508bdfd0821dd8c

2 files changed +4 -1

modules/caddyhttp/server.go

@@ -74,6 +74,9 @@ type Server struct {

74 // handlers are executed sequentially. The sequence of invoked

75 // handlers comprises a compiled middleware chain that flows

76 // from each matching route and its handlers to the next.

77 + //

78 + // By default, all unrouted requests receive a 200 OK response

79 + // to indicate the server is working.

80 Routes RouteList `json:"routes,omitempty"`

82 // Errors is how this server will handle errors returned from any

modules/caddytls/connpolicy.go

+1 -1

@@ -66,7 +66,7 @@ func (cp ConnectionPolicies) TLSConfig(ctx caddy.Context) *tls.Config {

66 // using ServerName to match policies is extremely common, especially in configs

67 // with lots and lots of different policies; we can fast-track those by indexing

68 // them by SNI, so we don't have to iterate potentially thousands of policies

69 - // (TODO: this map does not account for wildcards, see if this is a problem in practice?)

69 + // (TODO: this map does not account for wildcards, see if this is a problem in practice? look for reports of high connection latency with wildcard certs but low latency for non-wildcards in multi-thousand-cert deployments)

70 indexedBySNI := make(map[string]ConnectionPolicies)

71 if len(cp) > 30 {

72 for _, p := range cp {