@marcel91200 / caddy Mirror · read-only / commits / 9864b138
Fork 0

Fast and extensible multi-platform HTTP/1-2-3 web server with automatic HTTPS

Mirrored from https://github.com/Slazee/caddy.git

Synced Nov 13, 16:45 UTC

reverseproxy: api: Remove misleading 'healthy' value

In v2.5.0, upstream health was fixed such that whether an upstream is considered healthy or not is mostly up to each individual handler's config. Since "healthy" is an opinion, it is not a global value. I unintentionally left in the "healthy" field in the API endpoint for checking upstreams, and it is now misleading (see #4792). However, num_requests and fails remains, so health can be determined by the API client, rather than having it be opaquely (and unhelpfully) determined for the client. If we do restore this value later on, it'd need to be replicated once per reverse_proxy handler according to their individual configs.

Matthew Holt committed Jun 2, 2022 at 12:32 UTC 9864b138fbae57615998a27158787f4468247476
1 file changed -1
modules/caddyhttp/reverseproxy/admin.go
-1
@@ -35,7 +35,6 @@ type adminUpstreams struct{}
35 // upstreamResults holds the status of a particular upstream
36 type upstreamStatus struct {
37 Address string `json:"address"`
38 - Healthy bool `json:"healthy"`
38 NumRequests int `json:"num_requests"`
39 Fails int `json:"fails"`
40 }