@matheusbsbs / matheus-bagliano / commits / 0024a54923
Fork 0

Fix the rename detection limit checking

This adds more proper rename detection limits. Instead of just checking the limit against the number of potential rename destinations, we verify that the rename matrix (which is what really matters) doesn't grow ridiculously large, and we also make sure that we don't overflow when doing the matrix size calculation. This also changes the default limits from unlimited, to a rename matrix that is limited to 100 entries on a side. You can raise it with the config entry, or by using the "-l<n>" command line flag, but at least the default is now a sane number that avoids spending lots of time (and memory) in situations that likely don't merit it. The choice of default value is of course very debatable. Limiting the rename matrix to a 100x100 size will mean that even if you have just one obvious rename, but you also create (or delete) 10,000 files, the rename matrix will be so big that we disable the heuristics. Sounds reasonable to me, but let's see if people hit this (and, perhaps more importantly, actually *care*) in real life. Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Linus Torvalds committed Sep 14, 2007 at 10:39 UTC 0024a54923a12f8c05ce4290f5ebefab0cce4336
3 files changed +19 -3
diff.c
+1 -1
@@ -17,7 +17,7 @@
17 #endif
18
19 static int diff_detect_rename_default;
20 -static int diff_rename_limit_default = -1;
20 +static int diff_rename_limit_default = 100;
21 static int diff_use_color_default;
22 int diff_auto_refresh_index = 1;
23
diffcore-rename.c
+17 -2
@@ -298,10 +298,25 @@ void diffcore_rename(struct diff_options *options)
298 else if (detect_rename == DIFF_DETECT_COPY)
299 register_rename_src(p->one, 1, p->score);
300 }
301 - if (rename_dst_nr == 0 || rename_src_nr == 0 ||
302 - (0 < rename_limit && rename_limit < rename_dst_nr))
301 + if (rename_dst_nr == 0 || rename_src_nr == 0)
302 goto cleanup; /* nothing to do */
303
304 + /*
305 + * This basically does a test for the rename matrix not
306 + * growing larger than a "rename_limit" square matrix, ie:
307 + *
308 + * rename_dst_nr * rename_src_nr > rename_limit * rename_limit
309 + *
310 + * but handles the potential overflow case specially (and we
311 + * assume at least 32-bit integers)
312 + */
313 + if (rename_limit <= 0 || rename_limit > 32767)
314 + rename_limit = 32767;
315 + if (rename_dst_nr > rename_limit && rename_src_nr > rename_limit)
316 + goto cleanup;
317 + if (rename_dst_nr * rename_src_nr > rename_limit * rename_limit)
318 + goto cleanup;
319 +
320 /* We really want to cull the candidates list early
321 * with cheap tests in order to avoid doing deltas.
322 * The first round matches up the up-to-date entries,
wt-status.c
+1
@@ -227,6 +227,7 @@ static void wt_status_print_updated(struct wt_status *s)
227 rev.diffopt.format_callback = wt_status_print_updated_cb;
228 rev.diffopt.format_callback_data = s;
229 rev.diffopt.detect_rename = 1;
230 + rev.diffopt.rename_limit = 100;
231 wt_read_cache(s);
232 run_diff_index(&rev, 1);
233 }