assume parse_commit checks commit->object.parsed
The parse_commit function will check the "parsed" flag of the object and do nothing if it is set. There is no need for callers to check the flag themselves, and doing so only clutters the code. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Oct 24, 2013 at 04:53 UTC
0064053bd76ba385e1b5d51b6175bc17bc507804
4 files changed
+6
-11
builtin/blame.c
+1
-2
@@ -1554,8 +1554,7 @@ static void assign_blame(struct scoreboard *sb, int opt)
1554
*/
1555
origin_incref(suspect);
1556
commit = suspect->commit;
1557
- if (!commit->object.parsed)
1558
- parse_commit(commit);
1557
+ parse_commit(commit);
1558
if (reverse ||
1559
(!(commit->object.flags & UNINTERESTING) &&
1560
!(revs->max_age != -1 && commit->date < revs->max_age)))
builtin/name-rev.c
+1
-2
@@ -27,8 +27,7 @@ static void name_rev(struct commit *commit,
27
struct commit_list *parents;
28
int parent_number = 1;
29
30
- if (!commit->object.parsed)
31
- parse_commit(commit);
30
+ parse_commit(commit);
31
32
if (commit->date < cutoff)
33
return;
builtin/show-branch.c
+1
-2
@@ -227,8 +227,7 @@ static void join_revs(struct commit_list **list_p,
227
parents = parents->next;
228
if ((this_flag & flags) == flags)
229
continue;
230
- if (!p->object.parsed)
231
- parse_commit(p);
230
+ parse_commit(p);
231
if (mark_seen(p, seen_p) && !still_interesting)
232
extra--;
233
p->object.flags |= flags;
fetch-pack.c
+3
-5
@@ -46,9 +46,8 @@ static void rev_list_push(struct commit *commit, int mark)
46
if (!(commit->object.flags & mark)) {
47
commit->object.flags |= mark;
48
49
- if (!(commit->object.parsed))
50
- if (parse_commit(commit))
51
- return;
49
+ if (parse_commit(commit))
50
+ return;
51
52
prio_queue_put(&rev_list, commit);
53
@@ -127,8 +126,7 @@ static const unsigned char *get_rev(void)
126
return NULL;
127
128
commit = prio_queue_get(&rev_list);
130
- if (!commit->object.parsed)
131
- parse_commit(commit);
129
+ parse_commit(commit);
130
parents = commit->parents;
131
132
commit->object.flags |= POPPED;