sha1_file: fix delta_stack memory leak in unpack_entry
This delta_stack array can grow to any length depending on the actual delta chain, but we forget to free it. Normally it does not matter because we use small_delta_stack[] from stack and small_delta_stack can hold 64-delta chains, more than standard --depth=50 in pack-objects. Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Nguyễn Thái Ngọc Duy committed
Feb 21, 2014 at 06:47 UTC
019d1e65f5bc715a40b1cd77852af0a649753c56
1 file changed
+4
sha1_file.c
+4
@@ -2058,6 +2058,10 @@ void *unpack_entry(struct packed_git *p, off_t obj_offset,
2058
*final_size = size;
2059
2060
unuse_pack(&w_curs);
2061
+
2062
+ if (delta_stack != small_delta_stack)
2063
+ free(delta_stack);
2064
+
2065
return data;
2066
}
2067